Re: cryptodisk: teach grub_cryptodisk_insert() about partitions (bug #45889)

2015-09-11 Thread Andrei Borzenkov
09.09.2015 04:18, TJ пишет: On 08-09-2015 17:38, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 06.09.2015 21:10, TJ wrote: https://savannah.gnu.org/bugs/index.php?45889 + if ((disk->partition && disk->partition->number == dev->partition_number) || + (!disk->partition && dev->par

Re: Development practices?

2015-09-11 Thread Andrei Borzenkov
09.09.2015 20:47, Felix Zielcke пишет: Am Dienstag, den 08.09.2015, 13:57 -0400 schrieb Konrad Rzeszutek Wilk: On Thu, Sep 03, 2015 at 03:34:29PM -0400, Konrad Rzeszutek Wilk wrote: I don't know enough about the community (or the history) to understand it but would very much appreciate input

Re: [PATCH] Make EFI watchdog behaviour configurable

2015-09-11 Thread Andrei Borzenkov
10.09.2015 03:11, Arthur Mesh пишет: Starting with d9a0c9413e81d3c0affc6383693bdd28dc863a5c, GRUB unconditionally disables watchdog on EFI platforms. This opens up a window (starting at GRUB's grub_efi_init(), until OS re-enables it) when EFI system operates w/o watchdog. If an EFI system gets st

Re: Development practices?

2015-09-11 Thread Konrad Rzeszutek Wilk
On Fri, Sep 11, 2015 at 05:34:45PM +0300, Andrei Borzenkov wrote: > 09.09.2015 20:47, Felix Zielcke пишет: > >Am Dienstag, den 08.09.2015, 13:57 -0400 schrieb Konrad Rzeszutek Wilk: > >>On Thu, Sep 03, 2015 at 03:34:29PM -0400, Konrad Rzeszutek Wilk > >>wrote: > > > >>I don't know enough about the

Re: [PATCH] Make EFI watchdog behaviour configurable

2015-09-11 Thread Arthur Mesh
On 9/11/15, 7:32 AM, "grub-devel-bounces+amesh=juniper@gnu.org on behalf of Andrei Borzenkov" wrote: >10.09.2015 03:11, Arthur Mesh пишет: >> Add `--enable-efi-watchdog' configure argument, which defaults to Off. >> When enabled, efi watchdog will not be disabled. >> Otherwise, efi watc

Re: cryptodisk: teach grub_cryptodisk_insert() about partitions (bug #45889)

2015-09-11 Thread TJ
On 11-09-2015 15:11, Andrei Borzenkov wrote: 09.09.2015 04:18, TJ пишет: On 08-09-2015 17:38, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 06.09.2015 21:10, TJ wrote: https://savannah.gnu.org/bugs/index.php?45889 + if ((disk->partition && disk->partition->number == dev->partition_num

Re: [PATCH] Ensure that MIPS target code is compiled for the O32 ABI.

2015-09-11 Thread Andrei Borzenkov
25.08.2015 21:18, Mark H Weaver пишет: Andrei Borzenkov writes: 24.08.2015 11:12, Andrei Borzenkov пишет: Could you test attached patch for both gcc and clang? Use configure TARGET_CC=clang Sorry, was broken, fixed version attached. Your patch works for me with gcc, although config.log s

Re: Development practices?

2015-09-11 Thread Andrei Borzenkov
11.09.2015 17:48, Konrad Rzeszutek Wilk пишет: On Fri, Sep 11, 2015 at 05:34:45PM +0300, Andrei Borzenkov wrote: 09.09.2015 20:47, Felix Zielcke пишет: Am Dienstag, den 08.09.2015, 13:57 -0400 schrieb Konrad Rzeszutek Wilk: On Thu, Sep 03, 2015 at 03:34:29PM -0400, Konrad Rzeszutek Wilk wrote:

Re: [PATCH] Make EFI watchdog behaviour configurable

2015-09-11 Thread Andrei Borzenkov
11.09.2015 17:53, Arthur Mesh пишет: On 9/11/15, 7:32 AM, "grub-devel-bounces+amesh=juniper@gnu.org on behalf of Andrei Borzenkov" wrote: 10.09.2015 03:11, Arthur Mesh пишет: Add `--enable-efi-watchdog' configure argument, which defaults to Off. When enabled, efi watchdog will not b

Re: Development practices?

2015-09-11 Thread Konrad Rzeszutek Wilk
. snip.. > > From what I have gathered so far the not enough reviewers > >is tied in folks being overworked - so there simply was no > >point of posting on the mailing list as nobody had the time > >to review it or test it properly? > > > >>> > >>>Hi Konrad, > >>> > >>>back in 2

Re: [PATCH] Make EFI watchdog behaviour configurable

2015-09-11 Thread Arthur Mesh
On Fri, Sep 11, 2015 at 06:24:30PM +0300, Andrei Borzenkov wrote: > >> Why is it not enough? You can always add it to your grub.cfg. > > > > Well, it still leaves a window of time where the system operates w/o a > > watchdog. > > It could be a problem if grub.cfg resides on a network file system,

Re: [PATCH] efinet: retransmit if our device is busy

2015-09-11 Thread Andrei Borzenkov
31.08.2015 20:34, Josef Bacik пишет: When I fixed the txbuf handling I ripped out the retransmission code since it was flooding our network when we had the buggy behavior. Turns out this was too heavy handed as we can still have transient tx timeouts. So instead make sure we retry our transmiss

Re: [PATCH] efinet: retransmit if our device is busy

2015-09-11 Thread Josef Bacik
On 09/11/2015 12:49 PM, Andrei Borzenkov wrote: 31.08.2015 20:34, Josef Bacik пишет: When I fixed the txbuf handling I ripped out the retransmission code since it was flooding our network when we had the buggy behavior. Turns out this was too heavy handed as we can still have transient tx timeo