Re: [PATC] Unit testing framework adjusted over trunk

2010-01-12 Thread BVK Chaitanya
An updated patch is attached with some fixes mentioned below: 1. Added --boot=[fd|hd|cd] option support to grub-shell script. By default grub-shell script now starts Qemu with disk image, but with --boot=fd or --boot=cd options, Qemu will be booted with floppy or cdrom image respectively. This

Re: [RFC] Multiboot ammendment: non-VBE video

2010-01-12 Thread Robert Millan
Hi, I committed your last patch with some minor stylistic adjustments, plus your changes to the example kernel. -- Robert Millan "Be the change you want to see in the world" -- Gandhi ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gn

Multiboot video in GRUB (Re: [RFC] Multiboot ammendment: non-VBE video)

2010-01-12 Thread Robert Millan
On Sat, Jan 02, 2010 at 07:26:08PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > === added file 'ChangeLog.efiboot' > --- ChangeLog.efiboot 1970-01-01 00:00:00 + > +++ ChangeLog.efiboot 2010-01-02 01:48:33 + > @@ -0,0 +1,19 @@ > +2009-11-28 Vladimir Serbinenko > + > + Multib

Build error: "ENABLE_NLS" is not defined

2010-01-12 Thread Grégoire Sutre
Hi, When NLS is disabled or not supported, the macro ENABLE_NLS is not defined, and this breaks compilation of GRUB modules as they are compiled with -Werror -Wundef by default. This is with bazaar trunk. $ ./autogen.sh && ./configure && gmake [...] gcc -Ikern -I./kern -nostdinc -isystem /us

Re: Build error: "ENABLE_NLS" is not defined

2010-01-12 Thread richardvo...@gmail.com
2010/1/12 Grégoire Sutre : > Hi, > > When NLS is disabled or not supported, the macro ENABLE_NLS is not defined, > and this breaks compilation of GRUB modules as they are compiled with > -Werror -Wundef by default.  This is with bazaar trunk. > > $ ./autogen.sh && ./configure && gmake > [...] > gcc

Re: Build error: "ENABLE_NLS" is not defined

2010-01-12 Thread Grégoire Sutre
richardvo...@gmail.com wrote: This fix breaks when ENABLE_NLS is defined as 0. AFAICS, in the implementation of AM_GNU_GETTEXT, ENABLE_NLS is either not defined or set to 1. But I agree that my proposed fix is too dependent on the implementation of AM_GNU_GETTEXT, which may change. Anoth

Re: Build error: "ENABLE_NLS" is not defined

2010-01-12 Thread richardvo...@gmail.com
2010/1/12 Grégoire Sutre : > richardvo...@gmail.com wrote: > >> This fix breaks when ENABLE_NLS is defined as 0. > > AFAICS, in the implementation of AM_GNU_GETTEXT, ENABLE_NLS is either not > defined or set to 1. > > But I agree that my proposed fix is too dependent on the implementation of > AM_G

keyboard layouts

2010-01-12 Thread Carles Pina i Estany
Hi, I'm looking again to the keyboard layouts task. Plan: - Use the X11 layouts that usually are in /usr/share/X11/xkb/symbols . - Create a new module that reads the layout from an environtment variable. * Approach 1 The module will load the layout from /usr/share/X11/xkb/symbols/XX replacing t

Re: keyboard layouts

2010-01-12 Thread Colin Watson
On Tue, Jan 12, 2010 at 09:47:43PM +, Carles Pina i Estany wrote: > Plan: > - Use the X11 layouts that usually are in /usr/share/X11/xkb/symbols . > - Create a new module that reads the layout from an environtment variable. > > * Approach 1 > The module will load the layout from /usr/share/X11

Re: keyboard layouts

2010-01-12 Thread Carles Pina i Estany
Hi, On Jan/12/2010, Colin Watson wrote: > On Tue, Jan 12, 2010 at 09:47:43PM +, Carles Pina i Estany wrote: > > Plan: > > * Approach 2 > > Small program (I guess that you prefer C, Python would be nice too) that > > when Grub is installed would process the /usr/share/X11/xkb/symbols > > file

Re: keyboard layouts

2010-01-12 Thread Colin Watson
On Tue, Jan 12, 2010 at 11:29:59PM +, Carles Pina i Estany wrote: > On Jan/12/2010, Colin Watson wrote: > > the gfxboot-theme-ubuntu package in Ubuntu, specifically the > > scrape-console-setup script. It makes use of console-setup to process > > XKB keymaps into a form that can then be run th

Re: Build error: "ENABLE_NLS" is not defined

2010-01-12 Thread Grégoire Sutre
richardvo...@gmail.com wrote: Another option would be to replace #if ENABLE_NLS by #if defined(ENABLE_NLS) && ENABLE_NLS. I know the C compiler short-circuits &&, if the preprocessor does also then this looks like the best solution. If not, then nested #if. Yes the preprocessor also short-c