Re: [PATCH] xfs bug fix

2009-07-19 Thread Bean
On Sun, Jul 19, 2009 at 12:40 PM, Pavel Roskin wrote: > Quoting Pavel Roskin : > >> ==11029== Conditional jump or move depends on uninitialised value(s) >> ==11029==    at 0x403CAE: grub_disk_adjust_range (disk.c:373) >> ==11029==    by 0x403D6C: grub_disk_read (disk.c:392) >> ==11029==    by 0x41C

Re: [PATCH] Bug fix for LVM

2009-07-19 Thread Bean
On Sun, Jul 19, 2009 at 4:05 AM, Robert Millan wrote: > On Sat, Jul 18, 2009 at 09:59:55PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> On Sat, Jul 18, 2009 at 9:43 PM, Bean wrote: >> > On Sun, Jul 19, 2009 at 3:11 AM, Robert Millan wrote: >> >> On Sat, Jul 18, 2009 at 10:11:19PM +0800, Bean wrot

Re: [PATCH] Fix when installing on pationless but partionable medium

2009-07-19 Thread Colin Watson
On Sat, Jul 18, 2009 at 09:22:11PM +0200, Robert Millan wrote: > On Sat, Jul 18, 2009 at 09:00:36PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > On Sat, Jul 18, 2009 at 8:42 PM, Robert Millan wrote: > > > I'm not sure there's much we can do about this.  Using heuristics sounds > > > like > > >

Re: [PATCH] New object format

2009-07-19 Thread Bean
On Sun, Jul 19, 2009 at 9:52 AM, Isaac Dupree wrote: > Bean wrote: >> >> Hi, >> >> This patch implement a new object format, the advantages are: >> >> Reduce size dramatically, some result: >> >> Size of all modules: >> >> original: 645575 >> new: 519093 > > [I thought I sent this message a few day

Re: [PATCH] Fix when installing on pationless but partionable medium

2009-07-19 Thread Colin Watson
On Sat, Jul 18, 2009 at 09:17:41PM +0200, Robert Millan wrote: > On Sat, Jul 18, 2009 at 09:01:38PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > On Sat, Jul 18, 2009 at 8:45 PM, Robert Millan wrote: > > > I might be missing something about this check, but GRUB doesn't require > > > that > > > t

[PATCH] Support for OSX (replace the old one)

2009-07-19 Thread Yves Blusseau
Hi, here's a patch so grub-setup can be compiled and work on MacOSX. The only problem remaining is trampoline (nested functions), because OSX don't want to execute code in the heap. This patch is a rewriting of the last patch with good identation and no misleading variables. Best Regards

[PATCH] Support for OSX (replace the old one)

2009-07-19 Thread Yves Blusseau
Hi, here's a patch so grub-setup can be compiled and work on MacOSX. The only problem remaining is trampoline (nested functions), because OSX don't want to execute code in the heap. This patch is a rewriting of the last patch with good identation and no misleading variables. Best Regards

Re: [PATCH] AFS fixes and improvements

2009-07-19 Thread Vladimir 'phcoder' Serbinenko
On Sun, Jul 19, 2009 at 7:11 AM, Pavel Roskin wrote: > Quoting Vladimir 'phcoder' Serbinenko : > >> Update: added symlink support >> >> On Fri, Jul 17, 2009 at 9:30 PM, Vladimir 'phcoder' >> Serbinenko wrote: >>> >>> Hello. Currently I'm coding BFS (filesystem of BeOS and Haiku) which >>> is simila

Lua scripts for booting LiveCD iso files

2009-07-19 Thread Ron
Hi, I've written two lua scripts that can automatically detect and boot LiveCD iso files. I'm using these scripts on my USB-Stick, so I can just put the LiveCD iso file on it and use it and don't have to use the different LiveCD to USB tools, which often not allow more than one Live System on one

Re: [PATCH] AFS fixes and improvements

2009-07-19 Thread Vladimir 'phcoder' Serbinenko
>> It's better to split fixes from the new features. Attached patches >> >> I don't have afs images around.  It would be great if you test all new >> functionality with valgrind.  It's very good at finding mistakes in the >> code. >> > I will do. I use the publically-available image from > http://w

Re: [PATCH] BFS support

2009-07-19 Thread Vladimir 'phcoder' Serbinenko
On Sat, Jul 18, 2009 at 8:51 PM, Robert Millan wrote: > On Sat, Jul 18, 2009 at 12:59:45AM +0200, Vladimir 'phcoder' Serbinenko wrote: >> Hello. Here is a patch to add BFS support to GRUB2. BFS is a >> filesystem which was originally developped by Be, Inc for their >> proprietary BeOS. When Be Inc

Re: [PATCH 2/2] Disable lzo compression, lzma is doing its job just fine

2009-07-19 Thread Pavel Roskin
On Sat, 2009-07-18 at 20:18 +0200, Robert Millan wrote: > It doesn't break things, since it's barely modified, and doesn't interact with > the rest of the code, but simply having more code means an added work to > maintain it when we restructure things, etc. It needs to pay off in some way. Exac

Re: [PATCH 2/2] Disable lzo compression, lzma is doing its job just fine

2009-07-19 Thread Vladimir 'phcoder' Serbinenko
> There then there is an issue of user choice.  I think we are offering > too many choices without explaining what's behind it. > > I could say lzo is "old and proven" and lzma is "new and more > effective", but since lzo is disabled by default and there are no > complaints about it, keeping lzo be

Re: [PATCH] Bug fix for LVM

2009-07-19 Thread Patrik Horník
Bean, should Grub2 with this patch work if the boot partition is LVM volume and LVM is placed on top of RAID 5 arrays? Thanks, Patrik On Sat, Jul 18, 2009 at 16:11, Bean wrote: > Hi, > > This patch fixes a few bug in lvm. > > There can be multiple copies of meta data, it's not an error, ignore

Re: [PATCH] Bug fix for LVM

2009-07-19 Thread Bean
On Mon, Jul 20, 2009 at 3:11 AM, Patrik Horník wrote: > Bean, should Grub2 with this patch work if the boot partition is LVM > volume and LVM is placed on top of RAID 5 arrays? Hi, Yeah, it should work, please try it out. -- Bean ___ Grub-devel mail

Re: [PATCH] AFS fixes and improvements

2009-07-19 Thread Pavel Roskin
On Sun, 2009-07-19 at 17:34 +0200, Vladimir 'phcoder' Serbinenko wrote: > >> It's better to split fixes from the new features. > Attached patches > >> > >> I don't have afs images around. It would be great if you test all new > >> functionality with valgrind. It's very good at finding mistakes in

Re: [PATCH] AFS fixes and improvements

2009-07-19 Thread Pavel Roskin
On Sun, 2009-07-19 at 15:20 +0200, Vladimir 'phcoder' Serbinenko wrote: > > - if ((! dir->inode.stream.size) || > > + if ((dir->inode.stream.size == 0) || > > > > The later is marginally better, but it would be easier to review your > > patches if you don't include such changes. > It's not a sty

Re: [PATCH] AFS fixes and improvements

2009-07-19 Thread Vladimir 'phcoder' Serbinenko
On Sun, Jul 19, 2009 at 10:10 PM, Pavel Roskin wrote: > On Sun, 2009-07-19 at 15:20 +0200, Vladimir 'phcoder' Serbinenko wrote: > >> > -  if ((! dir->inode.stream.size) || >> > +  if ((dir->inode.stream.size == 0) || >> > >> > The later is marginally better, but it would be easier to review your >>

Re: [PATCH] AFS fixes and improvements

2009-07-19 Thread Vladimir 'phcoder' Serbinenko
On Sun, Jul 19, 2009 at 9:56 PM, Pavel Roskin wrote: > On Sun, 2009-07-19 at 17:34 +0200, Vladimir 'phcoder' Serbinenko wrote: >> >> It's better to split fixes from the new features. >> Attached patches >> >> >> >> I don't have afs images around.  It would be great if you test all new >> >> functio

Re: [PATCH] AFS fixes and improvements

2009-07-19 Thread Pavel Roskin
On Sun, 2009-07-19 at 22:23 +0200, Vladimir 'phcoder' Serbinenko wrote: > Yes, I did it too and valgrind only issued some warnings about my -O3 > libraries and found a memory leak caused by pc_partition_map_parse. I know. > This function anyway will be removed with my nested partition patch > (B

Re: [PATCH 2/2] Disable lzo compression, lzma is doing its job just fine

2009-07-19 Thread Pavel Roskin
On Sun, 2009-07-19 at 20:24 +0200, Vladimir 'phcoder' Serbinenko wrote: > Now I agree with you. No further oppositions from me Committed. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/gr

Re: [PATCH] AFS fixes and improvements

2009-07-19 Thread Vladimir 'phcoder' Serbinenko
> I prefer not to fix minor memory leaks by huge patches.  I have a patch, > I just wanted to look at the possibility to use grub_kzalloc() and > allocating data as part of the partition. Well nested partition patch changes the way how partitions are handled and fix for memory leak probably wouldn'

Re: [PATCH] AFS fixes and improvements

2009-07-19 Thread Pavel Roskin
On Sun, 2009-07-19 at 22:40 +0200, Vladimir 'phcoder' Serbinenko wrote: > > I prefer not to fix minor memory leaks by huge patches. I have a patch, > > I just wanted to look at the possibility to use grub_kzalloc() and > > allocating data as part of the partition. > Well nested partition patch cha