On Sun, Jul 19, 2009 at 9:56 PM, Pavel Roskin<pro...@gnu.org> wrote: > On Sun, 2009-07-19 at 17:34 +0200, Vladimir 'phcoder' Serbinenko wrote: >> >> It's better to split fixes from the new features. >> Attached patches >> >> >> >> I don't have afs images around. It would be great if you test all new >> >> functionality with valgrind. It's very good at finding mistakes in the >> >> code. >> >> >> > I will do. I use the publically-available image from >> > http://web.syllable.org/pages/get-Syllable.html#emulate > > I could not use those images directly, but I installed Syllable on a > virtual hard drive under qemu. Sorry, I'm so accustomed to convert vmware image to raw images before mounting them or using grub-fstest. To do so use: > qemu-img convert image.vmdk image.img > I could successfully read the image with > the patches. I tried grub-fstest under valgrind, and it was fine. Yes, I did it too and valgrind only issued some warnings about my -O3 libraries and found a memory leak caused by pc_partition_map_parse. This function anyway will be removed with my nested partition patch (BTW I rediffed and resent it and it works fine here (plain and bsd configurations). Tomorrow I'll test it with opensolaris). > > Thanks for the patches! > You're welcome > -- > Regards, > Pavel Roskin > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel >
-- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
