Re: [PATCH] savedefault

2009-06-07 Thread Felix Zielcke
Am Montag, den 01.06.2009, 12:48 +0200 schrieb Vladimir 'phcoder' Serbinenko: > Hello. Here is a long-awaited savedefault patch. Works correctly only > if my scripting fix is applied What happens if this is used on RAID? Especially when the grubenv file is wrapped by the chunksize? We should consi

Re: [PATCH] support of hfsx ( case comparaison )

2009-06-07 Thread Vladimir 'phcoder' Serbinenko
On Sun, Jun 7, 2009 at 4:18 AM, Pavel Roskin wrote: >>  Improving >> strcasecmp is possible and may even be compact. Even if unicode counts >> a lot of alphabets only few are bicameral. AFAIK main ones are Latin, >> Greek, Cyrillic and Armenian. I hope that in most cases the lowercase >> conversion

Re: [PATCH] savedefault

2009-06-07 Thread Vladimir 'phcoder' Serbinenko
On Sun, Jun 7, 2009 at 9:50 AM, Felix Zielcke wrote: > Am Montag, den 01.06.2009, 12:48 +0200 schrieb Vladimir 'phcoder' > Serbinenko: >> Hello. Here is a long-awaited savedefault patch. Works correctly only >> if my scripting fix is applied > > What happens if this is used on RAID? Then writing is

Re: [PATCH] savedefault

2009-06-07 Thread Bean
Hi, Actually, I'm thinking about a more generic method to implement this feature with events. The menu viewer fire events at certain circumstance, and we can configure the commands to execute. For example, we could have a menu.select event fire when a menu item is selected, and use something like

Re: 2273 lines in 170 files consists of only space and tabulators

2009-06-07 Thread Felix Zielcke
Am Samstag, den 06.06.2009, 21:59 -0400 schrieb Pavel Roskin: > By the way, our style is slightly different from that used by GNU > indent. GRUB uses space after "!", whereas GNU indent doesn't. Also, > some GRUB sources use one space before labels, and GNU indent starts > labels from the first c

Re: [PATCH] savedefault

2009-06-07 Thread Vladimir 'phcoder' Serbinenko
Hello. Welcome back On Sun, Jun 7, 2009 at 11:35 AM, Bean wrote: > Hi, > > Actually, I'm thinking about a more generic method to implement this > feature with events. The menu viewer fire events at certain > circumstance, and we can configure the commands to execute. For > example, we could have a

[PATCH] add drivemap support to 30_os-prober.in and use UUIDs

2009-06-07 Thread Felix Zielcke
Attached patch uses `prepare_grub_to_access_device' to set the root in the generated entrys. And it adds drivemap to the chainload ones, if root isn't (hd0). The Debian grub-installer adds map only with Dos and Windows, should I do the same or is it okay to do it for all? -# update-grub helper sc

Re: [PATCH] add drivemap support to 30_os-prober.in and use UUIDs

2009-06-07 Thread Pavel Roskin
On Sun, 2009-06-07 at 17:37 +0200, Felix Zielcke wrote: > Attached patch uses `prepare_grub_to_access_device' to set the root in > the generated entrys. > And it adds drivemap to the chainload ones, if root isn't (hd0). > > The Debian grub-installer adds map only with Dos and Windows, should I > d

Re: [PATCH] support of hfsx ( case comparaison )

2009-06-07 Thread Pavel Roskin
On Sun, 2009-06-07 at 11:10 +0200, Vladimir 'phcoder' Serbinenko wrote: > On Sun, Jun 7, 2009 at 4:18 AM, Pavel Roskin wrote: > >> Improving > >> strcasecmp is possible and may even be compact. Even if unicode counts > >> a lot of alphabets only few are bicameral. AFAIK main ones are Latin, > >> G

Grub needs to check the programming interface for usb controllers

2009-06-07 Thread Oliver Henshaw
Grub needs to check that the usb programming interface is of the correct type. Otherwise, hilarity ensues when e.g. bus/usb/ohci.c attempts to initialise an uhci controller. This can easily be reproduced by typing 'insmod ohci' in the grub rescue disk in qemu, with usb enabled. Additionally, the u

[PATCH 1/4] bus/usb minor cleanups

2009-06-07 Thread Oliver Henshaw
usb-minor-cleanup Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 2/4] Fix inteface definition for ohci

2009-06-07 Thread Oliver Henshaw
usb-fix-interface Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 3/4] Check usb programming interface

2009-06-07 Thread Oliver Henshaw
usb-check-interface Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 4/4] Define fields in terms of the Class Code register

2009-06-07 Thread Oliver Henshaw
usb-change-to-class_code Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] Link usb controller struct only when initialised

2009-06-07 Thread Oliver Henshaw
When controller initialisation is aborted in grub_uhci_pci_iter (grub_ohci_pci_iter) control jumps to "fail:", where any allocated memory is freed. However, the struct grub_uhci *u (struct grub_ohci *o) for that controller remains linked to the list of UHCI (OHCI) controllers. This causes problems

insmod uhci causes computer to reset

2009-06-07 Thread Oliver Henshaw
Even with the fixes described previously, grub fails with an UHCI controller (VIA uhci chipset on the motherboard). When no devices are attached, module loading completes successfully. When a mouse is attached, module loading completes but listing the device with 'usb' causes the machine to reset.

insmod ohci fails to register usb ports

2009-06-07 Thread Oliver Henshaw
Even with the fixes mentioned previously, grub fails with an OHCI controller (NEC ohci/ehci chipset on a PCI card). It seems to successfully initialise the controller, but fails to enumerate the ports. The same output is seen with a mouse attached as with no devices attached. grub> insmod ohc

Re: insmod uhci causes computer to reset

2009-06-07 Thread Pavel Roskin
On Sun, 2009-06-07 at 20:03 +0100, Oliver Henshaw wrote: > Even with the fixes described previously, grub fails with an UHCI > controller (VIA uhci > chipset on the motherboard). When no devices are attached, module > loading completes > successfully. When a mouse is attached, module loading comple

Re: insmod uhci causes computer to reset

2009-06-07 Thread Oliver Henshaw
2009/6/7 Pavel Roskin : > Maybe the crash is in usb_keyboard? I don't think that can be it. AFAICS usb_keyboard would only be called if I manually loaded the model. And I've never done that. ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gn

Re: insmod ohci fails to register usb ports

2009-06-07 Thread Oliver Henshaw
2009/6/7 Oliver Henshaw : > Even with the fixes mentioned previously, grub fails with an OHCI > controller (NEC ohci/ehci chipset on a PCI card). It seems to successfully > initialise the > controller, but fails to enumerate the ports. The same output is seen with a > mouse > attached as with no

Re: [PATCH 1/4] bus/usb minor cleanups

2009-06-07 Thread Pavel Roskin
Hello, Oliver! Your patches are sent as attachments, which makes it hard to view and comment them. It's better to send everything inline. My preference is to use STGit with the git mirror of grub, which is located at git://repo.or.cz/grub2.git Then "stg mail" will send the messages inline. Use

Re: insmod uhci causes computer to reset

2009-06-07 Thread Pavel Roskin
On Sun, 2009-06-07 at 21:22 +0100, Oliver Henshaw wrote: > 2009/6/7 Pavel Roskin : > > Maybe the crash is in usb_keyboard? > I don't think that can be it. AFAICS usb_keyboard would only be called > if I manually loaded the model. And I've never done that. I see. Anyway, the USB code needs a lot o

Re: [PATCH] drivemap fixes

2009-06-07 Thread Pavel Roskin
On Fri, 2009-06-05 at 16:27 +0200, Vladimir 'phcoder' Serbinenko wrote: > Hello. As suggested by Javier Martín I move this to a new thread. This > patch fixes some problems with determining bios number of a disk. > biosnum is in boot.mod because it's where it will cause the least of > possible core