[PATCH] improve error messages in grub-setup

2009-05-02 Thread Robert Millan
This patch improves error messages in grub-setup, and adds a few warnings when requested to install in odd layouts. Since there was no facility to emmit a warning that is always visible (regardless of verbosity), but doesn't abort execution, I added one (grub_util_warn ()). Is everyone fine with

Re: [PATCH] Video mode fixes in linux loader

2009-05-02 Thread Robert Millan
On Mon, Apr 13, 2009 at 07:20:20PM -0400, Pavel Roskin wrote: > > We could detect this situation by checking video= parameter, and setting > > text mode if intelfb is found. But then again do we want to prevent > > future versions of intelfb from gracefuly transitioning from vesa mode > > without

Re: [PATCH] Video mode fixes in linux loader

2009-05-02 Thread Robert Millan
On Tue, Apr 14, 2009 at 02:02:46AM +0200, phcoder wrote: > With proposed autodetections bootloader becomes overzealous. I think it > should be configirable but in a more modern way. I think gfxpayload with > the same syntax as gfxmode plus additional platform-specific keywords > like text80x2

Re: Crash in usb_keyboard

2009-05-02 Thread Robert Millan
On Mon, Apr 27, 2009 at 11:55:10PM -0400, Pavel Roskin wrote: > Hello! > > Running "terminal_input.usb_keyboard" crashed GRUB (or qemu it's running > in). It turns out we never check if usbdev in term/usb_keyboard.c is > not NULL. It is NULL if no USB host controllers have been detected. > > I'

Re: truecrypt support in grub ?

2009-05-02 Thread Robert Millan
On Wed, Apr 15, 2009 at 06:58:54PM +0530, J. Bakshi wrote: > Hello list, > > GRUB2 is a robust boot loader. Is it possible to have truecrypt encryption > support dirctly in GRUB2 ? Then we can have truecrypt encrypted partition > with linux installed and GRUB2 just decrypt it and load the kernel

Re: Code quality

2009-05-02 Thread Robert Millan
On Wed, Apr 15, 2009 at 06:10:53PM -0400, Pavel Roskin wrote: > Hello! > > It seems to me that the code quality has decreased in the last weeks. > In the same time, we have a growing number of compiler warnings. It > looks like there is a relationship between the two. > > I'll appreciate if ever

Re: Kexec loading grub2

2009-05-02 Thread Robert Millan
On Tue, Apr 14, 2009 at 02:28:21PM -0700, Joey Korkames wrote: > 1) Add a 32-bit load segment to boot/i386/pc/lnxboot.S as described by > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/x86/boot.txt > (at the bottom) > > grub4dos (which is kexec'able) impl

[BUGFIX] lexer waits for space to terminate the varname

2009-05-02 Thread Vladimir 'phcoder' Serbinenko
Hello. A varname may be terminated by any character which isn't in a set [A-Za-z0-9_] and not only space. Here is a fix -- Regards Vladimir 'phcoder' Serbinenko diff --git a/kern/parser.c b/kern/parser.c index e931853..feaee09 100644 --- a/kern/parser.c +++ b/kern/parser.c @@ -71,7 +71,10 @@ grub

Re: [BUGFIX] lexer waits for space to terminate the varname

2009-05-02 Thread Bean
Hi, I think there is problem with this patch. Consider ${aa}, the closing character "}" would be left out. Although you can remedy this by swapping: { GRUB_PARSER_STATE_VARNAME, GRUB_PARSER_STATE_TEXT, ' ', 1}, { GRUB_PARSER_STATE_VARNAME2, GRUB_PARSER_STATE_TEXT, '}', 0}, so that '}' would

Re: [PATCH]: Missing newline at end of file.

2009-05-02 Thread Robert Millan
On Wed, Apr 29, 2009 at 06:28:53PM -0700, David Miller wrote: > diff --git a/normal/command.c b/normal/command.c > index 863d45f..3296515 100644 > --- a/normal/command.c > +++ b/normal/command.c > @@ -67,4 +67,4 @@ grub_command_execute (char *cmdline, int interactive) > grub_set_more (0); >

Re: [PATCH]: Fix fs modules on sparc64 build with newer gcc

2009-05-02 Thread Robert Millan
On Sat, Apr 11, 2009 at 01:27:31AM -0700, David Miller wrote: > --- a/configure.ac > +++ b/configure.ac > @@ -200,7 +200,7 @@ if test "$target_cpu"-"$platform" = i386-pc; then > fi > > # Check for functions. > -AC_CHECK_FUNCS(posix_memalign memalign asprintf) > +AC_CHECK_FUNCS(posix_memalign me

Re: [PATCH] Video mode fixes in linux loader

2009-05-02 Thread Robert Millan
On Sat, May 02, 2009 at 01:31:14PM +0200, Robert Millan wrote: > > > > "vga=ask" is not a warning now. It causes "error: You need to load the > > > > kernel first", apparently from initrd. In other words, the "linux" > > > > command fails and there is no visible warning. > > > > > > Sounds like

absence notice...

2009-05-02 Thread Vesa Jääskeläinen
Hi All, I will be absence from the project related work for a while... So please feel free to continue or replace the work that I may have got pending. Some tasks that could be done: - Video API: save/restore mode. Use "anonymous" data structure that only device driver itself understands. Having

Re: [PATCH] Split #2: parser/reader separation

2009-05-02 Thread Bean
Hi, Thanks for the review, commit it now. On Sat, May 2, 2009 at 6:15 AM, Vladimir 'phcoder' Serbinenko wrote: > Patch looks fine for me. I think you can commit it > As for lua put the origin clearly and put the original copyright notice > below grub's one. Tomorrow I'll do the same for freebsd6

Re: absence notice...

2009-05-02 Thread Vladimir 'phcoder' Serbinenko
Hello, Vesa. Take your time and have fun. 2009/5/2 Vesa Jääskeläinen > Hi All, > > I will be absence from the project related work for a while... So please > feel free to continue or replace the work that I may have got pending. > > Some tasks that could be done: > > - Video API: save/restore mo

Re: absence notice...

2009-05-02 Thread Vesa Jääskeläinen
Vladimir 'phcoder' Serbinenko wrote: > I will do this. I know you already had some work for mm underway that's why > I wasn't doing it. Could you send what you already have even if it's far > from complete? Sorry. Everything got lost on laptop. ___ G

Re: Kexec loading grub2

2009-05-02 Thread Joey Korkames
Please use Multiboot. It's about time we start standarising on boot protocols... # kexec --type multiboot-x86 --load grub2.elf issues this error: > Base address: 8200 is not page aligned Multiboot doesn't require that load addresses are page aligned, but I think you can change the link ad

Re: [PATCH] ACPI spoofing

2009-05-02 Thread Vladimir 'phcoder' Serbinenko
commited On Mon, Apr 27, 2009 at 9:37 PM, Vladimir 'phcoder' Serbinenko < phco...@gmail.com> wrote: > Should work on EFI now > > On Sat, Apr 11, 2009 at 11:06 PM, phcoder wrote: > >> Hello, here is the patch to spoof ACPI tables. It's useful for >> developement and debugging but also for the end-

Re: [PATCH] efiemu

2009-05-02 Thread Vladimir 'phcoder' Serbinenko
commited On Mon, Apr 27, 2009 at 9:40 PM, Vladimir 'phcoder' Serbinenko < phco...@gmail.com> wrote: > Install scripts fixed. Additionally now skipped commands (efiemu_loadcore, > efiemu_pnvram) are executed automatically > > > On Wed, Apr 15, 2009 at 12:10 AM, phcoder wrote: > >> Hello here is r

Re: [PATCH] xnu

2009-05-02 Thread Vladimir 'phcoder' Serbinenko
commited On Mon, Apr 27, 2009 at 9:42 PM, Vladimir 'phcoder' Serbinenko < phco...@gmail.com> wrote: > Update. No need to initialize efiemu manually anymore > > On Wed, Apr 15, 2009 at 12:46 AM, phcoder wrote: > >> Hello. Here is my xnu patch. Tested on i386-pc, i386-efi and x86_64-efi. >> On non

Re: [PATCH] Video mode fixes in linux loader

2009-05-02 Thread BandiPat
Robert Millan wrote: On Sat, May 02, 2009 at 01:31:14PM +0200, Robert Millan wrote: "vga=ask" is not a warning now. It causes "error: You need to load the kernel first", apparently from initrd. In other words, the "linux" command fails and there is no visible warning. Sounds like my error cod

Re: status grub2 port of grub-legasy map command

2009-05-02 Thread Javier Martín
I am glad to inform that, with the new version of the mmap patch, drivemap now boots all my hd1 installs of: - Windows XP (Pro x64) - ReactOS - FreeDOS I would suggest, however, that the return type of grub_mmap_malign_and_register be changed to void* from char*, just like the return type from mal

Re: truecrypt support in grub ?

2009-05-02 Thread Chip Panarchy
^Ah. What would you suggest instead, for a free full-drive encryption? On Sat, May 2, 2009 at 9:40 PM, Robert Millan wrote: > On Wed, Apr 15, 2009 at 06:58:54PM +0530, J. Bakshi wrote: > > Hello list, > > > > GRUB2 is a robust boot loader. Is it possible to have truecrypt > encryption support d

Re: [PATCH] FreeBSD 64-bit kernel support

2009-05-02 Thread Chip Panarchy
Hello After 10-days, do you think it's read to be committed now? Thanks On Wed, Apr 22, 2009 at 8:52 PM, Chip Panarchy wrote: > > Hi > > Thanks > > Great, I'll be waiting till it's committed! > > WOOT > > Panarchy > > On Wed, Apr 22, 2009 at 7:10 AM, Vladimir Serbinenko > wrote: > > Hello, he

REQUEST: Tutorial on how to add a patch to GRUB2

2009-05-02 Thread Chip Panarchy
Hello Can someone please provide me with a tutorial on how to add a patch to GRUB2? Thanks in advance, Panarchy PS: The patch I want to add is the 64-bit FreeBSD one. ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listin

Re: Crash in usb_keyboard

2009-05-02 Thread Pavel Roskin
On Sat, 2009-05-02 at 13:39 +0200, Robert Millan wrote: > On Mon, Apr 27, 2009 at 11:55:10PM -0400, Pavel Roskin wrote: > > Hello! > > > > Running "terminal_input.usb_keyboard" crashed GRUB (or qemu it's running > > in). It turns out we never check if usbdev in term/usb_keyboard.c is > > not NULL

Re: [PATCH] xnu

2009-05-02 Thread Bean
Hi, xnu usage is quite complicated, perhaps you could write a wiki page on it. On Sun, May 3, 2009 at 7:20 AM, Vladimir 'phcoder' Serbinenko wrote: > commited > > On Mon, Apr 27, 2009 at 9:42 PM, Vladimir 'phcoder' Serbinenko > wrote: >> >> Update. No need to initialize efiemu manually anymore

Re: [PATCH] improve error messages in grub-setup

2009-05-02 Thread Pavel Roskin
On Sat, 2009-05-02 at 13:15 +0200, Robert Millan wrote: > This patch improves error messages in grub-setup, and adds a few > warnings when requested to install in odd layouts. > > Since there was no facility to emmit a warning that is always > visible (regardless of verbosity), but doesn't abort e

Re: [PATCH] Split 3: boot script support

2009-05-02 Thread Bean
Hi, Since the script split patch has been committed, this one should be quite trivial. I'd commit it in a few days if there is no objection. On Fri, Apr 17, 2009 at 7:22 PM, phcoder wrote: > Hello, I find this useful. It permits e.g. to have root by uuid. > >>/* Not an ELF module, skip.  */ > Th

Re: absence notice...

2009-05-02 Thread Colin D Bennett
Vesa Jääskeläinen wrote on Saturday 02 May 2009: > Hi All, > > I will be absence from the project related work for a while... So please > feel free to continue or replace the work that I may have got pending. >... > Colin: Please feel free to integrate graphical menu change without my > approval. I

Re: absence notice...

2009-05-02 Thread Bean
Hi Colin, Thanks for the effort. If you're really busy, you can just send the remaining patch to the list, I can resolve conflict and merge it in. On Sun, May 3, 2009 at 12:38 PM, Colin D Bennett wrote: > Vesa Jääskeläinen wrote on Saturday 02 May 2009: >> Hi All, >> >> I will be absence from th

Re: Code quality

2009-05-02 Thread Pavel Roskin
On Sat, 2009-05-02 at 13:41 +0200, Robert Millan wrote: > Can we start using -Werror ? If we can't do it globally, at least for > individual modules. This way we gradually prevent regressions in more > areas, and (hopefully) at some point get rid of them. We should fix the warnings first. We h

Re: [PATCH] efiemu

2009-05-02 Thread Bean
Hi, There are a few problems with the build script, I'm fixing it now. First, the build rules for efiemu32.o: efiemu32.o: efiemu/runtime/efiemu.c $(CC) -c -m32 -DELF32 -o $@ -Wall -Werror efiemu/runtime/efiemu.c -nostdlib -O2 -Iefiemu/runtime -Iinclude This would break building from a d

Re: Commands not executed in the else branch

2009-05-02 Thread Bean
Hi, Committed. On Mon, Apr 27, 2009 at 10:10 PM, Pavel Roskin wrote: > Quoting Bean : > >> Hi, >> >> It's caused by the propagation of grub_errno value. This patch should fix >> it. >> >> diff --git a/normal/execute.c b/normal/execute.c >> index 8bf6d17..aec4589 100644 >> --- a/normal/execute.c