Hi, Thanks for the review, commit it now.
On Sat, May 2, 2009 at 6:15 AM, Vladimir 'phcoder' Serbinenko <phco...@gmail.com> wrote: > Patch looks fine for me. I think you can commit it > As for lua put the origin clearly and put the original copyright notice > below grub's one. Tomorrow I'll do the same for freebsd64 patch and will > merge it >>> >>> Oh, I think it is quite compact already, have you got any suggestion >>> to reduce its size ? > > The only possibility I've seen is to move grub_parser_execute out of kernel. > However I don't think it's practicable. >> >>> >>> > Also it would be good to write the current parser in "grub>" prompt >>> > (not >>> > necessary for rescue prompt) >>> >>> Good point. >>> >>> -- >>> Bean >>> >>> >>> _______________________________________________ >>> Grub-devel mailing list >>> Grub-devel@gnu.org >>> http://lists.gnu.org/mailman/listinfo/grub-devel >> >> >> >> -- >> Regards >> Vladimir 'phcoder' Serbinenko > > > > -- > Regards > Vladimir 'phcoder' Serbinenko > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > > -- Bean _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
