idea: adjust conf file layout

Hi, Currently, the organization of conf files are not optimal. There are a lot of duplication in *.rmk files. For example, i386-efi.rmk and x86_64-efi.rmk are basically the same, and grub-emu appears in every rmk, but there is only minor difference between each one. Also, related item are scattere

Re: Commands not executed in the else branch

Quoting Bean : Hi, It's caused by the propagation of grub_errno value. This patch should fix it. diff --git a/normal/execute.c b/normal/execute.c index 8bf6d17..aec4589 100644 --- a/normal/execute.c +++ b/normal/execute.c @@ -177,6 +177,7 @@ grub_script_execute_cmdif (struct grub_script_cmd *c

Re: [PATCH] Preboot support

Commited On Sun, Apr 26, 2009 at 4:38 PM, Vladimir 'phcoder' Serbinenko < phco...@gmail.com> wrote: > Warning fixed in the patch. If nobody objects I commit it tomorrow > > > On Wed, Apr 15, 2009 at 10:40 AM, John Stanley wrote: > >> The way it looks to me is that preboot_func is the function to

Re: idea: adjust conf file layout

On Mon, Apr 27, 2009 at 9:09 AM, Bean wrote: > Hi, > > Currently, the organization of conf files are not optimal. There are a > lot of duplication in *.rmk files. For example, i386-efi.rmk and > x86_64-efi.rmk are basically the same, and grub-emu appears in every > rmk, but there is only minor di

Re: [PATCH] Use symbol database to maintain module dependence

symdb code seems to duplicate your list code. Perhaps you could reuse the file from kernel thus making maintaining easier I liked the file modsym.lst: it gives clear view of symbols. This patch brek grub-install because moddep.lst isn't copied correctly Also check that Also in some places I saw +

Re: [PATCH] Split #2: parser/reader separation

On Mon, Apr 27, 2009 at 7:51 AM, Bean wrote: > On Sun, Apr 26, 2009 at 11:50 PM, Vladimir 'phcoder' Serbinenko > wrote: > > Hello this patch breaks grub-emu. Also some files include grub/rescue.h > and > > this has to be fixed. > > Hi, > > For large patch, I normally add only the necessary chan

Re: [PATCH] ACPI spoofing

Should work on EFI now On Sat, Apr 11, 2009 at 11:06 PM, phcoder wrote: > Hello, here is the patch to spoof ACPI tables. It's useful for developement > and debugging but also for the end-users. Unfortunately many manufacturers > ship ACPI tables that work well only with win. Fortunately now linu

Re: [PATCH] Use symbol database to maintain module dependence

On Tue, Apr 28, 2009 at 2:13 AM, Vladimir 'phcoder' Serbinenko wrote: > symdb code seems to duplicate your list code. Perhaps you could reuse the > file from kernel thus making maintaining easier Hi, I'm planning to use kern/list.c at first, but there is some issue. list.c uses grub_strcmp, whic

Re: Revision 2136 breaks two-disk configuarion

On Sun, 2009-04-26 at 22:57 -0700, David Miller wrote: > grub_disk_open() isn't used, but a grub_device_open() does occur > during the iterator that has us find the FS_UUID device. This > happens search_fs_uuid(). > > If we don't do this, we leave a device reference open and dangling. Then we s

[PATCH] Re: Revision 2136 breaks two-disk configuarion

On Mon, 2009-04-27 at 18:26 -0400, Pavel Roskin wrote: > It's entirely possible that the problem is elsewhere. But I have no > experience debugging memory problems in GRUB, so it will take time > before I find out. Done! disk->partition should not be copied by reference. This patch fixes the b

Re: [PATCH] Re: Revision 2136 breaks two-disk configuarion

From: Pavel Roskin Date: Mon, 27 Apr 2009 21:37:52 -0400 > On Mon, 2009-04-27 at 18:26 -0400, Pavel Roskin wrote: > >> It's entirely possible that the problem is elsewhere. But I have no >> experience debugging memory problems in GRUB, so it will take time >> before I find out. > > Done! disk

Re: [PATCH] Re: Revision 2136 breaks two-disk configuarion

On Mon, 2009-04-27 at 18:45 -0700, David Miller wrote: > Thanks for fixing this Pavel. I suspect this bug is why the close was > left as a NOP function all of this time. Maybe. > Please commit this as it seems you haven't already :-) I was about to commit it when I realized that the same could

Crash in usb_keyboard

Hello! Running "terminal_input.usb_keyboard" crashed GRUB (or qemu it's running in). It turns out we never check if usbdev in term/usb_keyboard.c is not NULL. It is NULL if no USB host controllers have been detected. I'm not sure if we even want to call grub_term_register_input() if no USB keyb

Re: grub-mkconfig for combined serial and console

On Fri, 2009-04-24 at 12:09 +1200, Daniel Reurich wrote: > Hi > > I'd like to be able to define terminal --timeout=5 serial console in a > way that grub-mkconfig will automatically set that when updating the > grub.cfg file. > > Is there an easy way to do this (and disable the use of gfxterm). S