On Mon, Apr 27, 2009 at 7:51 AM, Bean <bean12...@gmail.com> wrote: > On Sun, Apr 26, 2009 at 11:50 PM, Vladimir 'phcoder' Serbinenko > <phco...@gmail.com> wrote: > > Hello this patch breaks grub-emu. Also some files include grub/rescue.h > and > > this has to be fixed. > > Hi, > > For large patch, I normally add only the necessary changes to make it > compile in i386-pc. As commits are quite frequent, this would minimize > the effort to sync with svn head. I'd fix those small issue before > final commitment. > Ok. However a Changlog would simplify the review because then it would be easy to see which parts are newly written and which is just code moving around
> > > Also there is a bug is that in case of syntax error reader continues to > ask > > for more lines. E.g > > grub> if > >>; > > syntax error > >> > > Then it's impossible to exit from this "bug mode". It's not your fault > but > > since you touch this code could you fix this? > > I believe a proper way to solve this is to add an eol character, for > example ctrl-D. Then we have a way to break from console input. But > this fix is not trivial, perhaps it should be in a separate patch. > Ok > > > This patch increases the size of kernel by 504 bytes and the size of > > core.img by 224 bytes. Is there a way to do the same thing in a more > compact > > way? > > Oh, I think it is quite compact already, have you got any suggestion > to reduce its size ? > I'll have a look at it again today or tomorrow > > > Also it would be good to write the current parser in "grub>" prompt (not > > necessary for rescue prompt) > > Good point. > > -- > Bean > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > -- Regards Vladimir 'phcoder' Serbinenko
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
