Re: [RFC] change grub_print_error to use stderr for the utils

2008-08-14 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Am Mittwoch, den 13.08.2008, 20:41 +0200 schrieb Marco Gerards: >> So what do you propose? :-) You lost me midway since you change >> subjects a bit often ;( > > Oh sorry for that this time I only changed [PATCH] to [RFC] > but yeah this whole topic isn

Re: [PATCH] kern/err.c + disk/raid.c error handling fixes

2008-08-14 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Am Donnerstag, den 14.08.2008, 00:39 +0200 schrieb Felix Zielcke: >> >> This time dear Marco I didn't bother to read through the changelog, it >> might be still not perfect and I'm even tired now. > > I should have better gone to bed instead of making q

Re: [RFC] change grub_print_error to use stderr for the utils

2008-08-14 Thread Felix Zielcke
Am Donnerstag, den 14.08.2008, 09:07 +0200 schrieb Marco Gerards: Honourly I want that whole topic discussed with everyone who is subscribed here and not just with you Marco, but it's very kind that at least you reply :) > > Well, ok. So thus we are indeed fixing a problem in Lenny inside > GRU

Re: [RFC] change grub_print_error to use stderr for the utils

2008-08-14 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Am Donnerstag, den 14.08.2008, 09:07 +0200 schrieb Marco Gerards: > > Honourly I want that whole topic discussed with everyone who is > subscribed here and not just with you Marco, but it's very kind that at > least you reply :) Hey, at least you get a

Re: [RFC] change grub_print_error to use stderr for the utils

2008-08-14 Thread Felix Zielcke
Am Donnerstag, den 14.08.2008, 10:03 +0200 schrieb Marco Gerards: > Felix Zielcke <[EMAIL PROTECTED]> writes: > > > Am Donnerstag, den 14.08.2008, 09:07 +0200 schrieb Marco Gerards: > > > > Honourly I want that whole topic discussed with everyone who is > > subscribed here and not just with you Ma

Re: [PATCH] kern/err.c + disk/raid.c error handling fixes

2008-08-14 Thread Felix Zielcke
Am Donnerstag, den 14.08.2008, 09:13 +0200 schrieb Marco Gerards: > So this patch isn't really required, but you want it for Lenny? [EMAIL PROTECTED] That's the one Robert and me thought could be something for lenny. I have forgotten to merge the disk/raid.c changes which Robert wanted to have i

Re: [RFC] Platform information services

2008-08-14 Thread Javier Martín
2008/8/14 Vesa Jääskeläinen <[EMAIL PROTECTED]>: > Javier Martín wrote: >> Hi there everybody, >> >> I'm opening the RFC because I want to add some kind of infrastructure to >> retrieve the address of system/platform structures. I will explain >> myself: my use case is in i386-pc and for the drivem

Re: [RFC] Platform information services

2008-08-14 Thread Vesa Jääskeläinen
Javier Martín wrote: > Hi there everybody, > > I'm opening the RFC because I want to add some kind of infrastructure to > retrieve the address of system/platform structures. I will explain > myself: my use case is in i386-pc and for the drivemap module, in which > a function installs a TSR int13h

[Fwd: Re: Bug#495049: grub-pc: does not boot because module "normal" is not loaded]

2008-08-14 Thread Felix Zielcke
Hello, anyone has an idea why grub itself fails to switch from rescue to normal mode, but just `insmod normal; normal' does work? For me this doestn't make any sense at all. If you want to see the initial report: http://bugs.debian.org/495049 Weitergeleitete Nachricht > Von:

Re: [PATCH] Drivemap module

2008-08-14 Thread Marco Gerards
Javier Martín <[EMAIL PROTECTED]> writes: > Ok, making a mixup reply... Please don't. Unless you do not like it that your mails go unread. >> > Having a small kernel is highly desireable for most users. If the kernel >> > is >> > too big, it won't fit and then either we have to use blocklists

Re: [PATCH] Grub2 cannot find LVM volume groups with a dash (-) in the name

2008-08-14 Thread Felix Zielcke
Am Montag, den 11.08.2008, 18:18 +0200 schrieb Felix Zielcke: > > Please comment this, please give me hints how to make it better. > I don't like the code myself but it seems like we should handle this > double dash problem :( > Now that a bit time has passed, I think it isn't that ugly. But I s

Re: [RFC] Platform information services

2008-08-14 Thread Vesa Jääskeläinen
Javier Martín wrote: > 2008/8/14 Vesa Jääskeläinen <[EMAIL PROTECTED]>: >> Javier Martín wrote: >>> Hi there everybody, >>> >>> I'm opening the RFC because I want to add some kind of infrastructure to >>> retrieve the address of system/platform structures. I will explain >>> myself: my use case is

Re: [RFC] change grub_print_error to use stderr for the utils

2008-08-14 Thread Robert Millan
On Thu, Aug 14, 2008 at 10:03:27AM +0200, Marco Gerards wrote: > >> Well, ok. So thus we are indeed fixing a problem in Lenny inside > >> GRUB? On IRC someone said this was *not* the case. I am very > >> confused... > > > > Yeah sorry it is very confusing. > > I want (wanted ?) to have that prob

Re: [RFC] Platform information services

2008-08-14 Thread Robert Millan
On Thu, Aug 14, 2008 at 06:38:41PM +0200, Javier Martín wrote: > Yes, but this is a "kernel" design decision that is specified nowhere > to the modules writers. Thus, this could change tomorrow and the > scheme would break down. GRUB is being developed as a whole, which includes kernel and modules

Re: [PATCH] Grub2 cannot find LVM volume groups with a dash (-) in the name

2008-08-14 Thread Robert Millan
On Thu, Aug 14, 2008 at 07:34:05PM +0200, Felix Zielcke wrote: > 2008-08-14 Felix Zielcke <[EMAIL PROTECTED]> > > * util/getroot.c: Include . > (grub_util_get_grub_dev): Rewritten. Please explain the actual changes (or what they're for). >switch (grub_util_get_dev_abstracti

Re: [PATCH] kern/err.c + disk/raid.c error handling fixes

2008-08-14 Thread Robert Millan
On Thu, Aug 14, 2008 at 01:02:30PM +0200, Felix Zielcke wrote: > +int > +grub_err_printf (const char *fmt, ...) > +{ > + va_list ap; > + int ret; > + > + va_start (ap, fmt); > + ret = vfprintf (stderr, fmt, ap); > + va_end (ap); > + > + return ret; > +} > void * > xmalloc (size_t size) P

Re: [PATCH] kern/err.c + disk/raid.c error handling fixes

2008-08-14 Thread Vesa Jääskeläinen
Robert Millan wrote: > On Thu, Aug 14, 2008 at 01:02:30PM +0200, Felix Zielcke wrote: >> +int >> +grub_err_printf (const char *fmt, ...) >> +{ >> + va_list ap; >> + int ret; >> + >> + va_start (ap, fmt); >> + ret = vfprintf (stderr, fmt, ap); >> + va_end (ap); >> + >> + return ret; >> +} >>

Re: [PATCH] kern/err.c + disk/raid.c error handling fixes

2008-08-14 Thread Marco Gerards
Hi Felix, Felix Zielcke <[EMAIL PROTECTED]> writes: [...] > 2008-08-14 Felix Zielcke <[EMAIL PROTECTED]> > > * include/grub.err.h (grub_err_printf): New function prototype. grub.err.h -> grub/err.h > * util/misc.c (grub_err_printf): New function. > * kern/misc.c [! GR

Re: [PATCH] kern/err.c + disk/raid.c error handling fixes

2008-08-14 Thread Felix Zielcke
Am Donnerstag, den 14.08.2008, 20:27 +0200 schrieb Marco Gerards: > This patch looks clean enough for me :-). If you can correct the > following (and previous ;)) comments, it is ready to be committed. > Commited. Hurray. ___ Grub-devel mailing lis

Re: [RFC] change grub_print_error to use stderr for the utils

2008-08-14 Thread Felix Zielcke
Am Donnerstag, den 14.08.2008, 19:54 +0200 schrieb Robert Millan: > Would all of you please stop talking about debian and lenny? This is about > a bug in GRUB. :-/ Yep, I think so now too that this should be first fixed upstream and then we can talk about lenny. > Anyway, please let's not wast

Re: [PATCH] grub-mkelfimage

2008-08-14 Thread Robert Millan
Committed. On Sun, Aug 03, 2008 at 11:04:35PM +0200, Robert Millan wrote: > > The elf version of grub-mkimage is multiplatform, so it makes no sense to > keep it as arch-specific in the build system IMHO. > > This patch renames it to grub-mkelfimage, and arranges the build system & > headers so

[PATCH] handle/report errors set by grub_device_iterate()

2008-08-14 Thread Robert Millan
Hi, After Felix's grub_print_error() fix, it is now possible to handle and report errors properly in raid. This patch enables that. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your free

Re: [PATCH] Grub2 cannot find LVM volume groups with a dash (-) in the name

2008-08-14 Thread Felix Zielcke
Am Donnerstag, den 14.08.2008, 20:03 +0200 schrieb Robert Millan: > > Please explain the actual changes (or what they're for). As I wrote that, I just saw before that Marco did just Rewritten. in a commit, but with searching for Rewritten in the ChangeLog reveals much more verbose entrys So: 200

Re: [PATCH] Grub2 cannot find LVM volume groups with a dash (-) in the name

2008-08-14 Thread Robert Millan
On Thu, Aug 14, 2008 at 09:32:04PM +0200, Felix Zielcke wrote: > > Try to ommit big indentation changes from the patch. If you change > > something > > that requires a big chunk of code to be reindented, I think it's better if > > you > > leave that out for readability (and mention so if you lik

Re: [PATCH] Grub2 cannot find LVM volume groups with a dash (-) in the name

2008-08-14 Thread Felix Zielcke
Am Donnerstag, den 14.08.2008, 22:38 +0200 schrieb Robert Millan: > Okay, but please send the patch without indentation first, so your changes can > be reviewed. svn diff --diff-cmd diff -x -upw That way it works, the attached getroot_w.diff is made with it. But I think it doestn't look that go

Re: [RFC] Platform information services

2008-08-14 Thread Javier Martín
El jue, 14-08-2008 a las 20:00 +0200, Robert Millan escribió: > On Thu, Aug 14, 2008 at 06:38:41PM +0200, Javier Martín wrote: > > Yes, but this is a "kernel" design decision that is specified nowhere > > to the modules writers. Thus, this could change tomorrow and the > > scheme would break down.

Re: [RFC] Platform information services

2008-08-14 Thread Javier Martín
El jue, 14-08-2008 a las 20:41 +0300, Vesa Jääskeläinen escribió: > Javier Martín wrote: > > 2008/8/14 Vesa Jääskeläinen <[EMAIL PROTECTED]>: > >> Javier Martín wrote: > >>> Hi there everybody, > >>> > >>> I'm opening the RFC because I want to add some kind of infrastructure to > >>> retrieve the a

Re: [PATCH] Drivemap module

2008-08-14 Thread Javier Martín
El jue, 14-08-2008 a las 19:15 +0200, Marco Gerards escribió: > Javier Martín <[EMAIL PROTECTED]> writes: > > > Ok, making a mixup reply... > > Please don't. Unless you do not like it that your mails go unread. > > >> > Having a small kernel is highly desireable for most users. If the > >> >

[PATCH] try2, Enable grub_cpu_idle for i386/pc to halt the CPU

2008-08-14 Thread David Fries
Compared to the last patch I've removed util/user-stub.c in favor of testing GRUB_UTIL in the header files, do while with while and a fix, ChangeLog, and compiled it with both coreboot and elf targets in addition to i386/pc. Enable grub_cpu_idle for i386/pc to halt the CPU. Modified the menu to