On Thu, Aug 14, 2008 at 09:32:04PM +0200, Felix Zielcke wrote: > > Try to ommit big indentation changes from the patch. If you change > > something > > that requires a big chunk of code to be reindented, I think it's better if > > you > > leave that out for readability (and mention so if you like). > > Unfortunately I couldn't get the -w option working to ignore white space > changes > svn diff --diff-cmd diff -x -up -x -w doestn't produce an unified diff, > < and > are used instead of - and + > with -x -w -x up the -w is ignored :( > > So I just need to remember this now that I either change the indention, > before commiting or I directly make 2 patches. > Luckly I can commit this now myself so I really don't need to include > this in the patches I send :)
Okay, but please send the patch without indentation first, so your changes can be reviewed. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all." _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
