Re: [PATCH] Misc patches for grub2

2008-07-27 Thread Pavel Roskin
On Sun, 2008-07-27 at 14:00 +0800, Bean wrote: > Hi, > > On Sun, Jul 27, 2008 at 12:55 PM, Pavel Roskin <[EMAIL PROTECTED]> wrote: > > Our main repository is in Subversion, so whoever applies the patch > > should use "svn move" to keep the contiguous file history. Unlike git, > > which trusts the

Re: [PATCH] Misc patches for grub2

2008-07-27 Thread Bean
Hi, On Sun, Jul 27, 2008 at 3:05 PM, Pavel Roskin <[EMAIL PROTECTED]> wrote: >> > IMHO that even worse. Using a trademarked name like "linux" to run the >> > trademarked software could be justified. But using a trademarked name >> > to replace or emulate the original software is asking for a big

Re: Remove conf/*.mk from svn

2008-07-27 Thread Pavel Roskin
On Fri, 2008-07-25 at 20:41 +0200, Christian Franke wrote: > I agree, the files generated by ./autogen.sh should be included in > tarball, but not in the repo. > Additional prerequisites (autoconf, ruby) for builds from svn are IMO OK. I agree. At least we should put a message into *.mk files t

Re: [PATCH] Misc patches for grub2

2008-07-27 Thread Pavel Roskin
On Sun, 2008-07-27 at 15:14 +0800, Bean wrote: > > Fine. > > I'm sorry, do you mean it's fine to use bootcamp, or keep the name > appleloader ? Fine to use "appleloader". Actually, I've never had a chance to play with an Intel Mac, so I don't know the details. > >> BTW, any comment about the o

Re: [PATCH] Misc patches for grub2

2008-07-27 Thread Bean
On Sun, Jul 27, 2008 at 3:20 PM, Pavel Roskin <[EMAIL PROTECTED]> wrote: >> >> BTW, any comment about the other changes ? >> > >> > Why do we need "crc"? If there are chances that it will be used for >> > security, we should be using SHA-1. >> >> crc is useful in many place. For example, png, jffs

Re: [PATCH] Misc patches for grub2

2008-07-27 Thread Pavel Roskin
On Sun, 2008-07-27 at 15:30 +0800, Bean wrote: > On Sun, Jul 27, 2008 at 3:20 PM, Pavel Roskin <[EMAIL PROTECTED]> wrote: > >> >> BTW, any comment about the other changes ? > >> > > >> > Why do we need "crc"? If there are chances that it will be used for > >> > security, we should be using SHA-1.

Re: "Out of Partition" error on XFS still occuring

2008-07-27 Thread Pavel Roskin
On Sat, 2008-07-26 at 20:56 -0500, Dan Callahan wrote: > Hi, I seem to be able to recreate the xfs "out of partition" error > using Debian's most recent grub-pc release, 1.96+20080724-2. > > This bug is being tracked at > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=436943 , and was > first re

Re: "Out of Partition" error on XFS still occuring

2008-07-27 Thread Bean
On Sun, Jul 27, 2008 at 3:47 PM, Pavel Roskin <[EMAIL PROTECTED]> wrote: > On Sat, 2008-07-26 at 20:56 -0500, Dan Callahan wrote: >> Hi, I seem to be able to recreate the xfs "out of partition" error >> using Debian's most recent grub-pc release, 1.96+20080724-2. >> >> This bug is being tracked at

Re: "Out of Partition" error on XFS still occuring

2008-07-27 Thread Bean
On Sun, Jul 27, 2008 at 6:06 PM, Bean <[EMAIL PROTECTED]> wrote: > Hi, > > This problem is caused by the previous patch, it expands the size of > grub_xfs_dir_header: > > struct grub_xfs_dir_header > { > grub_uint8_t count; > grub_uint8_t i8count; > union > { >grub_uint32_t i4; >grub_ui

Re: [PATCH] Ignore case when opening files in FAT

2008-07-27 Thread Robert Millan
On Sat, Jul 26, 2008 at 12:23:24PM +0800, Bean wrote: > On Sat, Jul 26, 2008 at 4:51 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > > On Fri, Jul 25, 2008 at 03:28:45PM +0800, Bean wrote: > >> Hi, > >> > >> As FAT is basically a case insensitive file system, we should ignore > >> case when opening

Re: [PATCH] update-grub for Cygwin

2008-07-27 Thread Robert Millan
On Sun, Jul 27, 2008 at 02:09:02AM -0400, Pavel Roskin wrote: > On Sat, 2008-07-26 at 14:53 +0200, Christian Franke wrote: > > Robert Millan wrote: > > > On Thu, Jul 24, 2008 at 10:19:17PM +0200, Christian Franke wrote: > > > > > >> + case "`uname 2>/dev/null`" in > > >> +CYGWIN*) > > >>

Re: [PATCH] use UUIDs for cross-disk installs (Re: Issue with boot != root and chainloading)

2008-07-27 Thread Robert Millan
On Fri, Jul 25, 2008 at 09:08:52PM -0400, Pavel Roskin wrote: > > As for single drive installs, we could also encode the prefix in the > text form, like "(hd0,5)/boot/grub" and obsolete the numerical partition > data. That would make make_install_device() unnecessary. On single drive installs we

Re: [PATCH] make assumed terminal width on cmd help dynamic

2008-07-27 Thread Robert Millan
Done. On Sat, Jul 26, 2008 at 11:14:30AM +0200, Marco Gerards wrote: > Marco Gerards <[EMAIL PROTECTED]> writes: > > >> Felix Zielcke <[EMAIL PROTECTED]> > >> > >> > >>* commands/help.c: Include . > >>(TERM_WIDTH): Removed. Updated all uses. > > > > I would say "Updated all users." or

Re: [PATCH] Misc patches for grub2

2008-07-27 Thread Bean
On Sun, Jul 27, 2008 at 3:33 PM, Pavel Roskin <[EMAIL PROTECTED]> wrote: > On Sun, 2008-07-27 at 15:30 +0800, Bean wrote: >> On Sun, Jul 27, 2008 at 3:20 PM, Pavel Roskin <[EMAIL PROTECTED]> wrote: >> >> >> BTW, any comment about the other changes ? >> >> > >> >> > Why do we need "crc"? If there a

Re: [PATCH] Ignore case when opening files in FAT

2008-07-27 Thread Bean
On Sun, Jul 27, 2008 at 8:38 PM, Robert Millan <[EMAIL PROTECTED]> wrote: > On Sat, Jul 26, 2008 at 12:23:24PM +0800, Bean wrote: >> On Sat, Jul 26, 2008 at 4:51 AM, Robert Millan <[EMAIL PROTECTED]> wrote: >> > On Fri, Jul 25, 2008 at 03:28:45PM +0800, Bean wrote: >> >> Hi, >> >> >> >> As FAT is b

Re: [PATCH] make assumed terminal width on cmd help dynamic

2008-07-27 Thread Felix Zielcke
Am Sonntag, den 27.07.2008, 15:03 +0200 schrieb Robert Millan: > Done. > Ok, the patch I sent you attached offlist, because the one I posted inline here onlist didn't work for you, had a missing #include "grub/term.h" Attached is a patch for it. I don't know if you want to leave changelog untouc

Re: [PATCH] use UUIDs for cross-disk installs (Re: Issue with boot != root and chainloading)

2008-07-27 Thread Pavel Roskin
On Sun, 2008-07-27 at 14:19 +0200, Robert Millan wrote: > > We could also use UUID for single-drive installs and fallback to the > > partition prefix only if UUID is unsupported or the user requests not to > > use UUID. Then it won't be a big deal if we hardcode the drive. > > Based on the rest

[PATCH] buffered file read

2008-07-27 Thread Bean
Hi, This patch add a new module bufio, which reads block of data at a time, and return the required range to the upper level. This is extremely useful in modules like png, where data are normally read one byte at a time. To use buffered io service, just include header file , and replace grub_file

UUID boot on ieee1275 (Re: [PATCH] use UUIDs for cross-disk installs (Re: Issue with boot != root and chainloading))

2008-07-27 Thread Robert Millan
On Sun, Jul 27, 2008 at 08:37:37PM +0200, Robert Millan wrote: > I'm not satisfied with the current user interface of that script, but I > couldn't think of any better way to do it back then. If you can improve > it that'd be much welcome. > > Btw, I'm currently working on adding --prefix / uuid

Re: [PATCH] use UUIDs for cross-disk installs (Re: Issue with boot != root and chainloading)

2008-07-27 Thread Robert Millan
On Sun, Jul 27, 2008 at 12:29:43PM -0400, Pavel Roskin wrote: > On Sun, 2008-07-27 at 14:19 +0200, Robert Millan wrote: > > > > We could also use UUID for single-drive installs and fallback to the > > > partition prefix only if UUID is unsupported or the user requests not to > > > use UUID. Then

Re: [PATCH] use UUIDs for cross-disk installs (Re: Issue with boot != root and chainloading)

2008-07-27 Thread Robert Millan
Aside from the discussion about removing / refurbishing make_install_device(), is everybody ok with what this patch does? If I don't hear any objections I'll commit it soon. On Sat, Jul 26, 2008 at 12:10:50AM +0200, Robert Millan wrote: > 2008-07-26 Robert Millan <[EMAIL PROTECTED]> > >

Re: grub-probe fails to find PC partition due to Apple disklabel

2008-07-27 Thread Felix Zielcke
Am Freitag, den 25.07.2008, 19:09 -0400 schrieb Chris Knadle: >Just tested -- nope, grub-probe still can't find the device. > So this: > >kern/partition.c:106: Detecting apple_partition_map... >kern/disk.c:368: Reading `hd0'... >partmap/apple.c:129: bad magic (found 0xfc31; want

Re: [PATCH] buffered file read

2008-07-27 Thread Colin D Bennett
On Mon, 28 Jul 2008 01:52:40 +0800 Bean <[EMAIL PROTECTED]> wrote: > Hi, > > This patch add a new module bufio, which reads block of data at a > time, and return the required range to the upper level. This is > extremely useful in modules like png, where data are normally read one > byte at a tim

Re: [PATCH] UUID boot on ieee1275 (Re: [PATCH] use UUIDs for cross-disk installs (Re: Issue with boot != root and chainloading))

2008-07-27 Thread Robert Millan
On Sun, Jul 27, 2008 at 09:28:58PM +0200, Robert Millan wrote: > On Sun, Jul 27, 2008 at 08:37:37PM +0200, Robert Millan wrote: > > I'm not satisfied with the current user interface of that script, but I > > couldn't think of any better way to do it back then. If you can improve > > it that'd be m

Re: [PATCH] buffered file read

2008-07-27 Thread Bean
On Mon, Jul 28, 2008 at 3:51 AM, Colin D Bennett <[EMAIL PROTECTED]> wrote: > On Mon, 28 Jul 2008 01:52:40 +0800 > Bean <[EMAIL PROTECTED]> wrote: > >> Hi, >> >> This patch add a new module bufio, which reads block of data at a >> time, and return the required range to the upper level. This is >> e

Re: grub-probe fails to find PC partition due to Apple disklabel

2008-07-27 Thread Felix Zielcke
Am Sonntag, den 27.07.2008, 21:53 +0200 schrieb Felix Zielcke: > Wipe a disk, then make an apple partition, and then make msdos > partitions and make a filesystem on it. > Just like it probable was as you reported the bug initially. > Urm I forgot: probable better if you make also an apple files

Re: [PATCH] UUID boot on ieee1275 (Re: [PATCH] use UUIDs for cross-disk installs (Re: Issue with boot != root and chainloading))

2008-07-27 Thread Robert Millan
On Sun, Jul 27, 2008 at 10:13:19PM +0200, Robert Millan wrote: > > So I'm submitting a patch that implements --prefix, without having > grub-install > use it. This is useful already (for manual installs), and I'd like to use > that > --prefix option for Coreboot later too. Here's a combined pa

Re: [PATCH] buffered file read

2008-07-27 Thread Robert Millan
On Mon, Jul 28, 2008 at 01:52:40AM +0800, Bean wrote: > > * video/png.c (grub_video_reader_png): Use grub_buffile_open to open > file. > > * video/jpeg.c (grub_video_reader_jpeg): Likewise. > > * video/tga.c (grub_video_reader_tga): Likewise. Maybe it's a good idea to us

Re: loader modules jumping back to kernel

2008-07-27 Thread Robert Millan
On Sun, Jul 20, 2008 at 11:09:02AM +0200, Yoshinori K. Okuji wrote: > > IIRC this causes trouble when the loadee chose an address that precisely > > overwrites the loader, which is garanteed to happen when GRUB is loading > > itself, AFAICT. > > Sure. My recommendation is, in case where you might

Re: [PATCH] grub-probe -t prefix, fix update-grub_lib for Cygwin

2008-07-27 Thread Christian Franke
Robert Millan wrote: On Sun, Jul 20, 2008 at 02:40:14PM +0200, Christian Franke wrote: The shell function make_system_path_relative_to_its_root() does not work on Cygwin due to path mapping (e.g. /boot/grub/ is actually /cygwin/boot/grub). This patch adds '-t prefix' to grub-probe. It prin

Re: Remove conf/*.mk from svn

2008-07-27 Thread Christian Franke
Pavel Roskin wrote: On Fri, 2008-07-25 at 20:41 +0200, Christian Franke wrote: I agree, the files generated by ./autogen.sh should be included in tarball, but not in the repo. Additional prerequisites (autoconf, ruby) for builds from svn are IMO OK. I agree. At least we should put a

Re: [PATCH] buffered file read

2008-07-27 Thread Bean
Hi, I have added a buffer length parameter to grub_buffile_open: grub_file_t grub_buffile_open (const char *name, int size); size < 0: Load the whole file. size = 0: Use default buffer size (8192 bytes) size > 0: Custom buffer size = size The upper limit is 1m, if size > 1m, we set it to 1m. 2