Re: Does grub2 solve this problem I am having with grub1? RE: usbsticks.

2008-02-02 Thread Yoshinori K. Okuji
On Friday 01 February 2008 19:44, Paul Elliott wrote: > > Would not the boot device be hd0? > > No, usually the first hard disk is hd0, the second hard disk > is hd1, and the usb sticks come after that. At least that is > how it works under my computer. Usually it is because the number > of hard di

Re: read_config_file() is missleading

2008-02-02 Thread Yoshinori K. Okuji
On Friday 01 February 2008 20:58, Robert Millan wrote: > The following function name: > > normal/main.c:read_config_file (const char *config, int nested) > > is missleading. It does actually execute the config file, not just > read it. Does it seem fine to rename it? > > How about `process_conf

Re: read_config_file() is missleading

2008-02-02 Thread Yoshinori K. Okuji
On Saturday 02 February 2008 13:14, Yoshinori K. Okuji wrote: > On Friday 01 February 2008 20:58, Robert Millan wrote: > > The following function name: > > > > normal/main.c:read_config_file (const char *config, int nested) > > > > is missleading. It does actually execute the config file, not ju

Re: [PATCH] don't display menu when there's nothing in it

2008-02-02 Thread Yoshinori K. Okuji
On Friday 01 February 2008 21:02, Robert Millan wrote: > normal.mod seems to insist in displaying a menu even if grub.cfg didn't > define any menu entries. This seems to be due to a bogus check (for > menu instead of menu->size). It is not completely bogus, since MENU can be NULL. Probably what y

Re: grub_cmdline_get() i18n problem

2008-02-02 Thread Yoshinori K. Okuji
On Friday 01 February 2008 22:19, Oleg Strikov wrote: > Good day! > > Let's look at grub_cmdline_get() func code: > > /* normal/cmdline.c - line 300 */ > plen = grub_utf8_strlen (prompt); > lpos = llen = 0; > buf[0] = '\0'; > > if ((grub_getxy () >> 8) != 0) > grub_putchar ('\n'); > >

Re: Compiling grub2 on OpenBSD

2008-02-02 Thread Yoshinori K. Okuji
On Friday 01 February 2008 22:41, Robert Millan wrote: > On Fri, Feb 01, 2008 at 12:49:11PM -0800, walt wrote: > > I got grub2 compiled on NetBSD, so now on to OpenBSD: > > > > In file included from ../util/i386/pc/grub-mkimage.c:29: > > ../include/grub/misc.h:43: warning: conflicting types for bui

Re: [PATCH] read command

2008-02-02 Thread Yoshinori K. Okuji
On Friday 01 February 2008 23:48, Robert Millan wrote: > On Fri, Feb 01, 2008 at 11:45:50PM +0100, Robert Millan wrote: > > +static void * > > +grub_xrealloc (void *ptr, grub_size_t size) > > +{ > > + void *value = grub_realloc (ptr, size); > > + if (value == 0) > > +grub_fatal ("Virtual memo

[PATCH] support joliet extension in iso9660 filesystem

2008-02-02 Thread Bean
Hi, This patch add joliet extension support for iso9660. 2008-02-02 Bean <[EMAIL PROTECTED]> * fs/iso9660.c (GRUB_ISO9660_VOLDESC_BOOT): New macro. (GRUB_ISO9660_VOLDESC_PRIMARY): Likewise. (GRUB_ISO9660_VOLDESC_SUPP): Likewise. (GRUB_ISO9660_VOLDESC_PART): Like

Re: booting kernel of NetBSD (Re: UFS (FFS) support seems broken in grub2)

2008-02-02 Thread Bean
Committed. -- Bean ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] btree support in xfs driver

2008-02-02 Thread Bean
Committed. -- Bean ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] eltorito cdrom boot

2008-02-02 Thread Bean
On Jan 31, 2008 8:43 PM, Bean <[EMAIL PROTECTED]> wrote: > 2008-01-31 Bean <[EMAIL PROTECTED]> > > * conf/i386-pc.rmk (pkglib_IMAGES): Add cdboot.img. > (cdboot_img_SOURCES): New variable. > (cdboot_img_ASFLAGS): New variable. > (cdboot_img_LDFLAGS): New variable.

Move os dependent code to a separate file ?

2008-02-02 Thread Bean
Hi, i can see that there are linux specific code in util/biosdisk.c, perhaps we should move them to a separate file such as util/osdep.c ? -- Bean ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: hello command

2008-02-02 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > How useful is the `hello' command? Is it more useful than `echo' ? How > about getting rid of it? It's a good and simple example of how to write a module. So I think it serves its purpose. `echo' has the purpose of being useful to end users. -- Mar

Re: Does grub2 solve this problem I am having with grub1? RE: usbsticks.

2008-02-02 Thread Paul Elliott
On Sat, Feb 02, 2008 at 01:11:18PM +0100, Yoshinori K. Okuji wrote: > > It is already there. GRUB 2 already supports setting a root based on a > filesystem label or a path. > What is the syntax? How do I set it up? Are there example grub2 setups? -- Paul Elliott 1(512)

Re: PCI support

2008-02-02 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Thu, Jan 31, 2008 at 09:51:38AM +0100, Marco Gerards wrote: >> > >> > grub_uint32_t >> > grub_inl (grub_uint32_t *addr) >> > { >> > return *addr; >> > } >> >> Nothing, except the missing volatile I guess. This just isn't an IO >> port. So you can

Re: [PATCH] eltorito cdrom boot

2008-02-02 Thread Robert Millan
On Sat, Feb 02, 2008 at 10:19:55PM +0800, Bean wrote: > > any objection for this patch ? i would like to commit it soon. Looks fine to me. Just a minor comment: > +#define GRUB_BIOSDISK_MACHINE_CDROM_START 0xe0 > +#define GRUB_BIOSDISK_MACHINE_CDROM_END 0xf0 could you make this tab-indented?

Re: hello command

2008-02-02 Thread Robert Millan
On Sat, Feb 02, 2008 at 03:35:18PM +0100, Marco Gerards wrote: > Robert Millan <[EMAIL PROTECTED]> writes: > > > How useful is the `hello' command? Is it more useful than `echo' ? How > > about getting rid of it? > > It's a good and simple example of how to write a module. So I think > it serv

Re: read_config_file() is missleading

2008-02-02 Thread Robert Millan
On Sat, Feb 02, 2008 at 01:20:04PM +0100, Yoshinori K. Okuji wrote: > > I was mistaken. It really depends on the meaning of "execute". For me, > executing a menu means analyzing the menu structure, displaying it, > controlling user inputs, and so on. read_menu_config does not execute a menu > i

Re: Move os dependent code to a separate file ?

2008-02-02 Thread Robert Millan
On Sat, Feb 02, 2008 at 10:29:20PM +0800, Bean wrote: > Hi, > > i can see that there are linux specific code in util/biosdisk.c, > perhaps we should move them to a separate file such as util/osdep.c ? In general I don't like very much to split unportable code in separate files because it's easy t

Re: [PATCH] don't display menu when there's nothing in it

2008-02-02 Thread Robert Millan
On Sat, Feb 02, 2008 at 01:20:49PM +0100, Yoshinori K. Okuji wrote: > On Friday 01 February 2008 21:02, Robert Millan wrote: > > normal.mod seems to insist in displaying a menu even if grub.cfg didn't > > define any menu entries. This seems to be due to a bogus check (for > > menu instead of menu-

Re: [PATCH] read command

2008-02-02 Thread Robert Millan
On Sat, Feb 02, 2008 at 01:38:28PM +0100, Yoshinori K. Okuji wrote: > > > > Does it make sense to move any of these two to kernel? Or to normal.mod ? > > Or maybe just to un-static-ize them and leave them here? > > What would be other use cases? No idea. I suggest we just leave grub_getline he

Re: [PATCH] eltorito cdrom boot

2008-02-02 Thread Bean
On Feb 3, 2008 12:33 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > On Sat, Feb 02, 2008 at 10:19:55PM +0800, Bean wrote: > > > > any objection for this patch ? i would like to commit it soon. > > Looks fine to me. Just a minor comment: > > > +#define GRUB_BIOSDISK_MACHINE_CDROM_START 0xe0 > > +#d

Re: [PATCH] eltorito cdrom boot

2008-02-02 Thread Robert Millan
On Sun, Feb 03, 2008 at 01:16:50AM +0800, Bean wrote: > On Feb 3, 2008 12:33 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > > On Sat, Feb 02, 2008 at 10:19:55PM +0800, Bean wrote: > > > > > > any objection for this patch ? i would like to commit it soon. > > > > Looks fine to me. Just a minor comm

Re: hello command

2008-02-02 Thread Pavel Roskin
Quoting Robert Millan <[EMAIL PROTECTED]>: It's a good and simple example of how to write a module. So I think it serves its purpose. `echo' has the purpose of being useful to end users. If it's just an example, why not exclude it from the default builds? It clutters the command list and do

PCI+ATA

2008-02-02 Thread Marco Gerards
Hi, Here is a patch for testing purposes. I hope people can test this on actual hardware. Testing will help a lot for the development of the ATA driver. The code to reset the channel was removed, replace with something that only queries the channel. Code for probing IDE Controllers on the PCI

Re: [PATCH] read command

2008-02-02 Thread Yoshinori K. Okuji
On Saturday 02 February 2008 18:05, Robert Millan wrote: > On Sat, Feb 02, 2008 at 01:38:28PM +0100, Yoshinori K. Okuji wrote: > > > Does it make sense to move any of these two to kernel? Or to > > > normal.mod ? Or maybe just to un-static-ize them and leave them here? > > > > What would be other

Re: [PATCH] read command

2008-02-02 Thread Robert Millan
On Sat, Feb 02, 2008 at 07:48:57PM +0100, Yoshinori K. Okuji wrote: > > Ok, here's a new patch, with grub_getline returning NULL and the caller > > handling "out of mem" error. > > > > Also fixed a memleak. > > You don't have to set grub_errno explicitly, because grub_realloc should do > it. > >

grub.cfg parser still doesn't abort on error

2008-02-02 Thread Robert Millan
Try the following grub.cfg: cat (memdisk)/non-existant-file echo this point should never be reached read You'll see that the echo is reached, even if cat returned an error. This becomes much worse when found in situations like: font (xxx)/some-file.pff terminal gfxterm and the font

Re: grub.cfg parser still doesn't abort on error

2008-02-02 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > Try the following grub.cfg: > > cat (memdisk)/non-existant-file > echo this point should never be reached > read > > You'll see that the echo is reached, even if cat returned an error. > > This becomes much worse when found in situations like: > >

Re: grub.cfg parser still doesn't abort on error

2008-02-02 Thread Robert Millan
On Sat, Feb 02, 2008 at 09:59:57PM +0100, Marco Gerards wrote: > Robert Millan <[EMAIL PROTECTED]> writes: > > > Try the following grub.cfg: > > > > cat (memdisk)/non-existant-file > > echo this point should never be reached > > read > > > > You'll see that the echo is reached, even if cat r

root seems to be incorrectly set after install

2008-02-02 Thread George Lengel
Hello, I have a problem with my grub2 installation. I am using the latest Debian package (1.95+20080128-1)and I could properly boot using the chainloader method suggested during the initial installation (grub-legacy still in MBR and it calls grub2), but when I decided to place grub2 in the MB

Re: PCI+ATA

2008-02-02 Thread Robert Millan
On Sat, Feb 02, 2008 at 07:38:43PM +0100, Marco Gerards wrote: > Hi, > > Here is a patch for testing purposes. I hope people can test this on > actual hardware. Testing will help a lot for the development of the > ATA driver. > > The code to reset the channel was removed, replace with something

Re: root seems to be incorrectly set after install

2008-02-02 Thread Robert Millan
On Sat, Feb 02, 2008 at 04:41:06PM -0500, George Lengel wrote: > When I reboot I get thrown into rescue mode and typing set shows > grub>prefix= (hd0,7)/boot/grub > grub>root=hd0,7 > > If I manually set root to (hd2,7) and prefix to (hd2,7)/boot/grub I can > insmod normal and then running normal

kernel arguments in multiboot2?

2008-02-02 Thread jakllsch
Hi, Are there any plans for a kernel command line tag in the multiboot2 draft? Jonathan Kollasch pgpH0XPRdJ8zt.pgp Description: PGP signature ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: grub.cfg parser still doesn't abort on error

2008-02-02 Thread Bean
On Feb 3, 2008 5:07 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > On Sat, Feb 02, 2008 at 09:59:57PM +0100, Marco Gerards wrote: > > Robert Millan <[EMAIL PROTECTED]> writes: > > > > > Try the following grub.cfg: > > > > > > cat (memdisk)/non-existant-file > > > echo this point should never be

Re: root seems to be incorrectly set after install

2008-02-02 Thread George Lengel
Robert Millan wrote: Sounds like grub_boot_drive not having the right info. It works when received via multiboot, but not from boot.img. Does the attached patch fix your problem? Just a guess ... Hello, Thanks for the try. It did not appear to make a difference, though I cannot rule o

Re: Does grub2 solve this problem I am having with grub1? RE: usbsticks.

2008-02-02 Thread Pavel Roskin
On Sat, 2008-02-02 at 08:34 -0600, Paul Elliott wrote: > On Sat, Feb 02, 2008 at 01:11:18PM +0100, Yoshinori K. Okuji wrote: > > > > It is already there. GRUB 2 already supports setting a root based on a > > filesystem label or a path. Indeed! That's much easier that LVM :-) > What is the synt

Re: kernel arguments in multiboot2?

2008-02-02 Thread jakllsch
On Sat, Feb 02, 2008 at 08:29:48PM -0600, [EMAIL PROTECTED] wrote: > Hi, > > Are there any plans for a kernel command line tag > in the multiboot2 draft? Oh, there it is. Nevermind. Jonathan Kollasch pgpjAhRdmAzUO.pgp Description: PGP signature