On Sat, Feb 02, 2008 at 10:19:55PM +0800, Bean wrote: > > any objection for this patch ? i would like to commit it soon.
Looks fine to me. Just a minor comment: > +#define GRUB_BIOSDISK_MACHINE_CDROM_START 0xe0 > +#define GRUB_BIOSDISK_MACHINE_CDROM_END 0xf0 could you make this tab-indented? Also, I notice that GRUB_BIOSDISK_MACHINE_CDROM_END is not used. Did you plan to add a sanity check in init.c using this macro ? -- Robert Millan <GPLv2> I know my rights; I want my phone call! <DRM> What use is a phone call… if you are unable to speak? (as seen on /.) _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
