Re: grub-probe && statfs(2)

2008-01-01 Thread Francis Gendreau
On Sun, 2007-12-30 at 13:38 +0100, Yoshinori K. Okuji wrote: > Hello, > > On Saturday 29 December 2007 13:36, Francis Gendreau wrote: > > My recommendation would be relatively simple. grub_guess_root_device() > > could simply call statfs() and extract the device name from struct > > statfs f_mnt

Re: [patch] Background support for gfxterm and improved scrolling performance.

2008-01-01 Thread Robert Millan
On Sun, Dec 30, 2007 at 06:52:55PM +0200, Vesa Jääskeläinen wrote: > > This patch should also fix Robert's problem with menu colors. It does! Thanks Vesa -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)

Re: [PATCH] Fix eisa_mmap evaluation, add memory existence check

2008-01-01 Thread Robert Millan
On Mon, Dec 31, 2007 at 04:40:00PM +0100, Christian Franke wrote: > This version of the patch contains only the fix for the E801 EISA memory > map. The memory existence check was helpful for testing but is not > really necessary. I think the memory existence check might be good to have (I'd make

Re: [patch] Background support for gfxterm and improved scrolling performance.

2008-01-01 Thread Vesa Jääskeläinen
Robert Millan wrote: > On Sun, Dec 30, 2007 at 06:52:55PM +0200, Vesa Jääskeläinen wrote: >> This patch should also fix Robert's problem with menu colors. > > It does! Thanks Vesa In it went. ___ Grub-devel mailing list Grub-devel@gnu.org http://list

[PATCH] allow user-configurable menucolor

2008-01-01 Thread Robert Millan
This patch allows the following to work: set color_normal=cyan/blue set color_highlight=white/blue which is equivalent to this command in GRUB Legacy: color cyan/blue white/blue I haven't written a ChangeLog entry yet, because I'd like to receive comments on the function names. I don't

Re: [PATCH] allow user-configurable menucolor

2008-01-01 Thread Vesa Jääskeläinen
Robert Millan wrote: > This patch allows the following to work: > > set color_normal=cyan/blue > set color_highlight=white/blue > > which is equivalent to this command in GRUB Legacy: > > color cyan/blue white/blue > > I haven't written a ChangeLog entry yet, because I'd like to receive c

Re: [PATCH] allow user-configurable menucolor

2008-01-01 Thread Robert Millan
On Tue, Jan 01, 2008 at 03:14:50PM +0200, Vesa Jääskeläinen wrote: > > First some questions ;) > > - What happens when you forgot to provide / in this string ;) ? grub_strchr() returns NULL and... whoops! I'll fix that :-) > - What happens when all memory is used? What do you mean? > - What

Re: [PATCH] allow user-configurable menucolor

2008-01-01 Thread Vesa Jääskeläinen
Robert Millan wrote: > On Tue, Jan 01, 2008 at 03:14:50PM +0200, Vesa Jääskeläinen wrote: >> First some questions ;) >> >> - What happens when you forgot to provide / in this string ;) ? > > grub_strchr() returns NULL and... whoops! I'll fix that :-) > >> - What happens when all memory is used?

Re: [PATCH] allow user-configurable menucolor

2008-01-01 Thread Robert Millan
Thanks for the pointers. While fixing them I found other mistakes, then started "torturing" the code with ill user input, found more mistakes, and ended up refactoring most of it. See attached new patch, this time including ChangeLog entry. -- Robert Millan I know my rights; I want my phone

Re: [PATCH] Fix eisa_mmap evaluation, add memory existence check

2008-01-01 Thread Christian Franke
Robert Millan wrote: On Mon, Dec 31, 2007 at 04:40:00PM +0100, Christian Franke wrote: This version of the patch contains only the fix for the E801 EISA memory map. The memory existence check was helpful for testing but is not really necessary. I think the memory existence check might

Re: [PATCH] allow user-configurable menucolor

2008-01-01 Thread Robert Millan
Some rework to support user-defined colors in non-menu as well. This is most desirable when using the new background image feature implemented by Vesa, since light-grey may not be properly readable depending on the image you're using. Example for bios console, setting up only menu color: set me

Re: [PATCH] Fix eisa_mmap evaluation, add memory existence check

2008-01-01 Thread Robert Millan
On Tue, Jan 01, 2008 at 06:26:49PM +0100, Christian Franke wrote: > >>--- grub2.orig/kern/i386/pc/init.c 2007-10-22 22:22:51.359375000 +0200 > >>+++ grub2/kern/i386/pc/init.c 2007-12-31 16:05:59.953125000 +0100 > >>@@ -199,13 +199,8 @@ grub_machine_init (void) > >> > >> if (eisa_mmap)

Re: [PATCH] Fix eisa_mmap evaluation, add memory existence check

2008-01-01 Thread Christian Franke
Robert Millan wrote: ... This part is intended to handle the (normal) case of one continuous region with not gap between 1M and 16M: (0x3C00 << 10) = 0x10 * 15 = 15M But this part does not work due to the same bug. It is IMO not necessary to make this distinction. The function comp

Re: [PATCH] Fix eisa_mmap evaluation, add memory existence check

2008-01-01 Thread Robert Millan
On Tue, Jan 01, 2008 at 07:03:36PM +0100, Christian Franke wrote: > > > >Ah, ok. Have you verified that this is so? (setting debug=mem variable > >during init might help on that). > > Yes. During testing, I temporarily added some diagnostic output. The > function compact_mem_regions() works as

package for distribution

2008-01-01 Thread shirish
Hi all, I have been trying to see when GRUB2 is packaged so I could try it, use it & understand all or any differences. I am running Ubuntu Hardy Heron (unstable). AFAIK Ubuntu sources the GRUB2 package from Debian Sid & the last packaging was done on 20071101-1 http://packages.debian.org/si

Re: package for distribution

2008-01-01 Thread Pavel Roskin
Hello! Quoting shirish <[EMAIL PROTECTED]>: Hi all, I have been trying to see when GRUB2 is packaged so I could try it, use it & understand all or any differences. I am running Ubuntu Hardy Heron (unstable). I think you make a wrong assumption here, that if GRUB2 is packaged, changin

Re: Testing on PowerMac G4

2008-01-01 Thread Pavel Roskin
Quoting Robert Millan <[EMAIL PROTECTED]>: My guess is kernel.elf doesn't include the necessary code. It's about 60k long. Now I'm sure about that. Unfortunately, grub-mkimage produces images that the OpenFirmware fails to load with "CLAIM failed" (even with just one short module). Inde