On Tue, Jan 01, 2008 at 03:14:50PM +0200, Vesa Jääskeläinen wrote: > > First some questions ;) > > - What happens when you forgot to provide / in this string ;) ?
grub_strchr() returns NULL and... whoops! I'll fix that :-) > - What happens when all memory is used? What do you mean? > - What happens when you alter list of colors... remove one entry of it > or add one. This should never happen. The list is just a human description of GRUB color codes. GRUB VGA-style color codes are never changed in runtime, so neither should this list. > (eg. hard coding is bad... sizeof...) Where can sizeof be used? > Now to your naming issue... > > This code is quite specific to be only local so I would propose following: > > parse_single_color_name -> parse_color_name > > parse_color_name -> parse_color_tuple, parse_color_pair, > parse_text_color or parse_menu_color How about `parse_color_name_pair' ? -- Robert Millan <GPLv2> I know my rights; I want my phone call! <DRM> What use is a phone call, if you are unable to speak? (as seen on /.) _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
