Re: update-grub2 patch

2007-05-04 Thread Robert Millan
On Thu, May 03, 2007 at 11:44:14PM +0200, Yoshinori K. Okuji wrote: > On Thursday 03 May 2007 17:48, Robert Millan wrote: > > On Wed, May 02, 2007 at 03:31:16PM +0200, Robert Millan wrote: > > > > You should avoid ! in test. Use else instead. > > > > > > Earlier when I read the portability document

Re: update-grub2 patch

2007-05-03 Thread Yoshinori K. Okuji
On Thursday 03 May 2007 17:48, Robert Millan wrote: > On Wed, May 02, 2007 at 03:31:16PM +0200, Robert Millan wrote: > > > You should avoid ! in test. Use else instead. > > > > Earlier when I read the portability document I was pointed to, I found: > > > > "You may use `!' with `test', but not wi

Re: update-grub2 patch

2007-05-03 Thread Robert Millan
On Wed, May 02, 2007 at 03:31:16PM +0200, Robert Millan wrote: > > You should avoid ! in test. Use else instead. > > Earlier when I read the portability document I was pointed to, I found: > > "You may use `!' with `test', but not with `if'" > > Are you sure this change is required? Well, sin

Re: update-grub2 patch

2007-05-02 Thread Amin Azez
* Robert Millan wrote, On 02/05/07 14:31: > Do you mean something like: > IFS=: > for i in $PATH ; do > grub-probe="$i/grub-probe" > if test -x $grub-probe ; then break ; fi > done > > You may as well define your own which: which() { IFS=: for i in $PATH ; do if test -x "$i/$1" th

Re: update-grub2 patch

2007-05-02 Thread Robert Millan
On Tue, May 01, 2007 at 10:45:39PM +0200, Yoshinori K. Okuji wrote: > On Monday 30 April 2007 01:22, Robert Millan wrote: > > On Sat, Apr 21, 2007 at 03:38:38PM +0200, Yoshinori K. Okuji wrote: > > > On Tuesday 17 April 2007 14:49, Robert Millan wrote: > > > > Here's my patch. Let me know if it's

Re: update-grub2 patch

2007-05-01 Thread Yoshinori K. Okuji
On Monday 30 April 2007 01:22, Robert Millan wrote: > On Sat, Apr 21, 2007 at 03:38:38PM +0200, Yoshinori K. Okuji wrote: > > On Tuesday 17 April 2007 14:49, Robert Millan wrote: > > > Here's my patch. Let me know if it's ok for commit. > > > > To include this in the official repository, you need

Re: update-grub2 patch

2007-04-29 Thread Robert Millan
On Sat, Apr 21, 2007 at 03:38:38PM +0200, Yoshinori K. Okuji wrote: > On Tuesday 17 April 2007 14:49, Robert Millan wrote: > > Here's my patch. Let me know if it's ok for commit. > > To include this in the official repository, you need to take care about the > portability. [...] I ported it to

Re: update-grub2 patch

2007-04-21 Thread Yoshinori K. Okuji
On Tuesday 17 April 2007 14:49, Robert Millan wrote: > Here's my patch. Let me know if it's ok for commit. To include this in the official repository, you need to take care about the portability. You should not rely on the existence of some programs. For instance, you use bash. This is not good

Re: update-grub2 patch

2007-04-17 Thread Otavio Salvador
Robert Millan <[EMAIL PROTECTED]> writes: > Here's my patch. Let me know if it's ok for commit. It looks OK. After commiting it we can start to try to push "plugins" for others like Xen. -- O T A V I OS A L V A D O R - E-mail: [EMAIL PRO

update-grub2 patch

2007-04-17 Thread Robert Millan
Here's my patch. Let me know if it's ok for commit. -- Robert Millan My spam trap is [EMAIL PROTECTED] Note: this address is only intended for spam harvesters. Writing to it will get you added to my black list. 2007-04-17 Robert Millan <[EMAIL PROTECTED]> * DISTLIST: Add util/update-gru