On Tuesday 17 April 2007 14:49, Robert Millan wrote: > Here's my patch. Let me know if it's ok for commit.
To include this in the official repository, you need to take care about the portability. You should not rely on the existence of some programs. For instance, you use bash. This is not good. Use /bin/sh instead. You use shopt. This is not good, because this is specific to bash. The way in which you write test expressions is not very portable. Also, don't use negations (i.e. `!'), because they don't behave correctly on some platforms. Use "if ... then else ..." instead. For more information, please look at the chapter "Portable Shell Programming" in the Autoconf manual. Regards, Okuji _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
