On Tue, Feb 12, 2008 at 12:37:45PM +0100, Alexandre Boeglin wrote:
> Le mar 12 fév 2008 à 11:47:26 +0100, Robert Millan a écrit :
> > On Mon, Feb 11, 2008 at 11:15:50PM +0100, Alexandre Boeglin wrote:
> > > Le lun 11 fév 2008 à 15:11:44 +0100, Robert Millan a écrit :
> > > > No. See how other part
Le mar 12 fév 2008 à 11:47:26 +0100, Robert Millan a écrit :
> On Mon, Feb 11, 2008 at 11:15:50PM +0100, Alexandre Boeglin wrote:
> > Le lun 11 fév 2008 à 15:11:44 +0100, Robert Millan a écrit :
> > > No. See how other parts of GRUB do it.
> >
> > Ok, here's the patch. I also added 2008 to the co
On Mon, Feb 11, 2008 at 11:15:50PM +0100, Alexandre Boeglin wrote:
> Le lun 11 fév 2008 à 15:11:44 +0100, Robert Millan a écrit :
> > No. See how other parts of GRUB do it.
>
> Ok, here's the patch. I also added 2008 to the copyright statement of modified
> files.
You forgot the changelog entry
Le lun 11 fév 2008 à 15:11:44 +0100, Robert Millan a écrit :
> No. See how other parts of GRUB do it.
Ok, here's the patch. I also added 2008 to the copyright statement of modified
files.
Alex
diff -ruNap -x CVS -x '*.lst' -x '*.mk' -x '.*' -x '*.d' -x '*.o' grub2_commit/commands/halt.c grub2_c
On Sun, Feb 10, 2008 at 10:58:02PM +0100, Alexandre Boeglin wrote:
> Le dim 10 fév 2008 à 22:05:46 +0100, Robert Millan a écrit :
> > For consistency with similar code elsewhere in GRUB, I think it's better if
> > you made this:
> >
> > #if defined(foo)
> > #elif defined(bar)
> > #endif
>
> No wh
Le dim 10 fév 2008 à 22:05:46 +0100, Robert Millan a écrit :
> For consistency with similar code elsewhere in GRUB, I think it's better if
> you made this:
>
> #if defined(foo)
> #elif defined(bar)
> #endif
No whitespace before the opening bracket in this case ?
By the way, this case is a good e
On Sun, Feb 10, 2008 at 08:54:08PM +0100, Alexandre Boeglin wrote:
> +#ifdef GRUB_MACHINE_IEEE1275
> #include
> +#elif defined GRUB_MACHINE_EFI
> +#include
> +#endif
For consistency with similar code elsewhere in GRUB, I think it's better if
you made this:
#if defined(foo)
#elif defined(bar)
#
Le dim 10 fév 2008 à 17:56:12 +0100, Robert Millan a écrit :
> On Sun, Feb 10, 2008 at 05:37:27PM +0100, Alexandre Boeglin wrote:
> >
> > * commands/halt.c: ... to here.
> > Add some precompiler directive to include the correct header for each
> > machine.
>
> Can we simplify this? Since gru
On Sun, Feb 10, 2008 at 05:37:27PM +0100, Alexandre Boeglin wrote:
>
> * commands/halt.c: ... to here.
> Add some precompiler directive to include the correct header for each
> machine.
Can we simplify this? Since grub_halt() is put in kernel anyway, why not
always export it from kernel.h ?
Le mar 05 fév 2008 à 23:10:23 +0100, Robert Millan a écrit :
> On Tue, Feb 05, 2008 at 10:39:29PM +0100, Alexandre Boeglin wrote:
> > Le mer 23 jan 2008 à 12:43:31 +0100, Robert Millan a écrit :
> > > commands/ieee1275/halt.c looks like the same thing to me. Perhaps it'd
> > > make
> > > more sen
On Fri, Feb 08, 2008 at 12:38:06PM +0100, Alexandre Boeglin wrote:
> Le mer 06 fév 2008 à 01:11:04 +0100, Robert Millan a écrit :
> > On Wed, Feb 06, 2008 at 12:11:41AM +0100, Alexandre Boeglin wrote:
> > > This was just a one line fix:
> > >
> > > Index: normal/arg.c
> > > ===
Le mer 06 fév 2008 à 01:11:04 +0100, Robert Millan a écrit :
> On Wed, Feb 06, 2008 at 12:11:41AM +0100, Alexandre Boeglin wrote:
> > This was just a one line fix:
> >
> > Index: normal/arg.c
> > ===
> > RCS file: /sources/grub/grub2/
On Wed, Feb 06, 2008 at 12:11:41AM +0100, Alexandre Boeglin wrote:
> Le mar 05 fév 2008 à 23:11:52 +0100, Robert Millan a écrit :
> > On Tue, Feb 05, 2008 at 10:34:09PM +0100, Alexandre Boeglin wrote:
> > > - "--" handling is trivial, I think this can be commited.
> >
> > Please can you add a foll
Le mar 05 fév 2008 à 23:11:52 +0100, Robert Millan a écrit :
> On Tue, Feb 05, 2008 at 10:34:09PM +0100, Alexandre Boeglin wrote:
> > - "--" handling is trivial, I think this can be commited.
>
> Please can you add a follow-up in the relevant thread(s) ? I get easily
> confused in this gazillon o
On Tue, Feb 05, 2008 at 10:34:09PM +0100, Alexandre Boeglin wrote:
>
> Hi,
>
> I'm sorry, I've been a bit busy recently. So, here's a recap of the four
> initial patches I posted:
>
> - "--" handling is trivial, I think this can be commited.
Please can you add a follow-up in the relevant thread
On Tue, Feb 05, 2008 at 10:39:29PM +0100, Alexandre Boeglin wrote:
> Le mer 23 jan 2008 à 12:43:31 +0100, Robert Millan a écrit :
> > commands/ieee1275/halt.c looks like the same thing to me. Perhaps it'd make
> > more sense to move that to commands/halt.c and use it as the "generic"
> > version
Le mer 23 jan 2008 à 12:43:31 +0100, Robert Millan a écrit :
> commands/ieee1275/halt.c looks like the same thing to me. Perhaps it'd make
> more sense to move that to commands/halt.c and use it as the "generic" version
> of halt command?
Ok, is there any objection ?
___
Le mer 23 jan 2008 à 12:39:35 +0100, Marco Gerards a écrit :
> Alexandre Boeglin <[EMAIL PROTECTED]> writes:
> > As Marco finally received my copyright application papers, could someone
> > have a look at these patches ?
>
> Just to be very sure: did this happen?
Hi,
I'm sorry, I've been a bit b
"Yoshinori K. Okuji" <[EMAIL PROTECTED]> writes:
> On Wednesday 23 January 2008 12:44, Robert Millan wrote:
>> On Wed, Jan 23, 2008 at 12:39:35PM +0100, Marco Gerards wrote:
>> > Alexandre Boeglin <[EMAIL PROTECTED]> writes:
>> > > On Sun, 18 Nov 2007 19:14:03 +0100, Alexandre Boeglin
>> > > <[EMA
On Wednesday 23 January 2008 12:44, Robert Millan wrote:
> On Wed, Jan 23, 2008 at 12:39:35PM +0100, Marco Gerards wrote:
> > Alexandre Boeglin <[EMAIL PROTECTED]> writes:
> > > On Sun, 18 Nov 2007 19:14:03 +0100, Alexandre Boeglin
> > > <[EMAIL PROTECTED]>
> > >
> > > wrote:
> > >> I also still ha
Robert Millan <[EMAIL PROTECTED]> writes:
> On Wed, Jan 23, 2008 at 12:39:35PM +0100, Marco Gerards wrote:
>> Alexandre Boeglin <[EMAIL PROTECTED]> writes:
>>
>> > On Sun, 18 Nov 2007 19:14:03 +0100, Alexandre Boeglin <[EMAIL PROTECTED]>
>> > wrote:
>> >> I also still have to clean the chainloade
On Wed, Jan 23, 2008 at 12:39:35PM +0100, Marco Gerards wrote:
> Alexandre Boeglin <[EMAIL PROTECTED]> writes:
>
> > On Sun, 18 Nov 2007 19:14:03 +0100, Alexandre Boeglin <[EMAIL PROTECTED]>
> > wrote:
> >> I also still have to clean the chainloader options patch, but here is the
> >> changelog fo
On Sun, Nov 18, 2007 at 07:14:03PM +0100, Alexandre Boeglin wrote:
> Index: commands/i386/efi/halt.c
> ===
> RCS file: commands/i386/efi/halt.c
> diff -N commands/i386/efi/halt.c
> [...]
> +static grub_err_t
> +grub_cmd_halt (struct
Alexandre Boeglin <[EMAIL PROTECTED]> writes:
> On Sun, 18 Nov 2007 19:14:03 +0100, Alexandre Boeglin <[EMAIL PROTECTED]>
> wrote:
>> I also still have to clean the chainloader options patch, but here is the
>> changelog for the others:
>
> Hi,
>
> As Marco finally received my copyright applicatio
On Sun, 18 Nov 2007 19:14:03 +0100, Alexandre Boeglin <[EMAIL PROTECTED]>
wrote:
> I also still have to clean the chainloader options patch, but here is the
> changelog for the others:
Hi,
As Marco finally received my copyright application papers, could someone
have a look at these patches ?
Re
Hello,
Sorry for not replying earlier, I'm currently busy trying to figure out how to
access the Compatibility Support Module, and possibly enable lecagy boot.
Le Sat, Nov 10, 2007 at 04:45:43PM +0100, Marco Gerards a écrit :
> Alexandre Boeglin <[EMAIL PROTECTED]> writes:
> > grub2_efi_grub_pref
Alexandre Boeglin <[EMAIL PROTECTED]> writes:
Hi,
> Here are a few patches for grub2, against cvs head:
Great! Thanks for working on this! Can you please send in ChangeLog
entries for these patches?
> grub2_arg_doubledash.patch fixes a bug in the handling of the '--'
> argument,
>
> grub2_efi
Alexandre Boeglin <[EMAIL PROTECTED]> writes:
> On Sun, 4 Nov 2007 01:21:24 +0100, Alexandre Boeglin <[EMAIL PROTECTED]>
> wrote:
>> Le Sun, Nov 04, 2007 at 01:04:24AM +0100, Alexandre Boeglin a écrit :
>>> Sorry, there was a mistake in the previous one ...
>> Oops, and line 91 of this one should
Alexandre Boeglin <[EMAIL PROTECTED]> writes:
> On Sun, 4 Nov 2007 00:06:31 +0100, Alexandre Boeglin <[EMAIL PROTECTED]>
> wrote:
>> grub2_efi_chainloader_options.patch adds support for efi chainload
>> options,
>> it is not really beautiful (for instance, the ascii to utf16 conversion),
>> but it
On Sun, 4 Nov 2007 01:21:24 +0100, Alexandre Boeglin <[EMAIL PROTECTED]>
wrote:
> Le Sun, Nov 04, 2007 at 01:04:24AM +0100, Alexandre Boeglin a écrit :
>> Sorry, there was a mistake in the previous one ...
> Oops, and line 91 of this one should be
Hi, here is a "more correct" version of this patch
Le Sun, Nov 04, 2007 at 01:04:24AM +0100, Alexandre Boeglin a écrit :
> Sorry, there was a mistake in the previous one ...
Oops, and line 91 of this one should be
+loaded_image->load_options_size = options_len + sizeof (*options);
instead of
+loaded_image->load_options_size = options_le
On Sun, 4 Nov 2007 00:06:31 +0100, Alexandre Boeglin <[EMAIL PROTECTED]>
wrote:
> grub2_efi_chainloader_options.patch adds support for efi chainload
> options,
> it is not really beautiful (for instance, the ascii to utf16 conversion),
> but it works for the MacOSX loader,
Sorry, there was a mista
Hello,
Here are a few patches for grub2, against cvs head:
grub2_arg_doubledash.patch fixes a bug in the handling of the '--'
argument,
grub2_efi_chainloader_options.patch adds support for efi chainload options,
it is not really beautiful (for instance, the ascii to utf16 conversion),
but it wor
33 matches
Mail list logo
