On Sun, Feb 10, 2008 at 08:54:08PM +0100, Alexandre Boeglin wrote:
> +#ifdef GRUB_MACHINE_IEEE1275
>  #include <grub/machine/kernel.h>
> +#elif defined GRUB_MACHINE_EFI
> +#include <grub/efi/efi.h>
> +#endif

For consistency with similar code elsewhere in GRUB, I think it's better if
you made this:

#if defined(foo)
#elif defined(bar)
#endif

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to