On Fri, May 17, 2019 at 12:12:31PM -0500, Bruce Dubbs wrote:
> On 5/17/19 2:13 AM, Michael Chang wrote:
> > Hello John,
> >
> > Except for lacking commit message and SOB, the fix is LGTM.
>
> [snip]
>
> > > ---
> > > grub-core/fs/f2fs.c | 10 ++
> > > 1 file changed, 10 insertions(+)
> >
On 5/17/19 2:13 AM, Michael Chang wrote:
Hello John,
Except for lacking commit message and SOB, the fix is LGTM.
[snip]
---
grub-core/fs/f2fs.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/grub-core/fs/f2fs.c b/grub-core/fs/f2fs.c
index 1cad2615f..0dd09bc23 100644
--- a
Hi Michael!
On 5/17/19 9:13 AM, Michael Chang wrote:
> Except for lacking commit message and SOB, the fix is LGTM.
>
> You could add my Reviewed-by: Michael Chang if you
> resend the patch to mailing list with those missing message fixed.
I can do that later today. I'm currently busy with work
On Wed, May 08, 2019 at 01:51:20AM +0100, Neil MacLeod wrote:
> Adrian
>
> I used the attached patch and grub is now building for me with gcc-9.1.
>
> I've no idea if this is the right solution, but it does at least work
> (ie. builds) which is all I require for now as I'm not personally
> using
Hello John,
Except for lacking commit message and SOB, the fix is LGTM.
You could add my Reviewed-by: Michael Chang if you
resend the patch to mailing list with those missing message fixed.
Thanks,
Michael
On Mon, May 06, 2019 at 07:59:42PM +0200, John Paul Adrian Glaubitz wrote:
> On 5/6/19
CC-ing Michael.
On Wed, May 08, 2019 at 02:09:17AM +0100, Neil MacLeod wrote:
> Sorry, wrong patch in previous email - this is the one for grub!
>
> Neil
>
> On Wed, 8 May 2019 at 01:51, Neil MacLeod wrote:
> >
> > Adrian
> >
> > I used the attached patch and grub is now building for me with gcc-
Sorry, wrong patch in previous email - this is the one for grub!
Neil
On Wed, 8 May 2019 at 01:51, Neil MacLeod wrote:
>
> Adrian
>
> I used the attached patch and grub is now building for me with gcc-9.1.
>
> I've no idea if this is the right solution, but it does at least work
> (ie. builds) w
Adrian
I used the attached patch and grub is now building for me with gcc-9.1.
I've no idea if this is the right solution, but it does at least work
(ie. builds) which is all I require for now as I'm not personally
using grub in the distribution I'm building (LibreELEC) and can't
actually say if
Hi Adrian
With your patch, grub now fails to build as follows:
fs/f2fs.c: In function 'grub_f2fs_get_block':
fs/f2fs.c:864:43: error: 'offset' may be used uninitialized in this
function [-Werror=maybe-uninitialized]
864 | return grub_le_to_cpu32 (inode->i_addr[offset[0]]);
|
Thanks Adrian - testing with your patch now, will be another hour or
so until the build is complete (cross-compiling environment with own
toolchain etc.)
Just a correction, I'm testing with
4dd4ceec023111a4ccf69f8de6fa0885c6847a35 (current HEAD) - looks like I
cut & pasted a rev from a different r
On 5/6/19 7:15 PM, Neil MacLeod wrote:
> Does anyone have a patch?
Try the attached patch.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaub...@debian.org
`. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
`-GPG: 62FF 8A75 84E0 2956 9546 0006 7426
Hi Bruce
I'll give that a try in an hour or two once my build machine is not
busy with another job, but presumably this is just for a test as it
doesn't seem like a long term fix? Similar errors have all been fixed
in code but for some reason this f2fs failure remains.
Thanks
Neil
On Mon, 6 May
On 5/6/19 12:15 PM, Neil MacLeod wrote:
With the latest grub HEAD (620857c4dccb8f0548cdb855f6b2f46ebea3919e)
I'm getting the following compilation error with gcc-9.1:
/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.1-devel/toolchain/bin/x86_64-libreelec-linux-gnu-gcc
-DHAVE_C
With the latest grub HEAD (620857c4dccb8f0548cdb855f6b2f46ebea3919e)
I'm getting the following compilation error with gcc-9.1:
/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.1-devel/toolchain/bin/x86_64-libreelec-linux-gnu-gcc
-DHAVE_CONFIG_H -I. -Wall -W -DGRUB_UTIL=1 -D_FIL
14 matches
Mail list logo
