On Fri, May 17, 2019 at 12:12:31PM -0500, Bruce Dubbs wrote:
> On 5/17/19 2:13 AM, Michael Chang wrote:
> > Hello John,
> >
> > Except for lacking commit message and SOB, the fix is LGTM.
>
> [snip]
>
> > > ---
> > > grub-core/fs/f2fs.c | 10 ++++++++++
> > > 1 file changed, 10 insertions(+)
> > >
> > > diff --git a/grub-core/fs/f2fs.c b/grub-core/fs/f2fs.c
> > > index 1cad2615f..0dd09bc23 100644
> > > --- a/grub-core/fs/f2fs.c
> > > +++ b/grub-core/fs/f2fs.c
> > > @@ -1235,6 +1235,12 @@ grub_f2fs_utf16_to_utf8 (grub_uint16_t *in_buf_le)
> > > return out_buf;
> > > }
> > > +
> > > +#if __GNUC__ >= 9
> > > +#pragma GCC diagnostic push
> > > +#pragma GCC diagnostic ignored "-Waddress-of-packed-member"
> > > +#endif
> > > +
> > > static grub_err_t
> > > grub_f2fs_label (grub_device_t device, char **label)
> > > {
> > > @@ -1255,6 +1261,10 @@ grub_f2fs_label (grub_device_t device, char
> > > **label)
> > > return grub_errno;
> > > }
> > > +#if __GNUC__ >= 9
> > > +#pragma GCC diagnostic pop
> > > +#endif
> > > +
> > > static grub_err_t
> > > grub_f2fs_uuid (grub_device_t device, char **uuid)
> > > {
>
> I would like to point out that it is not a good idea to make a stable
> release using -Werror as a default. It is fine for development, but grub
> has traditionally taken a long time between stable releases (version 2.00
> was in 2012 and version 2.02 was in 2017). After release, a new version of
> a compiler has a high probability of producing more warnings, which will
> break the build if using -Werrror.
>
> At linuxfromscratch we add --disable-werror, but it really shouldn't be
> needed.
Thank you for your notice but there was no plan to make -Werror as
a default. Michael sent better fix and now it is in the tree.
Daniel
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
