Re: gettext: grub_printf_ and N_

2009-12-07 Thread Carles Pina i Estany
Hi, On Dec/07/2009, Colin Watson wrote: > On Mon, Dec 07, 2009 at 09:11:00PM +, Carles Pina i Estany wrote: > > +int > > +grub_printf_ (const char *fmt, ...) > > +{ > > + va_list ap; > > + int ret; > > + > > + va_start (ap, fmt); > > + ret = grub_printf (_(fmt), ap); > > Doesn't this nee

Re: gettext: grub_printf_ and N_

2009-12-07 Thread Colin Watson
On Mon, Dec 07, 2009 at 09:11:00PM +, Carles Pina i Estany wrote: > +int > +grub_printf_ (const char *fmt, ...) > +{ > + va_list ap; > + int ret; > + > + va_start (ap, fmt); > + ret = grub_printf (_(fmt), ap); Doesn't this need to be grub_vprintf? -- Colin Watson

Re: gettext: grub_printf_ and N_

2009-12-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Carles Pina i Estany wrote: > Hi, > > Attached a patch that makes a new function (grub_printf_) which one > calls _( ) for the format argument. Also adapts the current > translations but not the pending patch. > > Can someone take a look? If the grub_printf_ approach is used then this > should be c