Re: Option handling in grub-mkconfig

2010-05-24 Thread Grégoire Sutre
On 05/24/2010 06:42 AM, BVK Chaitanya wrote: 2010/5/21 Grégoire Sutre: The processing of option `-o' in grub-mkconfig only works when it is the first option. IMO this issue might have been fixed in experimental branch, by fix-cmdline-parsing (or similar) branch. I am on travel, so I cannot

Re: Option handling in grub-mkconfig

2010-05-23 Thread BVK Chaitanya
2010/5/21 Grégoire Sutre : > > The processing of option `-o' in grub-mkconfig only works when > it is the first option. > IMO this issue might have been fixed in experimental branch, by fix-cmdline-parsing (or similar) branch. I am on travel, so I cannot confirm this now :-( -- bvk.chaitanya

Re: Option handling in grub-mkconfig

2010-05-21 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Colin Watson wrote: > On Fri, May 21, 2010 at 02:19:36PM +0200, Grégoire Sutre wrote: > >> Thanks for the patch, it works fine. I'm just wondering: Is keeping >> `-o' worth the extra complication? >> > > I think so. It's probably stuck in a number of people's heads by now. > > If we want

Re: Option handling in grub-mkconfig

2010-05-21 Thread Colin Watson
On Fri, May 21, 2010 at 02:19:36PM +0200, Grégoire Sutre wrote: > Thanks for the patch, it works fine. I'm just wondering: Is keeping > `-o' worth the extra complication? I think so. It's probably stuck in a number of people's heads by now. If we want to simplify things, we should use something

Re: Option handling in grub-mkconfig

2010-05-21 Thread Grégoire Sutre
On 05/21/2010 12:57 PM, Colin Watson wrote: Thanks for the patch, it works fine. I'm just wondering: Is keeping `-o' worth the extra complication? Grégoire How about: === modified file 'util/grub-mkconfig.in' --- util/grub-mkconfig.in 2010-04-19 19:25:41 + +++ util/grub-mkconfig.in

Re: Option handling in grub-mkconfig

2010-05-21 Thread Colin Watson
On Fri, May 21, 2010 at 12:08:48PM +0200, Grégoire Sutre wrote: > The processing of option `-o' in grub-mkconfig only works when > it is the first option. The code is: > > # Check the arguments. > for option in "$@"; do > case "$option" in > [...] > -o) > shift > grub_cfg=$1 >