Re: GRUB error: unknown filesystem on ia64

2021-04-21 Thread Javier Martinez Canillas
On 4/19/21 7:56 PM, Javier Martinez Canillas wrote: [snip] >> >> Could you send the patch to the mailing list separately with git send-email >> or so that it doesn't get overlooked in the longer discussion we had? >> > > Yes, I was waiting for someone else more familiar with the COFF/PE binary >

Re: GRUB error: unknown filesystem on ia64

2021-04-19 Thread Javier Martinez Canillas
On 4/19/21 5:33 PM, John Paul Adrian Glaubitz wrote: > Hi Javier1 > > On 4/16/21 11:32 PM, Javier Martinez Canillas wrote: >>> I can confirm that this fixes the issue and makes GRUB work again on ia64. >>> >>> Tested-by: John Paul Adrian Glaubitz >>> >> >> Great, thanks a lot for the quick testin

Re: GRUB error: unknown filesystem on ia64

2021-04-19 Thread John Paul Adrian Glaubitz
Hi Javier1 On 4/16/21 11:32 PM, Javier Martinez Canillas wrote: >> I can confirm that this fixes the issue and makes GRUB work again on ia64. >> >> Tested-by: John Paul Adrian Glaubitz >> > > Great, thanks a lot for the quick testing! Could you send the patch to the mailing list separately with

Re: GRUB error: unknown filesystem on ia64

2021-04-16 Thread Javier Martinez Canillas
Hello Adrian, On 4/16/21 10:32 PM, John Paul Adrian Glaubitz wrote: [snip] >> > > I can confirm that this fixes the issue and makes GRUB work again on ia64. > > Tested-by: John Paul Adrian Glaubitz > Great, thanks a lot for the quick testing! Best regards, Javier

Re: GRUB error: unknown filesystem on ia64

2021-04-16 Thread John Paul Adrian Glaubitz
Hi Javier! On 4/16/21 10:14 PM, Javier Martinez Canillas wrote: > On 4/16/21 6:55 PM, John Paul Adrian Glaubitz wrote: >> Hi! >> >> On 4/16/21 6:43 PM, John Paul Adrian Glaubitz wrote: >>> It seems the patch no longer applies due to the changes introduced by the >>> --sbat >>> option [1]. >> >> I

Re: GRUB error: unknown filesystem on ia64

2021-04-16 Thread Javier Martinez Canillas
On 4/16/21 6:55 PM, John Paul Adrian Glaubitz wrote: > Hi! > > On 4/16/21 6:43 PM, John Paul Adrian Glaubitz wrote: >> It seems the patch no longer applies due to the changes introduced by the >> --sbat >> option [1]. > > I have manually rebased the patch like this. Rebuilding GRUB with that cha

Re: GRUB error: unknown filesystem on ia64

2021-04-16 Thread John Paul Adrian Glaubitz
Hi Javier! On 4/16/21 5:21 PM, Javier Martinez Canillas wrote: > Thanks for the binaries, as you said the ".data" and "mods" sections had > wrong size and content. Could you please try the following patch [0] ? > > It's an RFC since I'm not really an expert on binary formats, but there > were a f

Re: GRUB error: unknown filesystem on ia64

2021-04-16 Thread John Paul Adrian Glaubitz
Hi! On 4/16/21 6:43 PM, John Paul Adrian Glaubitz wrote: > It seems the patch no longer applies due to the changes introduced by the > --sbat > option [1]. I have manually rebased the patch like this. Rebuilding GRUB with that change fixes the problem for me. So you'll just have to rebase your p

Re: GRUB error: unknown filesystem on ia64

2021-04-16 Thread Javier Martinez Canillas
Hello Adrian, Sorry for the delay, I didn't have time to look at this issue before. On 4/12/21 8:57 AM, John Paul Adrian Glaubitz wrote: > Hi Javier! > > On 4/12/21 8:21 AM, Javier Martinez Canillas wrote: >> Interesting, thanks for the input. >> >> Could you please share a both GRUB binary that

Re: GRUB error: unknown filesystem on ia64

2021-04-16 Thread Javier Martinez Canillas
Hello Adrian, Sorry for the delay, I didn't have time to look at this issue before. On 4/12/21 8:57 AM, John Paul Adrian Glaubitz wrote: > Hi Javier! > > On 4/12/21 8:21 AM, Javier Martinez Canillas wrote: >> Interesting, thanks for the input. >> >> Could you please share a both GRUB binary that

Re: GRUB error: unknown filesystem on ia64

2021-04-11 Thread John Paul Adrian Glaubitz
Hi Javier! On 4/12/21 8:21 AM, Javier Martinez Canillas wrote: > Interesting, thanks for the input. > > Could you please share a both GRUB binary that works and one that > fails to compare ? Here are both the EFI as well as the GRUB directory for the broken and working cases: > https://people.d

Re: GRUB error: unknown filesystem on ia64

2021-04-11 Thread Javier Martinez Canillas
Hello Adrian, On Sat, Apr 10, 2021 at 11:41 AM John Paul Adrian Glaubitz wrote: > > On 4/8/21 7:30 PM, John Paul Adrian Glaubitz wrote: > > On 4/8/21 7:10 PM, Javier Martinez Canillas wrote: > >>> Any news on this? I assume this should be trivial to fix when considering > >>> just the > >> > >>

Re: GRUB error: unknown filesystem on ia64

2021-04-10 Thread John Paul Adrian Glaubitz
On 4/8/21 7:30 PM, John Paul Adrian Glaubitz wrote: > On 4/8/21 7:10 PM, Javier Martinez Canillas wrote: >>> Any news on this? I assume this should be trivial to fix when considering >>> just the >> >> Not yet, sorry. I discussed a little bit with Peter yesterday but it's >> strange >> that only

Re: GRUB error: unknown filesystem on ia64

2021-04-08 Thread John Paul Adrian Glaubitz
On 4/8/21 7:10 PM, Javier Martinez Canillas wrote: >> Any news on this? I assume this should be trivial to fix when considering >> just the > > Not yet, sorry. I discussed a little bit with Peter yesterday but it's strange > that only affects ia64 and not x64. I'll try to take a look at this next

Re: GRUB error: unknown filesystem on ia64

2021-04-08 Thread Javier Martinez Canillas
[ adding Peter Jones who authored the patch ] On 4/8/21 6:45 PM, John Paul Adrian Glaubitz wrote: > Hi Daniel! > > On 3/26/21 7:43 PM, Daniel Kiper wrote: >>> The address pointing to the modules within the GRUB core.img no longer >>> matches >>> the actual position of the modules. Hence, GRUB ca

Re: GRUB error: unknown filesystem on ia64

2021-04-08 Thread John Paul Adrian Glaubitz
Hi Daniel! On 3/26/21 7:43 PM, Daniel Kiper wrote: >> The address pointing to the modules within the GRUB core.img no longer >> matches >> the actual position of the modules. Hence, GRUB can't load the built-in >> modules >> anymore. > > Ahhh... OK, great. So, only one bug to fix... :-) Any ne

Re: GRUB error: unknown filesystem on ia64

2021-03-26 Thread Daniel Kiper
On Fri, Mar 26, 2021 at 07:28:37PM +0100, John Paul Adrian Glaubitz wrote: > Hi Daniel! > > On 3/26/21 7:01 PM, Daniel Kiper wrote: > >> I have not bisected the issue yet, but maybe anyone has got any idea? > > > > May I ask you to do a bisect for us? > > The issue was introduced by this patch as d

Re: GRUB error: unknown filesystem on ia64

2021-03-26 Thread John Paul Adrian Glaubitz
Hi Daniel! On 3/26/21 7:01 PM, Daniel Kiper wrote: >> I have not bisected the issue yet, but maybe anyone has got any idea? > > May I ask you to do a bisect for us? The issue was introduced by this patch as discussed here [1]: From: Peter Jones Add a init_pe_section() helper function to setup

Re: GRUB error: unknown filesystem on ia64

2021-03-26 Thread Daniel Kiper
Hey Adrian, On Wed, Mar 17, 2021 at 07:22:02PM +0100, John Paul Adrian Glaubitz wrote: > Hello! > > It seems that one of the security patches has caused a regression on ia64 as > GRUB is no longer able to load any basic commands: > > Loading.: grub > Starting: grub > Welcome to GRUB! > error: unkn