Re: [PATCH v9 02/11] Unify GUID types

re-adding Ard, who was dropped due to a bug in my MUA - sorry. I seems that removing the packed attribute from the GUID struct alone does not solve it. I am about to post a revert of the whole GUID thing so we can move on with the 2.12 release. If we want this feature, I can spend some time on GU

Re: [PATCH v9 02/11] Unify GUID types

Yes, sorry for delay. My laptop is bricked now. I got parts for external reflashing and will attempt to recover it today Le sam. 23 sept. 2023, 10:11, John Paul Adrian Glaubitz < glaub...@physik.fu-berlin.de> a écrit : > Hi Vladimir! > > On Mon, 2023-08-14 at 13:56 +0200, Vladimir 'phcoder' Serbi

Re: [PATCH v9 02/11] Unify GUID types

Hi Vladimir! On Mon, 2023-08-14 at 13:56 +0200, Vladimir 'phcoder' Serbinenko wrote: > I uploaded the entire branch (patches) to my GitHub copy:  > https://github.com/phcoder/GRUB/tree/rb1 Any chance this could be reworked and merged before the 2.12 release? Adrian -- .''`. John Paul Adrian

Re: [PATCH v9 02/11] Unify GUID types

On Wed, Sep 13, 2023 at 12:20 PM John Paul Adrian Glaubitz wrote: > > Hi Oliver! > > On Wed, 2023-09-13 at 12:14 +0200, Oliver Steffen wrote: > > On Wed, Sep 13, 2023 at 6:10 AM Pedro Miguel Justo wrote: > > > > > > > > > I can confirm that, taking [1][2] and making [3] on top of it, my > > > Mo

Re: [PATCH v9 02/11] Unify GUID types

On Wed, Sep 13, 2023 at 1:43 PM Ard Biesheuvel wrote: > > On Wed, 13 Sept 2023 at 13:42, Vladimir 'phcoder' Serbinenko > wrote: > > > > > > > > Le mer. 13 sept. 2023, 12:33, Ard Biesheuvel a écrit : > >> > >> On Wed, 13 Sept 2023 at 12:18, John Paul Adrian Glaubitz > >> wrote: > >> > > >> > Hi

Re: [PATCH v9 02/11] Unify GUID types

On Wed, 13 Sept 2023 at 13:42, Vladimir 'phcoder' Serbinenko wrote: > > > > Le mer. 13 sept. 2023, 12:33, Ard Biesheuvel a écrit : >> >> On Wed, 13 Sept 2023 at 12:18, John Paul Adrian Glaubitz >> wrote: >> > >> > Hi Oliver! >> > >> > On Wed, 2023-09-13 at 12:14 +0200, Oliver Steffen wrote: >> >

Re: [PATCH v9 02/11] Unify GUID types

Le mer. 13 sept. 2023, 12:33, Ard Biesheuvel a écrit : > On Wed, 13 Sept 2023 at 12:18, John Paul Adrian Glaubitz > wrote: > > > > Hi Oliver! > > > > On Wed, 2023-09-13 at 12:14 +0200, Oliver Steffen wrote: > > > On Wed, Sep 13, 2023 at 6:10 AM Pedro Miguel Justo > wrote: > > > > > > > > > > >

Re: [PATCH v9 02/11] Unify GUID types

On Wed, 13 Sept 2023 at 12:18, John Paul Adrian Glaubitz wrote: > > Hi Oliver! > > On Wed, 2023-09-13 at 12:14 +0200, Oliver Steffen wrote: > > On Wed, Sep 13, 2023 at 6:10 AM Pedro Miguel Justo wrote: > > > > > > > > > I can confirm that, taking [1][2] and making [3] on top of it, my > > > Mont

Re: [PATCH v9 02/11] Unify GUID types

Hi Oliver! On Wed, 2023-09-13 at 12:14 +0200, Oliver Steffen wrote: > On Wed, Sep 13, 2023 at 6:10 AM Pedro Miguel Justo wrote: > > > > > > I can confirm that, taking [1][2] and making [3] on top of it, my > > Montvale-based rx2660 machine still boots fine. > > Wonderful! Thanks for testing!

Re: [PATCH v9 02/11] Unify GUID types

On Wed, Sep 13, 2023 at 6:10 AM Pedro Miguel Justo wrote: > > > I can confirm that, taking [1][2] and making [3] on top of it, my > Montvale-based rx2660 machine still boots fine. Wonderful! Thanks for testing! Oliver > > [1] - https://github.com/phcoder/GRUB.git > [2] - cfa21b94e > [3] : > >

Re: [PATCH v9 02/11] Unify GUID types

I can confirm that, taking [1][2] and making [3] on top of it, my Montvale-based rx2660 machine still boots fine. [1] - https://github.com/phcoder/GRUB.git [2] - cfa21b94e [3] : diff --git a/include/grub/gpt_partition.h b/include/grub/gpt_partition.h index 3c70b148d..bddf832fa 100644 --- a/incl

Re: [PATCH v9 02/11] Unify GUID types

Hi Pedro! On Fri, 2023-09-08 at 03:24 +, Pedro Miguel Justo wrote: > > > On Sep 7, 2023, at 13:02, Daniel Kiper wrote: > > > > Pedro, Adrian, ping? > > Just to be overzealous and incredibly dense, here is my full understanding of > what is being asked to test: > > 1) Take the payload tha

Re: [PATCH v9 02/11] Unify GUID types

> On Sep 7, 2023, at 13:02, Daniel Kiper wrote: > > Pedro, Adrian, ping? Just to be overzealous and incredibly dense, here is my full understanding of what is being asked to test: 1) Take the payload that was tested before in [1][2] 2) Replace the 2 `__attribute__ ((aligned(8)))` that were a

Re: [PATCH v9 02/11] Unify GUID types

On Thu, 2023-09-07 at 22:02 +0200, Daniel Kiper wrote: > On Wed, Aug 30, 2023 at 10:53:47PM +, Pedro Miguel Justo wrote: > > > On Aug 30, 2023, at 09:20, John Paul Adrian Glaubitz > > > wrote: > > > On Wed, 2023-08-30 at 16:16 +0200, Daniel Kiper wrote: > > > > On Fri, Aug 25, 2023 at 05:50:5

Re: [PATCH v9 02/11] Unify GUID types

On Wed, Aug 30, 2023 at 10:53:47PM +, Pedro Miguel Justo wrote: > > On Aug 30, 2023, at 09:20, John Paul Adrian Glaubitz > > wrote: > > On Wed, 2023-08-30 at 16:16 +0200, Daniel Kiper wrote: > >> On Fri, Aug 25, 2023 at 05:50:58AM -0700, Oliver Steffen wrote: > >> > >> Yes, that would be perf

Re: [PATCH v9 02/11] Unify GUID types

On Wed, 30 Aug 2023 at 21:07, Vladimir 'phcoder' Serbinenko wrote: > > > > Le mer. 30 août 2023, 16:38, Daniel Kiper a écrit : >> >> On Wed, Aug 30, 2023 at 04:23:36PM +0200, Ard Biesheuvel wrote: >> > On Wed, 30 Aug 2023 at 16:18, Daniel Kiper wrote: >> > > >> > > On Fri, Aug 25, 2023 at 05:50:

Re: [PATCH v9 02/11] Unify GUID types

> On Aug 30, 2023, at 09:20, John Paul Adrian Glaubitz > wrote: > > On Wed, 2023-08-30 at 16:16 +0200, Daniel Kiper wrote: >> On Fri, Aug 25, 2023 at 05:50:58AM -0700, Oliver Steffen wrote: >> >> Yes, that would be perfect. If Itanium works then I suggest to align >> GUIDs to 4 bytes. This al

Re: [PATCH v9 02/11] Unify GUID types

Le mer. 30 août 2023, 16:38, Daniel Kiper a écrit : > On Wed, Aug 30, 2023 at 04:23:36PM +0200, Ard Biesheuvel wrote: > > On Wed, 30 Aug 2023 at 16:18, Daniel Kiper wrote: > > > > > > On Fri, Aug 25, 2023 at 05:50:58AM -0700, Oliver Steffen wrote: > > > > Quoting Vladimir 'phcoder' Serbinenko (2

Re: [PATCH v9 02/11] Unify GUID types

On Wed, 2023-08-30 at 16:16 +0200, Daniel Kiper wrote: > On Fri, Aug 25, 2023 at 05:50:58AM -0700, Oliver Steffen wrote: > > Quoting Vladimir 'phcoder' Serbinenko (2023-08-15 18:14:11) > > [...] > > > I am not sure what the best way forward is now, but we at least have the > > patches from Vladim

Re: [PATCH v9 02/11] Unify GUID types

On Wed, Aug 30, 2023 at 04:23:36PM +0200, Ard Biesheuvel wrote: > On Wed, 30 Aug 2023 at 16:18, Daniel Kiper wrote: > > > > On Fri, Aug 25, 2023 at 05:50:58AM -0700, Oliver Steffen wrote: > > > Quoting Vladimir 'phcoder' Serbinenko (2023-08-15 18:14:11) > > > > [...] > > > > > I am not sure what t

Re: [PATCH v9 02/11] Unify GUID types

On Wed, 30 Aug 2023 at 16:18, Daniel Kiper wrote: > > On Fri, Aug 25, 2023 at 05:50:58AM -0700, Oliver Steffen wrote: > > Quoting Vladimir 'phcoder' Serbinenko (2023-08-15 18:14:11) > > [...] > > > I am not sure what the best way forward is now, but we at least have the > > patches from Vladimir (

Re: [PATCH v9 02/11] Unify GUID types

On Fri, Aug 25, 2023 at 05:50:58AM -0700, Oliver Steffen wrote: > Quoting Vladimir 'phcoder' Serbinenko (2023-08-15 18:14:11) [...] > I am not sure what the best way forward is now, but we at least have the > patches from Vladimir (thanks!). > > Pedro, Adrian, could you - if you get a chance - tr

Re: [PATCH v9 02/11] Unify GUID types

Quoting Vladimir 'phcoder' Serbinenko (2023-08-15 18:14:11) > > > Le mar. 15 août 2023, 14:00, Laszlo Ersek <[1]ler...@redhat.com> a écrit : > > On 8/15/23 10:17, Ard Biesheuvel wrote: > > On Tue, 15 Aug 2023 at 05:42, Vladimir 'phcoder' Serbinenko > > <[2]phco...@gmail.com> wrote: >

Re: [PATCH v9 02/11] Unify GUID types

Le mar. 15 août 2023, 14:00, Laszlo Ersek a écrit : > On 8/15/23 10:17, Ard Biesheuvel wrote: > > On Tue, 15 Aug 2023 at 05:42, Vladimir 'phcoder' Serbinenko > > wrote: > >>> > >>> . > >>> > >>> Ard thinks that a 64 bit alignment for EFI GUIDs is a mistake - see [1] > >>> and [2]. Hence Linux us

Re: [PATCH v9 02/11] Unify GUID types

On 8/15/23 10:17, Ard Biesheuvel wrote: > On Tue, 15 Aug 2023 at 05:42, Vladimir 'phcoder' Serbinenko > wrote: >>> >>> . >>> >>> Ard thinks that a 64 bit alignment for EFI GUIDs is a mistake - see [1] >>> and [2]. Hence Linux uses `__aligned(__alignof__(u32))` for "efi_guid_t" >>> since 2019. >> >

Re: [PATCH v9 02/11] Unify GUID types

On Tue, 15 Aug 2023 at 05:42, Vladimir 'phcoder' Serbinenko wrote: >> >> . >> >> Ard thinks that a 64 bit alignment for EFI GUIDs is a mistake - see [1] >> and [2]. Hence Linux uses `__aligned(__alignof__(u32))` for "efi_guid_t" >> since 2019. > > > My patch presents a reliability paradigm: accept

Re: [PATCH v9 02/11] Unify GUID types

> > . > > Ard thinks that a 64 bit alignment for EFI GUIDs is a mistake - see [1] > and [2]. Hence Linux uses `__aligned(__alignof__(u32))` for "efi_guid_t" > since 2019. > My patch presents a reliability paradigm: accept all inputs, produce outputs that are always aligned to 8-byte. It can make s

Re: [PATCH v9 02/11] Unify GUID types

Quoting Vladimir 'phcoder' Serbinenko (2023-08-14 13:56:31) I uploaded the entire branch (patches) to my GitHub copy: [1]https://github.com/phcoder/GRUB/tree/rb1 Vladimir, I can confirm that, with the code presently in this branch, my Itanium system boots fine. The regressi

Re: [PATCH v9 02/11] Unify GUID types

> On Aug 14, 2023, at 21:38, Frank Scheiner wrote: > > Hi Steffen, Ard, > >> On 14.08.23 21:59, Oliver Steffen wrote: >> Quoting Vladimir 'phcoder' Serbinenko (2023-08-13 09:46:45) >>> Full analysis: gpt_partentry can be marked as aligned8. But following are >>> problem: >>> * protocols_per_h

Re: [PATCH v9 02/11] Unify GUID types

Hi Steffen, Ard, On 14.08.23 21:59, Oliver Steffen wrote: Quoting Vladimir 'phcoder' Serbinenko (2023-08-13 09:46:45) Full analysis: gpt_partentry can be marked as aligned8. But following are problem: * protocols_per_handle may return unaligned guids * configuration_tables array may be unaligne

Re: [PATCH v9 02/11] Unify GUID types

Quoting Vladimir 'phcoder' Serbinenko (2023-08-13 09:46:45) > Full analysis: gpt_partentry can be marked as aligned8. But following are > problem: > * protocols_per_handle may return unaligned guids > * configuration_tables array may be unaligned. On efi32 every entry is 20 > bytes, so guids can't

Re: [PATCH v9 02/11] Unify GUID types

Hi Pedro! On Mon, 2023-08-14 at 14:33 +, Pedro Miguel Justo wrote: > en I try to build from your branch, I eventually get this error: > > ``` > done > mv syminfo.lst.new syminfo.lst > cat syminfo.lst | sort | mawk -f ./genmoddep.awk > moddep.lst || (rm -f > moddep.lst; exit 1) > mawk: ./genm

Re: [PATCH v9 02/11] Unify GUID types

> On Aug 14, 2023, at 05:47, Oliver Steffen wrote: > > Quoting Vladimir 'phcoder' Serbinenko (2023-08-14 13:56:31) >> I uploaded the entire branch (patches) to my GitHub copy: >> [1]https://github.com >> /phcoder/GRUB/tree/rb1 Hi Vladimir. When I try to build from your branch, I eventually

Re: [PATCH v9 02/11] Unify GUID types

Quoting Vladimir 'phcoder' Serbinenko (2023-08-14 13:56:31) > I uploaded the entire branch (patches) to my GitHub copy:  > [1]https://github.com > /phcoder/GRUB/tree/rb1 87532c5b Deduplicate configuration table search function is the reason for the rejection. Thanks, Vladimir! -Oliver > > Le lu

Re: [PATCH v9 02/11] Unify GUID types

Perfect! Thank you. On Aug 14, 2023, at 12:56, Vladimir 'phcoder' Serbinenko wrote:  I uploaded the entire branch (patches) to my GitHub copy: https://github.com/phcoder/GRUB/tree/rb1 Le lun. 14 août 2023, 13:07, Pedro Miguel Justo mailto:pm...@texair.net>> a écrit : Hi Vladimir. I got a

Re: [PATCH v9 02/11] Unify GUID types

I uploaded the entire branch (patches) to my GitHub copy: https://github.com/phcoder/GRUB/tree/rb1 Le lun. 14 août 2023, 13:07, Pedro Miguel Justo a écrit : > > Hi Vladimir. > > I got a conplict while applying 0003. Out of expedience, instead of me > trying to resolve the conflict, can you just

Re: [PATCH v9 02/11] Unify GUID types

Hi Vladimir. I got a conplict while applying 0003. Out of expedience, instead of me trying to resolve the conflict, can you just share your baseline commit# over which these will apply cleanly? ``` pmsjt@itanium:~/grub$ patch -p1 < ../0001-Add-missing-static-qualifier.patch patching file grub-

Re: [PATCH v9 02/11] Unify GUID types

Hi Vladimir. Thanks for the analysis and for providing the candidate patches. I'll be away from my computer for a couple of days but will give it a try as soon as I can find a sliver of time. Pedro On Aug 13, 2023, at 08:47, Vladimir 'phcoder' Serbinenko wrote:  Full analysis: gpt_partentr

Re: [PATCH v9 02/11] Unify GUID types

Full analysis: gpt_partentry can be marked as aligned8. But following are problem: * protocols_per_handle may return unaligned guids * configuration_tables array may be unaligned. On efi32 every entry is 20 bytes, so guids can't be 8-byte aligned * The worst offender is device path as it's packed,

Re: [PATCH v9 02/11] Unify GUID types

Le dim. 13 août 2023, 00:57, Pedro Miguel Justo a écrit : > > > > On Aug 12, 2023, at 11:04, John Paul Adrian Glaubitz < > glaub...@physik.fu-berlin.de> wrote: > > > > Hi Daniel! > > > > On Fri, 2023-08-11 at 17:31 +0200, Daniel Kiper wrote: > >> On Fri, Aug 11, 2023 at 04:10:14AM -0700, Oliver S

Re: [PATCH v9 02/11] Unify GUID types

> On Aug 12, 2023, at 11:04, John Paul Adrian Glaubitz > wrote: > > Hi Daniel! > > On Fri, 2023-08-11 at 17:31 +0200, Daniel Kiper wrote: >> On Fri, Aug 11, 2023 at 04:10:14AM -0700, Oliver Steffen wrote: >>> Quoting John Paul Adrian Glaubitz (2023-08-11 10:32:17) Hi Oliver! O

Re: [PATCH v9 02/11] Unify GUID types

Hi Daniel! On Fri, 2023-08-11 at 17:31 +0200, Daniel Kiper wrote: > On Fri, Aug 11, 2023 at 04:10:14AM -0700, Oliver Steffen wrote: > > Quoting John Paul Adrian Glaubitz (2023-08-11 10:32:17) > > > Hi Oliver! > > > > > > On Fri, 2023-05-26 at 13:35 +0200, Oliver Steffen wrote: > > > > There are 3

Re: [PATCH v9 02/11] Unify GUID types

On Fri, Aug 11, 2023 at 04:10:14AM -0700, Oliver Steffen wrote: > Quoting John Paul Adrian Glaubitz (2023-08-11 10:32:17) > > Hi Oliver! > > > > On Fri, 2023-05-26 at 13:35 +0200, Oliver Steffen wrote: > > > There are 3 implementations of a GUID in Grub. Replace them with a > > > common one, placed

Re: [PATCH v9 02/11] Unify GUID types

Quoting John Paul Adrian Glaubitz (2023-08-11 10:32:17) > Hi Oliver! > > On Fri, 2023-05-26 at 13:35 +0200, Oliver Steffen wrote: > > There are 3 implementations of a GUID in Grub. Replace them with a > > common one, placed in types.h. > > > > It uses the "packed" flavor of the GUID structs, the al

Re: [PATCH v9 02/11] Unify GUID types

Hi Oliver! On Fri, 2023-05-26 at 13:35 +0200, Oliver Steffen wrote: > There are 3 implementations of a GUID in Grub. Replace them with a > common one, placed in types.h. > > It uses the "packed" flavor of the GUID structs, the alignment attribute > is dropped, since it is not required. > > Signe