On Wed, Sep 13, 2023 at 6:10 AM Pedro Miguel Justo <pm...@texair.net> wrote: > > > I can confirm that, taking [1][2] and making [3] on top of it, my > Montvale-based rx2660 machine still boots fine.
Wonderful! Thanks for testing! Oliver > > [1] - https://github.com/phcoder/GRUB.git > [2] - cfa21b94e > [3] : > > diff --git a/include/grub/gpt_partition.h b/include/grub/gpt_partition.h > index 3c70b148d..bddf832fa 100644 > --- a/include/grub/gpt_partition.h > +++ b/include/grub/gpt_partition.h > @@ -74,7 +74,7 @@ struct grub_gpt_partentry > grub_uint64_t end; > grub_uint64_t attrib; > char name[72]; > -} __attribute__((aligned(8))); > +} __attribute__((aligned(4))); > grub_err_t > grub_gpt_partition_map_iterate (grub_disk_t disk, > diff --git a/include/grub/types.h b/include/grub/types.h > index c31c707e3..7d161e59f 100644 > --- a/include/grub/types.h > +++ b/include/grub/types.h > @@ -376,7 +376,7 @@ struct grub_guid > grub_uint16_t data2; > grub_uint16_t data3; > grub_uint8_t data4[8]; > -} __attribute__ ((aligned(8))); > +} __attribute__ ((aligned(4))); > typedef struct grub_guid grub_guid_t; > struct grub_packed_guid > > > > > > On Sep 8, 2023, at 00:14, John Paul Adrian Glaubitz > > <glaub...@physik.fu-berlin.de> wrote: > > > > Hi Pedro! > > > > On Fri, 2023-09-08 at 03:24 +0000, Pedro Miguel Justo wrote: > >> > >>> On Sep 7, 2023, at 13:02, Daniel Kiper <dki...@net-space.pl> wrote: > >>> > >>> Pedro, Adrian, ping? > >> > >> Just to be overzealous and incredibly dense, here is my full understanding > >> of what is being asked to test: > >> > >> 1) Take the payload that was tested before in [1][2] > >> 2) Replace the 2 `__attribute__ ((aligned(8)))` that were added commits > >> [3] and [4] with `__attribute__ ((aligned(4)))` > >> 3) See if it still works > >> > >> Correct? > > > > I would very much appreciate if you could test this particular change so > > that > > I don't have to hook up my RX2600 which is currently stored under my sofa > > ;-). > > > > Adrian > > > > -- > > .''`. John Paul Adrian Glaubitz > > : :' : Debian Developer > > `. `' Physicist > > `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 > > > > _______________________________________________ > > Grub-devel mailing list > > Grub-devel@gnu.org > > https://lists.gnu.org/mailman/listinfo/grub-devel > _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
