Re: [PATCH v3 3/9] luks2: Fix use of incorrect index and some error messages

2020-09-21 Thread Daniel Kiper
On Mon, Sep 21, 2020 at 06:45:04AM +, Glenn Washburn wrote: > Sep 8, 2020 6:58:48 AM Daniel Kiper : > > On Mon, Sep 07, 2020 at 05:27:41PM +0200, Patrick Steinhardt wrote: > >> From: Glenn Washburn > > > > It seems to me this patch should be split into two and and begs for > > commit message i

Re: [PATCH v3 3/9] luks2: Fix use of incorrect index and some error messages

2020-09-20 Thread Glenn Washburn
Sep 8, 2020 6:58:48 AM Daniel Kiper : > On Mon, Sep 07, 2020 at 05:27:41PM +0200, Patrick Steinhardt wrote: >> From: Glenn Washburn > > It seems to me this patch should be split into two and and begs for > commit message improvement. In general it would be nice to know why > we need these fixes.

Re: [PATCH v3 3/9] luks2: Fix use of incorrect index and some error messages

2020-09-08 Thread Daniel Kiper
On Mon, Sep 07, 2020 at 05:27:41PM +0200, Patrick Steinhardt wrote: > From: Glenn Washburn It seems to me this patch should be split into two and and begs for commit message improvement. In general it would be nice to know why we need these fixes. Daniel