Re: [PATCH 3/4] luks2: set up dummy sector size during scan

2022-05-21 Thread Fabian Vogt
Hi, Am Samstag, 21. Mai 2022, 02:13:53 CEST schrieb Glenn Washburn: > On Mon, 07 Feb 2022 14:15:07 +0100 > Josselin Poiret via Grub-devel wrote: > > > Hi Fabian, > > > > Fabian Vogt writes: > > > > > Did you have a look at my approach? That effectively does the same, but > > > using a > > >

Re: [PATCH 3/4] luks2: set up dummy sector size during scan

2022-05-20 Thread Glenn Washburn
On Mon, 07 Feb 2022 14:15:07 +0100 Josselin Poiret via Grub-devel wrote: > Hi Fabian, > > Fabian Vogt writes: > > > Did you have a look at my approach? That effectively does the same, but > > using a > > single ioctl instead of anything complex with DM directly. I skipped this thread because

Re: [PATCH 3/4] luks2: set up dummy sector size during scan

2022-02-07 Thread Josselin Poiret via Grub-devel
Hi Fabian, Fabian Vogt writes: > Did you have a look at my approach? That effectively does the same, but using > a > single ioctl instead of anything complex with DM directly. I agree that it's sufficient for sector_size, but we still need the cryptodisk algorithm so that grub-install will kno

Re: [PATCH 3/4] luks2: set up dummy sector size during scan

2022-02-04 Thread Fabian Vogt
Hi, Am Mittwoch, 22. Dezember 2021, 19:17:37 CET schrieb Josselin Poiret via Grub-devel: > Hello everyone, > > Fabian Vogt writes: > > It looks like we have a third patch (series) for this feature meanwhile: > > [PATCH 0/2] Have LUKS2 cryptomounts be useable with grub-probe > > > > I CC'd the a

Re: [PATCH 3/4] luks2: set up dummy sector size during scan

2021-12-22 Thread Josselin Poiret via Grub-devel
Hello everyone, Fabian Vogt writes: > It looks like we have a third patch (series) for this feature meanwhile: > [PATCH 0/2] Have LUKS2 cryptomounts be useable with grub-probe > > I CC'd the author, let's try to coordinate. > > Thanks, > Fabian Let me just say that I had not found this patch ser

Re: [PATCH 3/4] luks2: set up dummy sector size during scan

2021-12-16 Thread Fabian Vogt
Hi, (I *finally* got to this topic again...) Am Sonntag, 8. August 2021, 16:20:12 CET schrieb Patrick Steinhardt: > On Fri, Aug 06, 2021 at 12:51:10PM +0800, Michael Chang via Grub-devel wrote: > [snip] > > diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c > > index 90f82b2d3

Re: [PATCH 3/4] luks2: set up dummy sector size during scan

2021-08-08 Thread Patrick Steinhardt
On Fri, Aug 06, 2021 at 12:51:10PM +0800, Michael Chang via Grub-devel wrote: [snip] > diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c > index 90f82b2d3..c2bb2b6eb 100644 > --- a/grub-core/disk/cryptodisk.c > +++ b/grub-core/disk/cryptodisk.c > @@ -1040,6 +1040,7 @@ grub_cryp

Re: [PATCH 3/4] luks2: set up dummy sector size during scan

2021-08-05 Thread Michael Chang via Grub-devel
Hi, Enclosed herewith please find the revised patch from openSUSE that could also fix this very same problem. According to Fabian, the author of this patch, the reason for having this patch is that he found some problem in the posted one. I have added him to the CC list so that he could provide m