Hi Fabian,

Fabian Vogt <fv...@suse.de> writes:

> Did you have a look at my approach? That effectively does the same, but using 
> a
> single ioctl instead of anything complex with DM directly.

I agree that it's sufficient for sector_size, but we still need the
cryptodisk algorithm so that grub-install will know which crypto modules
to include.  libdm is actually a helper library around dm-specific
ioctls, since they are apparently annoying to use, so in the end we're
still using the same interface :)

As for the 4 patches, since the actual sector_size is available to us, I
think using 512 in all cases or adding a specific 0 sector_size is
something we should avoid.

Best,
-- 
Josselin Poiret

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to