Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired

2021-05-03 Thread Javier Martinez Canillas
Hello Daniel, On 4/29/21 4:32 PM, Daniel Kiper wrote: > On Thu, Apr 29, 2021 at 11:05:20AM +0200, Carlos Maiolino wrote: >> On Thu, Apr 22, 2021 at 05:15:31PM +0200, Javier Martinez Canillas wrote: >>> Hello Vladimir, >>> >>> On 4/22/21 4:56 PM, Vladimir 'phcoder' Serbinenko wrote: Filesystem

Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired

2021-04-29 Thread Daniel Kiper
On Thu, Apr 29, 2021 at 11:05:20AM +0200, Carlos Maiolino wrote: > On Thu, Apr 22, 2021 at 05:15:31PM +0200, Javier Martinez Canillas wrote: > > Hello Vladimir, > > > > On 4/22/21 4:56 PM, Vladimir 'phcoder' Serbinenko wrote: > > > Filesystems are not mounted in GRUB. This patch will result in GRUB

Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired

2021-04-29 Thread Carlos Maiolino
On Thu, Apr 22, 2021 at 05:15:31PM +0200, Javier Martinez Canillas wrote: > Hello Vladimir, > > On 4/22/21 4:56 PM, Vladimir 'phcoder' Serbinenko wrote: > > Filesystems are not mounted in GRUB. This patch will result in GRUB > > outputting a warning on every access to any XFS that has this flag se

Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired

2021-04-22 Thread Javier Martinez Canillas
Hello Vladimir, On 4/22/21 4:56 PM, Vladimir 'phcoder' Serbinenko wrote: > Filesystems are not mounted in GRUB. This patch will result in GRUB > outputting a warning on every access to any XFS that has this flag set, > even if it is not related to further booting. It will create an excessive > noi

Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired

2021-04-22 Thread Vladimir 'phcoder' Serbinenko
Filesystems are not mounted in GRUB. This patch will result in GRUB outputting a warning on every access to any XFS that has this flag set, even if it is not related to further booting. It will create an excessive noise. FS drivers shouldn't print anything except dprintf's Le lun. 19 avr. 2021 à 1

Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired

2021-04-22 Thread Daniel Kiper
On Thu, Apr 22, 2021 at 12:15:18PM +0200, Javier Martinez Canillas wrote: > On 4/22/21 11:20 AM, Carlos Maiolino wrote: > > Hi Daniel > > > >>> --- a/grub-core/fs/xfs.c > >>> +++ b/grub-core/fs/xfs.c > >>> @@ -79,6 +79,7 @@ GRUB_MOD_LICENSE ("GPLv3+"); > >>> #define XFS_SB_FEAT_INCOMPAT_FTYPE

Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired

2021-04-22 Thread Javier Martinez Canillas
On 4/22/21 11:20 AM, Carlos Maiolino wrote: > Hi Daniel > >>> --- a/grub-core/fs/xfs.c >>> +++ b/grub-core/fs/xfs.c >>> @@ -79,6 +79,7 @@ GRUB_MOD_LICENSE ("GPLv3+"); >>> #define XFS_SB_FEAT_INCOMPAT_FTYPE (1 << 0)/* filetype in >>> dirent */ >>> #define XFS_SB_FEAT_INCOMPAT_SPINOD

Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired

2021-04-22 Thread Carlos Maiolino
Hi Daniel > > --- a/grub-core/fs/xfs.c > > +++ b/grub-core/fs/xfs.c > > @@ -79,6 +79,7 @@ GRUB_MOD_LICENSE ("GPLv3+"); > > #define XFS_SB_FEAT_INCOMPAT_FTYPE (1 << 0)/* filetype in > > dirent */ > > #define XFS_SB_FEAT_INCOMPAT_SPINODES (1 << 1)/* sparse inode > > chunks

Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired

2021-04-20 Thread Daniel Kiper
On Mon, Apr 19, 2021 at 05:16:50PM +0200, Javier Martinez Canillas wrote: > XFS now has an incompat feature flag to indicate that the filesystem needs > to be repaired. The Linux kernel refuses to mount a filesystem that has it > set and only the xfs_repair tool is able to clear that flag. > > One

Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired

2021-04-20 Thread Carlos Maiolino
> Suggested-by: Eric Sandeen > Signed-off-by: Javier Martinez Canillas > --- > > grub-core/fs/xfs.c | 16 > 1 file changed, 16 insertions(+) > > diff --git a/grub-core/fs/xfs.c b/grub-core/fs/xfs.c > index 43023e03fb3..22e7e61d574 100644 > --- a/grub-core/fs/xfs.c > +++ b/grub