Re: [PATCH] parttool

2009-04-25 Thread Vladimir Serbinenko
committed On Fri, Apr 17, 2009 at 1:12 PM, phcoder wrote: > Thank you for the testing > >> Please remove one space after "list". >> > done > >> >> I've tested the command quickly. A few notes. >> >> We need a command to list the partition table, as "ls" doesn't show the >> partition types. >> >

Re: [PATCH] parttool

2009-04-17 Thread phcoder
Thank you for the testing Please remove one space after "list". done I've tested the command quickly. A few notes. We need a command to list the partition table, as "ls" doesn't show the partition types. The easiest way is to add an info string to partmap structure. This, however pollutes t

Re: [PATCH] parttool

2009-04-08 Thread Pavel Roskin
On Wed, 2009-04-08 at 11:35 +0200, phcoder wrote: > Is this what you mean? Yes. > +static char helpmsg[] = > + "perform COMMANDS on partition.\n" > + "Use \"parttool PARTITION help\" for the list " > + " of available commands"; Please remove one space after "list". I've tested the command qu

Re: [PATCH] parttool

2009-04-08 Thread phcoder
Is this what you mean? Pavel Roskin wrote: On Mon, 2009-04-06 at 18:25 +0200, phcoder wrote: The problem is that the exact available options depend on partition type so you have to specify parttool help Unfortunately for now you have to load the module pcpart.mod manually. I'll fix this prob

Re: [PATCH] parttool

2009-04-06 Thread Pavel Roskin
On Mon, 2009-04-06 at 18:25 +0200, phcoder wrote: > The problem is that the exact available options depend on partition type > so you have to specify > parttool help > Unfortunately for now you have to load the module pcpart.mod manually. > I'll fix this problem by making parttool load the corr

Re: [PATCH] parttool

2009-04-06 Thread phcoder
Pavel Roskin wrote: On Mon, 2009-04-06 at 17:56 +0200, phcoder wrote: Pavel Roskin wrote: On Mon, 2009-04-06 at 11:52 +0200, phcoder wrote: Fixed & commited. My next patch will be to add automatic module loading in parttool It would be great to make parttool actually give some usage informati

Re: [PATCH] parttool

2009-04-06 Thread Pavel Roskin
On Mon, 2009-04-06 at 17:56 +0200, phcoder wrote: > Pavel Roskin wrote: > > On Mon, 2009-04-06 at 11:52 +0200, phcoder wrote: > >> Fixed & commited. My next patch will be to add automatic module loading > >> in parttool > > > > It would be great to make parttool actually give some usage informati

Re: [PATCH] parttool

2009-04-06 Thread phcoder
Pavel Roskin wrote: On Mon, 2009-04-06 at 11:52 +0200, phcoder wrote: Fixed & commited. My next patch will be to add automatic module loading in parttool It would be great to make parttool actually give some usage information. Right now, there is no information at all. grub> parttool error: t

Re: [PATCH] parttool

2009-04-06 Thread Pavel Roskin
On Mon, 2009-04-06 at 11:52 +0200, phcoder wrote: > Fixed & commited. My next patch will be to add automatic module loading > in parttool It would be great to make parttool actually give some usage information. Right now, there is no information at all. grub> parttool error: too few arguments gr

Re: [PATCH] parttool

2009-04-06 Thread phcoder
Fixed & commited. My next patch will be to add automatic module loading in parttool Yoshinori K. Okuji wrote: On Saturday 04 April 2009 18:22:39 phcoder wrote: Can someone review this patch? Only some style should be corrected. For example: +#ifndef GRUB_UTIL + if (!parts) +grub_dl_unre

Re: [PATCH] parttool

2009-04-05 Thread Yoshinori K. Okuji
On Saturday 04 April 2009 18:22:39 phcoder wrote: > Can someone review this patch? Only some style should be corrected. For example: +#ifndef GRUB_UTIL + if (!parts) +grub_dl_unref (mymod); +#endif Our convention is to put a space between "!" and "parts", so this should be: +#ifndef GRUB_U

Re: [PATCH] parttool

2009-04-04 Thread phcoder
Can someone review this patch? phcoder wrote: Update phcoder wrote: Sorry I forgot include/grub/parttool.h phcoder wrote: Hello here is the implementation of parttool with the syntax I proposed earlier and equivalent of parttype, makeactive and hide/unhide -- Regards Vladimir 'phco

Re: [PATCH] parttool

2009-03-20 Thread phcoder
Update phcoder wrote: Sorry I forgot include/grub/parttool.h phcoder wrote: Hello here is the implementation of parttool with the syntax I proposed earlier and equivalent of parttype, makeactive and hide/unhide -- Regards Vladimir 'phcoder' Serbinenko diff --git a/ChangeLog b/ChangeLog

Re: [PATCH] parttool

2009-03-10 Thread phcoder
Sorry I forgot include/grub/parttool.h phcoder wrote: Hello here is the implementation of parttool with the syntax I proposed earlier and equivalent of parttype, makeactive and hide/unhide -- Regards Vladimir 'phcoder' Serbinenko /* * GRUB -- GRand Unified Bootloader * Copyright (C)