On Saturday 04 April 2009 18:22:39 phcoder wrote: > Can someone review this patch?
Only some style should be corrected. For example: +#ifndef GRUB_UTIL + if (!parts) + grub_dl_unref (mymod); +#endif Our convention is to put a space between "!" and "parts", so this should be: +#ifndef GRUB_UTIL + if (! parts) + grub_dl_unref (mymod); +#endif Also, the ChangeLog should state what variables are affected explicitly. For example: * conf/common.rmk: Added parttool.mod and pcpart.mod Instead, you should say: * conf/common.rmk (parttool_mod_SOURCES): New variable. (parttool_mod_CFLAGS): Likewise. (parttool_mod_LDFLAGS): Likewise. ...and so on... The code itself looks good, so you can check it in, once you correct the styles. Regards, Okuji _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
