Re: [PATCH] add true and false commands

Am Freitag, den 05.06.2009, 15:04 +0200 schrieb Felix Zielcke: > Am Freitag, den 05.06.2009, 14:26 +0200 schrieb Marco Gerards: > > Felix Zielcke writes: > > > > So what should I do now? > > > Placing it in normal.mod or minicmd.mod where it's included in rescue > > > mode or placing it into a tr

Re: [PATCH] add true and false commands

Am Freitag, den 05.06.2009, 15:29 +0200 schrieb Marco Gerards: > Oh, I didn't know minicmd.mod. Is it useful to have one instead of > a few separate modules? Space of these smaller modules is not really > a concern to me. Bean split the commands out from kernel. So especially help and lsmod are

Re: [PATCH] add true and false commands

Felix Zielcke writes: > Am Freitag, den 05.06.2009, 14:26 +0200 schrieb Marco Gerards: >> Felix Zielcke writes: > >> > So what should I do now? >> > Placing it in normal.mod or minicmd.mod where it's included in rescue >> > mode or placing it into a true.mod where the size increase would be >> >

Re: [PATCH] add true and false commands

Am Freitag, den 05.06.2009, 14:26 +0200 schrieb Marco Gerards: > Felix Zielcke writes: > > So what should I do now? > > Placing it in normal.mod or minicmd.mod where it's included in rescue > > mode or placing it into a true.mod where the size increase would be > > bigger? > > minicmd.mod is not

Re: [PATCH] add true and false commands

Felix Zielcke writes: > Am Freitag, den 05.06.2009, 12:00 +0200 schrieb Marco Gerards: >> Felix Zielcke writes: >> >> > Am Donnerstag, den 04.06.2009, 10:21 +0200 schrieb Marco Gerards: >> >> Felix Zielcke writes: >> >> >> >> > Am Montag, den 01.06.2009, 16:24 +0200 schrieb Vladimir 'phcoder'

Re: [PATCH] add true and false commands

Am Freitag, den 05.06.2009, 12:00 +0200 schrieb Marco Gerards: > Felix Zielcke writes: > > > Am Donnerstag, den 04.06.2009, 10:21 +0200 schrieb Marco Gerards: > >> Felix Zielcke writes: > >> > >> > Am Montag, den 01.06.2009, 16:24 +0200 schrieb Vladimir 'phcoder' > >> > Serbinenko: > >> >> Howe

Re: [PATCH] add true and false commands

Felix Zielcke writes: > Am Donnerstag, den 04.06.2009, 10:21 +0200 schrieb Marco Gerards: >> Felix Zielcke writes: >> >> > Am Montag, den 01.06.2009, 16:24 +0200 schrieb Vladimir 'phcoder' >> > Serbinenko: >> >> However convention for >> >> creating false is: >> >> return grub_error (GRUB_ERR

Re: [PATCH] add true and false commands

Am Donnerstag, den 04.06.2009, 10:21 +0200 schrieb Marco Gerards: > Felix Zielcke writes: > > > Am Montag, den 01.06.2009, 16:24 +0200 schrieb Vladimir 'phcoder' > > Serbinenko: > >> However convention for > >> creating false is: > >> return grub_error (GRUB_ERR_TEST_FAILURE, "false"); > >> and

Re: [PATCH] add true and false commands

Felix Zielcke writes: > Am Montag, den 01.06.2009, 16:24 +0200 schrieb Vladimir 'phcoder' > Serbinenko: >> However convention for >> creating false is: >> return grub_error (GRUB_ERR_TEST_FAILURE, "false"); >> and not >> return 1; > > Ok changed it. If everyone is fine with placing this in no

Re: [PATCH] add true and false commands

Am Montag, den 01.06.2009, 16:24 +0200 schrieb Vladimir 'phcoder' Serbinenko: > However convention for > creating false is: > return grub_error (GRUB_ERR_TEST_FAILURE, "false"); > and not > return 1; Ok changed it. If everyone is fine with placing this in normal/main.c, I commit it. -- Felix

Re: [PATCH] add true and false commands

On Mon, Jun 1, 2009 at 4:18 PM, Felix Zielcke wrote: > Am Samstag, den 30.05.2009, 17:14 +0200 schrieb Vladimir 'phcoder' > Serbinenko: >> On Wed, May 27, 2009 at 2:16 PM, Felix Zielcke wrote: >> > Hi, >> > >> > here's a simple patch which adds a `true' and a `false' command. >> > `true' is actua

Re: [PATCH] add true and false commands

Am Samstag, den 30.05.2009, 17:14 +0200 schrieb Vladimir 'phcoder' Serbinenko: > On Wed, May 27, 2009 at 2:16 PM, Felix Zielcke wrote: > > Hi, > > > > here's a simple patch which adds a `true' and a `false' command. > > `true' is actually needed by the compatibility code generated by > > grub-mkco

Re: [PATCH] add true and false commands

On Wed, May 27, 2009 at 2:16 PM, Felix Zielcke wrote: > Hi, > > here's a simple patch which adds a `true' and a `false' command. > `true' is actually needed by the compatibility code generated by > grub-mkconfig for the terminal. As far as I understand they are useful only in normal mode. Perhaps