Re: [PATCH] Support FreeBSD in osdetect.lua

2009-07-25 Thread Vladimir 'phcoder' Serbinenko
>> LUA will probably be important for graphics. > > It can be useful, yes, but not essential.  Native scripting should continue > to be supported, since the whole grub-mkconfig stack relies on it. Yes, but graphics itself isn't essential either. And I also agree that sh should be privelegied. But s

Re: [PATCH] Support FreeBSD in osdetect.lua

2009-07-25 Thread Robert Millan
On Wed, Jul 22, 2009 at 08:02:02PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > I think we should contemplate to put LUA scripting in grub-extras too.  Like > > other components of grub-extras, we don't have copyright assignment for it, > > so it would fit well the purpose of grub-extras.  This

Re: [PATCH] Support FreeBSD in osdetect.lua

2009-07-22 Thread Vladimir 'phcoder' Serbinenko
> Well, this gets a bit more complicated.  grub-extras is not part of GNU GRUB, > but osdetect.lua is (currently).  I'm not sure if we should make GRUB > components depend on grub-extras this way (I think this is Pavel's point). Well this part is just inactive if zfs.mod isn't present > > I think w

Re: [PATCH] Support FreeBSD in osdetect.lua

2009-07-22 Thread Robert Millan
On Tue, Jul 21, 2009 at 11:50:12PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > > > Obviously, the zfs part shouldn't go in yet. > > > We discussed with Robert Millan the issue and decided that zfs.mod > will go to grub-extras. Just I had no time to upload it yet. As zfs > part of osdetect.lua i

Re: [PATCH] Support FreeBSD in osdetect.lua

2009-07-21 Thread Vladimir 'phcoder' Serbinenko
>> We put it into our repository this means that we accept improvements. >> I also think that there will be distributions similar to Super GRUB >> Disk and other recovery tools based on osdetect.lua. Unless we provide >> a good reference osdetect.lua there will be a bitrot between such >> distribut

Re: [PATCH] Support FreeBSD in osdetect.lua

2009-07-21 Thread Pavel Roskin
On Tue, 2009-07-21 at 22:17 +0200, Vladimir 'phcoder' Serbinenko wrote: > Actually this menu is done to match the default one of FreeBSD loader. > I'm not a FreeBSD expert so I prefered to stick to the same menu as > default bootloader. I see. > > The implementation could remove the original men

Re: [PATCH] Support FreeBSD in osdetect.lua

2009-07-21 Thread Vladimir 'phcoder' Serbinenko
On Tue, Jul 21, 2009 at 6:02 PM, Pavel Roskin wrote: > On Tue, 2009-07-21 at 15:45 +0200, Vladimir 'phcoder' Serbinenko wrote: >> Support FreeBSD on both UFS and ZFS. Requires my zfs.mod for zfs and >> my ufs uuid patch for UFS > >> +     grub.add_menu (header .. normal .. footer, title) >> +     g

Re: [PATCH] Support FreeBSD in osdetect.lua

2009-07-21 Thread Pavel Roskin
On Tue, 2009-07-21 at 15:45 +0200, Vladimir 'phcoder' Serbinenko wrote: > Support FreeBSD on both UFS and ZFS. Requires my zfs.mod for zfs and > my ufs uuid patch for UFS > + grub.add_menu (header .. normal .. footer, title) > + grub.add_menu (header .. " single" .. normal .. footer, > +