On Tue, Jul 21, 2009 at 6:02 PM, Pavel Roskin<pro...@gnu.org> wrote: > On Tue, 2009-07-21 at 15:45 +0200, Vladimir 'phcoder' Serbinenko wrote: >> Support FreeBSD on both UFS and ZFS. Requires my zfs.mod for zfs and >> my ufs uuid patch for UFS > >> + grub.add_menu (header .. normal .. footer, title) >> + grub.add_menu (header .. " single" .. normal .. footer, >> + title .. " (single)") >> + grub.add_menu (header .. " verbose" .. normal .. footer, >> + title .. " (verbose)") >> + grub.add_menu (header .. noacpi .. footer, >> + title .. " (without ACPI)") >> + grub.add_menu (header .. noacpi .. safe .. footer, >> + title .. " (safe mode)") > > I hate to be "Mister No", but I think this change is not suitable for > the generic osdetect.lua. Most users don't have problems with FreeBSD > not working on their hardware. Getting five menu entries for different > options is too much. It may be OK for a FreeBSD installer, but not for > the generic script that also detects other OSes. > > A reasonable middle ground would be to have one entry called "safe mode" > to would lead to a menu offering single mode, disabling ACPI, disabling > whatever else is potentially problematic. I think all entries under > "safe mode" can enable extra verbosity. > Actually this menu is done to match the default one of FreeBSD loader. I'm not a FreeBSD expert so I prefered to stick to the same menu as default bootloader. > The implementation could remove the original menu, or it could insert > entries immediately below "safe mode". I don't know if it's possible, > but it could be useful. > Bean proposed something like this but I don't know his progress > Actually, I don't want osdetect.lua to be overengineered and overloaded > with intimate knowledge of different OSes. It's an example for others > to extend, not a complete solution. We put it into our repository this means that we accept improvements. I also think that there will be distributions similar to Super GRUB Disk and other recovery tools based on osdetect.lua. Unless we provide a good reference osdetect.lua there will be a bitrot between such distributions every one neglecting some OSes > > -- > Regards, > Pavel Roskin > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel >
-- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
