El jue, 14-08-2008 a las 19:15 +0200, Marco Gerards escribió:
> Javier Martín <[EMAIL PROTECTED]> writes:
>
> > Ok, making a mixup reply...
>
> Please don't. Unless you do not like it that your mails go unread.
>
> >> > Having a small kernel is highly desireable for most users. If the
> >> >
Javier Martín <[EMAIL PROTECTED]> writes:
> Ok, making a mixup reply...
Please don't. Unless you do not like it that your mails go unread.
>> > Having a small kernel is highly desireable for most users. If the kernel
>> > is
>> > too big, it won't fit and then either we have to use blocklists
Ok, making a mixup reply...
El mié, 13-08-2008 a las 17:14 +0200, Robert Millan escribió:
> On Wed, Aug 13, 2008 at 04:28:24PM +0200, Javier Martín wrote:
> > >
> > > I don't think this MODNAME approach is a bad idea per se [1][2], but if we
> > > are to do it, IMHO this should really be done gl
Robert Millan <[EMAIL PROTECTED]> writes:
[...]
>> > This is a lot of code being added to kernel, and space in kernel is highly
>> > valuable.
>> >
>> > Would the same functionality work if put inside a module?
>> For the reasons discussed above in the loader.h snippet, I don't think
>> so: the
On Wed, Aug 13, 2008 at 04:28:24PM +0200, Javier Martín wrote:
> >
> > I don't think this MODNAME approach is a bad idea per se [1][2], but if we
> > are to do it, IMHO this should really be done globally for consistency, and
> > preferably separately from this patch.
> >
> > [1] But I'd use a co
Hi,
Javier Martín <[EMAIL PROTECTED]> writes:
> El mié, 13-08-2008 a las 15:00 +0200, Robert Millan escribió:
>> Hi,
>>
>> Marco asked me to review this.
> So he finally got fed up of me... Understandable ^^
No, but I am not as qualified regarding the BIOS as Robert is, except
for general remar
El mié, 13-08-2008 a las 15:00 +0200, Robert Millan escribió:
> Hi,
>
> Marco asked me to review this.
So he finally got fed up of me... Understandable ^^
> I haven't followed the earlier discussion,
> so if I say or ask something that was discussed before, please bear with me
> and just point
On Wed, Aug 13, 2008 at 02:16:25PM +0200, Javier Martín wrote:
> +static grub_err_t
> +revparse_biosdisk(const grub_uint8_t dnum, const char **output)
Ah, and please separate function names from parenthesis ;-)
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide
Hi,
Marco asked me to review this. I haven't followed the earlier discussion,
so if I say or ask something that was discussed before, please bear with me
and just point me to that.
On Wed, Aug 13, 2008 at 02:16:25PM +0200, Javier Martín wrote:
> +
> +#define MODNAME "drivemap"
> +
> [...]
> +
El mié, 13-08-2008 a las 12:13 +0200, Marco Gerards escribió:
> Javier Martín <[EMAIL PROTECTED]> writes:
>
> > In this reply-to-myself hoping to keep the thread continuity, I put
> > forth the new "version 7" of the patch with the following changes:
> >
> > - A new switch -s/--swap has been imp
Javier Martín <[EMAIL PROTECTED]> writes:
> In this reply-to-myself hoping to keep the thread continuity, I put
> forth the new "version 7" of the patch with the following changes:
>
> - A new switch -s/--swap has been implemented, so that running
> "drivemap -s hd0 hd1" is equivalent to issuing
In this reply-to-myself hoping to keep the thread continuity, I put
forth the new "version 7" of the patch with the following changes:
- A new switch -s/--swap has been implemented, so that running
"drivemap -s hd0 hd1" is equivalent to issuing the command twice with
the arguments normal, then r
- Original Message
From: Felix Zielcke <[EMAIL PROTECTED]>
To: The development of GRUB 2
Sent: Friday, 8 August, 2008 6:50:12 PM
Subject: Re: [PATCH] Drivemap module
Am Mittwoch, den 06.08.2008, 19:31 +0200 schrieb Javier Martín:
> This will work on Windows, because no mat
Am Mittwoch, den 06.08.2008, 19:31 +0200 schrieb Javier Martín:
> This will work on Windows, because no matter where it tries to boot from
> it will find the same disk: both the first and second BIOS disks point
> to hd1 now.
> ...
> This is the setup I have
> extensively tested in QEMU, while th
From: Javier Martín <[EMAIL PROTECTED]>
To: The development of GRUB 2
Sent: Wednesday, 6 August, 2008 11:01:19 PM
Subject: Re: [PATCH] Drivemap module
El mié, 06-08-2008 a las 07:43 -0700, Viswesh S escribió:
> Hi,
>
>
>
> Could you let all know how to use your d
El mié, 06-08-2008 a las 07:43 -0700, Viswesh S escribió:
> Hi,
>
>
>
> Could you let all know how to use your drivemap command.Is it similar
> to the map command in legacy grub.
Hi there. Information about the use of a command is better placed in the
wiki than in this list, however this comma
On Tue, 05 Aug 2008 13:23:11 +0200
Marco Gerards <[EMAIL PROTECTED]> wrote:
> Hi Javier,
>
> Javier Martín <[EMAIL PROTECTED]> writes:
> > While tools like `svn diff' can help in these kind of problems,
> > their utility is greatly diminished if the offending change is part
> > of a multi-line ch
On Tue, 05 Aug 2008 01:10:25 +0200
Javier Martín <[EMAIL PROTECTED]> wrote:
> Besides, sometimes checks like "if (a=b)", or more
> frequently "if (a=f())" are intentionally used in C, so the error
> might become even more difficult to spot and correct.
Respect and heed the gcc warnings!!
Note th
Hi,
Javier Martín <[EMAIL PROTECTED]> writes:
>> Anyway, since "they" are more likely to maintain the code in
>> the long run than you, in general, the question is whether
>> the code is more likely to become buggy by their hacking on
>> it, if it follows project coding style or someone else's
Hi,
Javier Martín <[EMAIL PROTECTED]> writes:
>> > There is, however, one point in which I keep my objection: comparisons
>> > between a variable and a constant should be of the form CONSTANT ==
>> > variable and not in the reverse order, since an erroneous but quite
>> > possible change of == fo
Hi Javier,
Javier Martín <[EMAIL PROTECTED]> writes:
> El lun, 04-08-2008 a las 22:51 +0200, Marco Gerards escribió:
>> Javier Martín <[EMAIL PROTECTED]> writes:
>>
>> > After your latest replay, I "reevaluated" my stubbornness WRT some of
>> > your advices, and I've changed a few things:
>> >
>
Hi there and thanks for playing The Game!
El lun, 04-08-2008 a las 20:50 -0400, Isaac Dupree escribió:
> Javier Martín wrote:
> > You understand my concern, but seemingly do not understand that in order
> > to conform to the Holy Coding Style you are asking me to write code that
> > can become bug
Javier Martín wrote:
You understand my concern, but seemingly do not understand that in order
to conform to the Holy Coding Style you are asking me to write code that
can become buggy (and with a very hard to trace bug) with a simple
deltion! (point: did you notice that last word _without_ a spel
Javier Martín <[EMAIL PROTECTED]> writes:
> After your latest replay, I "reevaluated" my stubbornness WRT some of
> your advices, and I've changed a few things:
>
> - Variables are now declared (and, if possible, initialized) before
> precondition checks, even simple ones. The install_int13_handle
After your latest replay, I "reevaluated" my stubbornness WRT some of
your advices, and I've changed a few things:
- Variables are now declared (and, if possible, initialized) before
precondition checks, even simple ones. The install_int13_handler
function has not been modified, however, since I f
Javier Martín <[EMAIL PROTECTED]> writes:
> El dom, 20-07-2008 a las 21:40 +0200, Marco Gerards escribió:
>> Did you use code from other people or projects?
> No, as far as I can control my own mind: the assembly int13h handler is
> loosely based on that of GRUB Legacy, but heavily rewritten. All
On Mon, Jul 21, 2008 at 02:55:41AM +0200, Javier Martín wrote:
> Hmm... isn't the ChangeLog too spartan?
I tend to agree with that. I don't mind as much, as I get used myself, but
it's really a PITA sometimes.
--
Robert Millan
I know my rights; I want my phone call!
What good is a phone call
El lun, 21-07-2008 a las 02:55 +0200, Javier Martín escribió:
> (...)
> Phew! That was long, even after removing some parts. Well, this is the
> new version of the patch. Cheers!
As always, I'm so stupid that I left the patch out... Sigh. Here it is.
Habbit
Index: commands/i386/pc/drivemap.c
=
El dom, 20-07-2008 a las 21:40 +0200, Marco Gerards escribió:
> Did you use code from other people or projects?
No, as far as I can control my own mind: the assembly int13h handler is
loosely based on that of GRUB Legacy, but heavily rewritten. All other
code was written from scratch, even the crap
Javier Martín <[EMAIL PROTECTED]> writes:
> Just an updated version of the patch that adds support for device-like
> names instead of raw BIOS disk numbers, i.e. this is now supported:
> grub> drivemap (hd0) (hd1)
> In addition to the already supported:
> grub> drivemap (hd0) 0x81
> Th
El sáb, 05-07-2008 a las 13:04 +0200, Marco Gerards escribió:
> Javier Martín <[EMAIL PROTECTED]> writes:
>
> > Just an updated version of the patch that adds support for device-like
> > names instead of raw BIOS disk numbers, i.e. this is now supported:
> > grub> drivemap (hd0) (hd1)
> > In a
Javier Martín <[EMAIL PROTECTED]> writes:
> Just an updated version of the patch that adds support for device-like
> names instead of raw BIOS disk numbers, i.e. this is now supported:
> grub> drivemap (hd0) (hd1)
> In addition to the already supported:
> grub> drivemap (hd0) 0x81
> Th
On Thu, 12 Jun 2008 21:00:21 -0400
Pavel Roskin <[EMAIL PROTECTED]> wrote:
> On Thu, 2008-06-12 at 15:58 -0700, Colin D Bennett wrote:
> > I highly recommend running
> >
> > indent --no-tabs
>
> Why no tabs? Tabs are heavily used in the code. GNU indent is
> supposed to default to GNU Coding
El jue, 12-06-2008 a las 21:37 -0400, Pavel Roskin escribió:
> I mean the lines your patch adds.
> (...)
> retVal is still there. Please call it "ret", it's the traditional name
> of the variable to be returned.
Ok, both of this completely corrected now thanks to Colin's script and
the dear "fin
On Fri, 2008-06-13 at 00:43 +0200, Javier Martín wrote:
> El jue, 12-06-2008 a las 16:31 -0400, Pavel Roskin escribió:
> > Please don't add any trailing whitespace. Line in the patch that start
> > with a plus should not end with a space or a tab.
> I could not find the line you were referring to
On Thu, 2008-06-12 at 15:58 -0700, Colin D Bennett wrote:
> I think Pavel meant the lines added by the patch, i.e., beginning with
> a plus in the patch, not in the original source.
Yes, I meant added lines. There is a lot of code that needs
reformatting, but the patch shouldn't add more to that
On Fri, 13 Jun 2008 00:43:31 +0200
Javier Martín <[EMAIL PROTECTED]> wrote:
> Hi there, I checked your comment, reread the GNU coding guidelines and
> fixed some things (stated below the relevant parts of your message).
> Here is the new version of the patch.
>
> El jue, 12-06-2008 a las 16:31 -0
Hi there, I checked your comment, reread the GNU coding guidelines and
fixed some things (stated below the relevant parts of your message).
Here is the new version of the patch.
El jue, 12-06-2008 a las 16:31 -0400, Pavel Roskin escribió:
> Please don't add any trailing whitespace. Line in the pa
On Tue, 2008-06-10 at 23:31 +0200, Javier Martín wrote:
> Ok, I'm sorry and don't mean to be intrusive, I just thought the last
> messages might have got lost between mail filters - it's happened to me.
Here's my very superficial review.
Please don't add any trailing whitespace. Line in the pat
Hi Javier,
Javier Martín <[EMAIL PROTECTED]> writes:
> Since the last posts in the "reimplementing the legacy map command"
> thread seemingly died silently, I'm sending the improved version of the
> patch here. If the death of the thread was intentional, please just tell
> me (either nicely or ru
El mar, 10-06-2008 a las 23:23 +0300, Vesa Jääskeläinen escribió:
> Javier Martín wrote:
> > Since the last posts in the "reimplementing the legacy map command"
> > thread seemingly died silently, I'm sending the improved version of the
> > patch here. If the death of the thread was intentional, pl
Javier Martín wrote:
Since the last posts in the "reimplementing the legacy map command"
thread seemingly died silently, I'm sending the improved version of the
patch here. If the death of the thread was intentional, please just tell
me (either nicely or rudely) and I'll be off.
I'll answer thi
42 matches
Mail list logo
