On Thu, 2008-06-12 at 15:58 -0700, Colin D Bennett wrote: > I think Pavel meant the lines added by the patch, i.e., beginning with > a plus in the patch, not in the original source.
Yes, I meant added lines. There is a lot of code that needs reformatting, but the patch shouldn't add more to that. > I highly recommend running > > indent --no-tabs Why no tabs? Tabs are heavily used in the code. GNU indent is supposed to default to GNU Coding Standards, and it uses tabs. > on your source code, as long as it doesn't cause too many spurious > changes to pre-existing code. It will. > This should take care of most formatting > inconsistencies and frees you a little but from concerning yourself > with trivial details. We can use a script to re-indent everything. Then new patches could be easily run through the same script. Otherwise, it's not going to be simple. -- Regards, Pavel Roskin _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel