Re: [PATCH] Don't abort if prefix is not set

2008-01-27 Thread Robert Millan
On Sat, Jan 26, 2008 at 03:31:34PM -0500, Pavel Roskin wrote: > >>I found that prefix would not be set on PowerPC if /memory/available > >>is missing. > > > >Sounds strange.. how is that so? > > Because the environment is allocated in the heap, I believe. It is, but I'd have expected GRUB to issu

Re: [PATCH] Don't abort if prefix is not set

2008-01-26 Thread Vesa Jääskeläinen
Robert Millan wrote: On Sat, Jan 26, 2008 at 03:11:02PM -0500, Pavel Roskin wrote: Quoting Robert Millan <[EMAIL PROTECTED]>: + if (! grub_dl_dir) { +grub_error (GRUB_ERR_FILE_NOT_FOUND, "\"prefix\" is not set"); +return 0; Seems fine, but are you sure this error is handled somewhere

Re: [PATCH] Don't abort if prefix is not set

2008-01-26 Thread Pavel Roskin
Quoting Robert Millan <[EMAIL PROTECTED]>: On Sat, Jan 26, 2008 at 03:11:02PM -0500, Pavel Roskin wrote: Quoting Robert Millan <[EMAIL PROTECTED]>: >>+ if (! grub_dl_dir) { >>+grub_error (GRUB_ERR_FILE_NOT_FOUND, "\"prefix\" is not set"); >>+return 0; > >Seems fine, but are you sure t

Re: [PATCH] Don't abort if prefix is not set

2008-01-26 Thread Robert Millan
On Sat, Jan 26, 2008 at 03:11:02PM -0500, Pavel Roskin wrote: > Quoting Robert Millan <[EMAIL PROTECTED]>: > > >>+ if (! grub_dl_dir) { > >>+grub_error (GRUB_ERR_FILE_NOT_FOUND, "\"prefix\" is not set"); > >>+return 0; > > > >Seems fine, but are you sure this error is handled somewhere? >

Re: [PATCH] Don't abort if prefix is not set

2008-01-26 Thread Pavel Roskin
Quoting Robert Millan <[EMAIL PROTECTED]>: + if (! grub_dl_dir) { +grub_error (GRUB_ERR_FILE_NOT_FOUND, "\"prefix\" is not set"); +return 0; Seems fine, but are you sure this error is handled somewhere? If prefix is not set, the module is not loaded. What other handling do we nee

Re: [PATCH] Don't abort if prefix is not set

2008-01-26 Thread Robert Millan
On Sat, Jan 26, 2008 at 02:44:44PM -0500, Pavel Roskin wrote: > > --- > > ChangeLog |5 + > kern/dl.c |6 -- > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/ChangeLog b/ChangeLog > index 009b4dc..44d5887 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1