Quoting Robert Millan <[EMAIL PROTECTED]>:

+  if (! grub_dl_dir) {
+    grub_error (GRUB_ERR_FILE_NOT_FOUND, "\"prefix\" is not set");
+    return 0;

Seems fine, but are you sure this error is handled somewhere?

If prefix is not set, the module is not loaded. What other handling do we need?

I found that prefix would not be set on PowerPC if /memory/available is missing. Even though I have a better workaround for it now, I still think that aborting for such minor reason is wrong. After all, the user may unset prefix.

--
Regards,
Pavel Roskin


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to