Re: [PATCH] Bug fix for ext2.c

2009-03-21 Thread Bean
Committed. -- Bean ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Bug fix for ext2.c

2009-03-16 Thread Bean
On Sun, Mar 15, 2009 at 11:37 PM, Robert Millan wrote: > On Sun, Mar 15, 2009 at 11:33:18AM +0100, Felix Zielcke wrote: >> Am Sonntag, den 15.03.2009, 14:00 +0800 schrieb Bean: >> >> > Hi, >> >> Hi Bean, >> >> > Oh right, this one should be ok. >> >> +    grub_error (GRUB_ERR_BAD_FS, "not an xfs f

Re: [PATCH] Bug fix for ext2.c

2009-03-15 Thread Robert Millan
On Sun, Mar 15, 2009 at 11:33:18AM +0100, Felix Zielcke wrote: > Am Sonntag, den 15.03.2009, 14:00 +0800 schrieb Bean: > > > Hi, > > Hi Bean, > > > Oh right, this one should be ok. > > +grub_error (GRUB_ERR_BAD_FS, "not an xfs filesystem"); > This should probable be `not an ext2 filesystem'

Re: [PATCH] Bug fix for ext2.c

2009-03-15 Thread Felix Zielcke
Am Sonntag, den 15.03.2009, 14:00 +0800 schrieb Bean: > Hi, Hi Bean, > Oh right, this one should be ok. +grub_error (GRUB_ERR_BAD_FS, "not an xfs filesystem"); This should probable be `not an ext2 filesystem' :) -- Felix Zielcke ___ Grub-devel

Re: [PATCH] Bug fix for ext2.c

2009-03-14 Thread Bean
On Sun, Mar 15, 2009 at 5:27 AM, Yoshinori K. Okuji wrote: > On Sunday 15 March 2009 01:16:23 Bean wrote: >> Hi, >> >> I've discovered a bug in ext2.c, inside grub_ext2_mount. The mount >> function must return GRUB_ERR_BAD_FS if something goes wrong, because >> grub_fs_probe would stop as soon as

Re: [PATCH] Bug fix for ext2.c

2009-03-14 Thread Yoshinori K. Okuji
On Sunday 15 March 2009 01:16:23 Bean wrote: > Hi, > > I've discovered a bug in ext2.c, inside grub_ext2_mount. The mount > function must return GRUB_ERR_BAD_FS if something goes wrong, because > grub_fs_probe would stop as soon as it sees a non-GRUB_ERR_BAD_FS > error, thus preventing other fs dri

Re: [PATCH] Bug fix for ext2.c

2009-03-14 Thread Bean
On Sun, Mar 15, 2009 at 1:35 AM, Robert Millan wrote: > On Sun, Mar 15, 2009 at 12:56:26AM +0800, Bean wrote: >> On Sun, Mar 15, 2009 at 12:37 AM, Robert Millan wrote: >> > On Sun, Mar 15, 2009 at 12:16:23AM +0800, Bean wrote: >> >> Hi, >> >> >> >> I've discovered a bug in ext2.c, inside grub_ext

Re: [PATCH] Bug fix for ext2.c

2009-03-14 Thread Robert Millan
On Sun, Mar 15, 2009 at 12:56:26AM +0800, Bean wrote: > On Sun, Mar 15, 2009 at 12:37 AM, Robert Millan wrote: > > On Sun, Mar 15, 2009 at 12:16:23AM +0800, Bean wrote: > >> Hi, > >> > >> I've discovered a bug in ext2.c, inside grub_ext2_mount. The mount > >> function must return GRUB_ERR_BAD_FS i

Re: [PATCH] Bug fix for ext2.c

2009-03-14 Thread Bean
On Sun, Mar 15, 2009 at 12:37 AM, Robert Millan wrote: > On Sun, Mar 15, 2009 at 12:16:23AM +0800, Bean wrote: >> Hi, >> >> I've discovered a bug in ext2.c, inside grub_ext2_mount. The mount >> function must return GRUB_ERR_BAD_FS if something goes wrong, because >> grub_fs_probe would stop as soo

Re: [PATCH] Bug fix for ext2.c

2009-03-14 Thread Robert Millan
On Sun, Mar 15, 2009 at 12:16:23AM +0800, Bean wrote: > Hi, > > I've discovered a bug in ext2.c, inside grub_ext2_mount. The mount > function must return GRUB_ERR_BAD_FS if something goes wrong, because > grub_fs_probe would stop as soon as it sees a non-GRUB_ERR_BAD_FS > error, thus preventing ot