On Sun, Mar 15, 2009 at 12:16:23AM +0800, Bean wrote: > Hi, > > I've discovered a bug in ext2.c, inside grub_ext2_mount. The mount > function must return GRUB_ERR_BAD_FS if something goes wrong, because > grub_fs_probe would stop as soon as it sees a non-GRUB_ERR_BAD_FS > error, thus preventing other fs driver from detecting the correct fs > type. This patch fixes the problem.
I think current behaviour is correct. If a failure is triggered by grub_disk_read(), from grub_fs_probe perspective it means something is fucked up other than just "this is not the FS we're looking for", so it should be aware of the difference. Or is grub_ext2_read_inode() failure the one that's causing trouble for you? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all." _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel