Re: UGA FB driver (Re: [GITGRUB] FB driver for EFI)

2009-11-27 Thread Seth Goldberg
On Nov 27, 2009, at 4:00 PM, Vladimir 'φ-coder/phcoder' Serbinenko m> wrote: Robert Millan wrote: I merged this patch, with some adjustments. GOP is intentionally left out. It depends on missing struct definitions not present in the patch, which would be easy to reconstruct based reusi

Re: UGA FB driver (Re: [GITGRUB] FB driver for EFI)

2009-11-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Robert Millan wrote: > I merged this patch, with some adjustments. > > GOP is intentionally left out. It depends on missing struct definitions > not present in the patch, which would be easy to reconstruct based reusing > UGA ones but I don't have the hardware to test it. > > I reconstructed GO

UGA FB driver (Re: [GITGRUB] FB driver for EFI)

2009-11-23 Thread Robert Millan
I merged this patch, with some adjustments. GOP is intentionally left out. It depends on missing struct definitions not present in the patch, which would be easy to reconstruct based reusing UGA ones but I don't have the hardware to test it. And in any case, our future direction are standalone,

Re: [GITGRUB] FB driver for EFI

2009-08-24 Thread Bean
Hi, BTW, with this latest driver, it's possible to start Colin's graphics menu on EFI. I've re-packaged the configure files for EFI and post it at: http://grub4dos.sourceforge.net/gfxmenu.zip On Tue, Aug 25, 2009 at 12:28 AM, Bean wrote: > Hi, > > Update: Add double buffer support for efi fb. >

Re: [GITGRUB] FB driver for EFI

2009-08-24 Thread Bean
Hi, Update: Add double buffer support for efi fb. -- Bean gitgrub home: http://github.com/grub/grub/ my fork page: http://github.com/bean123/grub/ ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [GITGRUB] FB driver for EFI

2009-08-23 Thread Robert Millan
On Wed, Aug 19, 2009 at 05:22:24PM +0200, Robert Millan wrote: > On Tue, Aug 18, 2009 at 09:26:45PM +0800, Bean wrote: > > Hi, > > > > Here is the raw patch. > > Thanks. Was efi_fb.c written from scratch, or copied/refurbished from another > part of GRUB ? It's ok either way, but we need to kno

Re: [GITGRUB] FB driver for EFI

2009-08-23 Thread Robert Millan
On Sun, Aug 23, 2009 at 01:07:55PM +0200, Robert Millan wrote: > > Btw, the patch itself looks fine to me. When you commit it, please make sure > its ChangeLog entry documents whether this was moved from another part of GRUB > or is new code. Erm, sorry I didn't notice that Vladimir raised some

Re: [GITGRUB] FB driver for EFI

2009-08-19 Thread Robert Millan
On Wed, Aug 19, 2009 at 02:25:08AM +0800, Bean wrote: > > Have you tried linux_video_setup as present in i386/linux.c in > > i386/efi/linux.c ? It would be nice if we could share more code > > between these 2 files. If it works and you judge that  i386/linux.c > > and i386/efi/linux.c are similar e

Re: [GITGRUB] FB driver for EFI

2009-08-19 Thread Robert Millan
On Tue, Aug 18, 2009 at 09:26:45PM +0800, Bean wrote: > Hi, > > Here is the raw patch. Thanks. Was efi_fb.c written from scratch, or copied/refurbished from another part of GRUB ? It's ok either way, but we need to know about it. Would you please send a ChangeLog entry where this is referenced

Re: [GITGRUB] FB driver for EFI

2009-08-18 Thread Bean
On Wed, Aug 19, 2009 at 2:02 AM, Vladimir 'phcoder' Serbinenko wrote: > +grub_uint32_t uga_fb; > +grub_uint32_t uga_pitch; > + > Why are these variables global? They should be either static or > properly prefixed. Hi, Yeah, I have noticed this just after pushing to repo, so I add the static prefi

Re: [GITGRUB] FB driver for EFI

2009-08-18 Thread Vladimir 'phcoder' Serbinenko
+grub_uint32_t uga_fb; +grub_uint32_t uga_pitch; + Why are these variables global? They should be either static or properly prefixed. Have you tried linux_video_setup as present in i386/linux.c in i386/efi/linux.c ? It would be nice if we could share more code between these 2 files. If it works an

Re: [GITGRUB] FB driver for EFI

2009-08-18 Thread Bean
Hi, Here is the raw patch. On Mon, Aug 17, 2009 at 9:46 PM, Robert Millan wrote: > On Sun, Aug 16, 2009 at 03:20:19PM +0800, Bean wrote: >> Hi, >> >> This patch adds efi fb driver, with it, you can use graphic mode in EFI. >> >> Add the following modules in grub.efi: >> >> video efi_fb gfxterm fo

Re: [GITGRUB] FB driver for EFI

2009-08-17 Thread Robert Millan
On Sun, Aug 16, 2009 at 03:20:19PM +0800, Bean wrote: > Hi, > > This patch adds efi fb driver, with it, you can use graphic mode in EFI. > > Add the following modules in grub.efi: > > video efi_fb gfxterm font png jpeg > > And use this in grub.cfg to enable graphics mode: (0x0 means use the > c

Re: [GITGRUB] FB driver for EFI

2009-08-17 Thread Vladimir 'phcoder' Serbinenko
On Sun, Aug 16, 2009 at 8:48 PM, Vladimir 'phcoder' Serbinenko wrote: > On Sun, Aug 16, 2009 at 9:20 AM, Bean wrote: >> Hi, >> >> This patch adds efi fb driver, with it, you can use graphic mode in EFI. >> > framebuffer.mode_info.bpp = 32; In the case of GOP you check that depth is 32 bit. Wh

Re: [GITGRUB] FB driver for EFI

2009-08-16 Thread Vladimir 'phcoder' Serbinenko
On Sun, Aug 16, 2009 at 9:20 AM, Bean wrote: > Hi, > > This patch adds efi fb driver, with it, you can use graphic mode in EFI. > > Add the following modules in grub.efi: > > video efi_fb gfxterm font png jpeg > > And use this in grub.cfg to enable graphics mode: (0x0 means use the > current screen