On Wed, Aug 19, 2009 at 2:02 AM, Vladimir 'phcoder' Serbinenko<phco...@gmail.com> wrote: > +grub_uint32_t uga_fb; > +grub_uint32_t uga_pitch; > + > Why are these variables global? They should be either static or > properly prefixed.
Hi, Yeah, I have noticed this just after pushing to repo, so I add the static prefix in the ofw efi commit. > > Have you tried linux_video_setup as present in i386/linux.c in > i386/efi/linux.c ? It would be nice if we could share more code > between these 2 files. If it works and you judge that i386/linux.c > and i386/efi/linux.c are similar enough you can merge them using > ifdef's when needed It should be ok to merge i386/efi/linux.c with i386/linux.c now that the fb detection code is separated. -- Bean gitgrub home: http://github.com/grub/grub/ my fork page: http://github.com/bean123/grub/ _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
