Meanwhile,
patch was rebuild for upstream version
still has two problems I've mentioned before
--
With best regards,
___
Vladimir Testov, ROSA Laboratory.
www.rosalab.rudiff -Naur grub-new2/grub-core/gfxmenu/font.c grub-new3/grub-core/gfxmenu/font.c
--- grub-new2/gr
> Looks like I've misunderstood something... Sorry. Can't see where the problem
> is...
>
blit_comb has dry run mode and it's what's used to get constructed length.
signature.asc
Description: OpenPGP digital signature
___
Grub-devel mailing list
Gr
On Wednesday, April 17, 2013 01:02:44 PM Vladimir Testov wrote:
> O.k. Here it is.
>
> from grub-core/font/font.c line 1387 function blit_comb :
> >do_blit (combining_glyphs[i],
> >
> >main_glyph->device_width
> >
> >
On Wednesday, April 17, 2013 01:02:44 PM Vladimir Testov wrote:
> Suggested patch to fix this problem (second one) is attached.
Nope, it won't help. I'll think again...
--
With best regards,
___
Vladimir Testov, ROSA Laboratory.
www.rosalab.ru
On Wednesday, April 17, 2013 09:01:47 AM Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> Don't write any line-breaking at all yourself.
I did not write any line-breaking. It is existing line-breaking. And it have
one algorithmic problem. Do not see any problem if I will fix the problem.
The pro
On 16.04.2013 11:04, Vladimir Testov wrote:
>> Please don't use // comments.
> O.k. I won't.
>> This code completely forgets the cases
>> when even the first word doesn't fit in the available space.
>
> Mmm. It can handle this case actually.
>
>> The code as whole breaks some unicode concepts li
On Tuesday, April 16, 2013 09:10:23 PM Andrey Borzenkov wrote:
> > +/* Differs from grub_font_draw_line only in multiline output */
>
> You mean grub_font_draw_string? Is it possible to extend this function
> instead of duplicating it?
Hmmm... I'll think through it. Would it be wise? The sets of
В Tue, 16 Apr 2013 13:04:28 +0400
Vladimir Testov пишет:
> >Please don't use // comments.
> O.k. I won't.
> >This code completely forgets the cases
> >when even the first word doesn't fit in the available space.
>
> Mmm. It can handle this case actually.
>
> >The code as whole breaks some unico
>Please don't use // comments.
O.k. I won't.
>This code completely forgets the cases
>when even the first word doesn't fit in the available space.
Mmm. It can handle this case actually.
>The code as whole breaks some unicode concepts like e.g. bidi stack.
Didn't get what you mean.
>Could you re
On 22.03.2013 16:58, Vladimir Testov wrote:
> +word_width = label_string_width (buf, font, l_lastend, end);
> +if (isvertical || (str_width + word_width > l_width)) // can't add new
> word
> + {
Please don't use // comments. This code completely forgets the cases
when even the first
muiltistring changed to multiline
(now we have multiline)
--
With best regards,
___
Vladimir Testov, ROSA Laboratory.
www.rosalab.rudiff -Naur grub-2.00/grub-core/gfxmenu/gui_label.c grub-new/grub-core/gfxmenu/gui_label.c
--- grub-2.00/grub-core/gfxmenu/gui_label.c 2012
Kind of a nitpick, but I think it would be better to call it multi line support
instead.
From: vladimir.tes...@rosalab.ru
To: grub-devel@gnu.org
Subject: [PATCH] multistring support in gui_label
Date: Thu, 21 Mar 2013 21:17:51 +0400
This time I've managed not to break backward compatibility.
N
12 matches
Mail list logo
