Re: merging i386-efi and x86_64-efi (Re: Current SVN is broken on x86_64)

2008-08-07 Thread Robert Millan
On Thu, Aug 07, 2008 at 02:21:03PM +0200, Robert Millan wrote: > On Mon, Aug 04, 2008 at 08:51:25AM -0400, Pavel Roskin wrote: > > On Mon, 2008-08-04 at 11:16 +0200, Robert Millan wrote: > > > > > Furthermore, I had a look and some of the x86_64 versions are just stubs > > > that > > > include th

merging i386-efi and x86_64-efi (Re: Current SVN is broken on x86_64)

2008-08-07 Thread Robert Millan
On Mon, Aug 04, 2008 at 08:51:25AM -0400, Pavel Roskin wrote: > On Mon, 2008-08-04 at 11:16 +0200, Robert Millan wrote: > > > Furthermore, I had a look and some of the x86_64 versions are just stubs > > that > > include the i386 one. > > > > Why don't we handle this like Linux? They ship a sing

Re: Current SVN is broken on x86_64

2008-08-04 Thread Pavel Roskin
On Mon, 2008-08-04 at 17:11 +0200, Robert Millan wrote: > Ok, but I think the i386->x86 rename would be overkill. We're already using > i386/ headers on x86_64 (for example, when building util/ stuff in grub-pc). > It > doesn't hurt if we continue doing that IMHO. Fine with me. -- Regards, Pa

Re: Current SVN is broken on x86_64

2008-08-04 Thread Robert Millan
On Mon, Aug 04, 2008 at 08:51:25AM -0400, Pavel Roskin wrote: > On Mon, 2008-08-04 at 11:16 +0200, Robert Millan wrote: > > > Furthermore, I had a look and some of the x86_64 versions are just stubs > > that > > include the i386 one. > > > > Why don't we handle this like Linux? They ship a sing

Re: Current SVN is broken on x86_64

2008-08-04 Thread Pavel Roskin
On Mon, 2008-08-04 at 11:16 +0200, Robert Millan wrote: > Furthermore, I had a look and some of the x86_64 versions are just stubs that > include the i386 one. > > Why don't we handle this like Linux? They ship a single directory and use > #ifdefs where appropiate. That enforces consistency in

Re: Current SVN is broken on x86_64

2008-08-04 Thread Robert Millan
On Mon, Aug 04, 2008 at 01:02:41AM -0400, Pavel Roskin wrote: > > I confirm it. And the i386-pc platform grew new warnings: > > kern/main.c: In function 'grub_set_root_dev': > kern/main.c:108: warning: implicit declaration of function 'grub_free' > loader/i386/pc/multiboot.c: In function 'grub_m

Re: Current SVN is broken on x86_64

2008-08-04 Thread Robert Millan
On Mon, Aug 04, 2008 at 02:31:28AM +0200, Felix Zielcke wrote: > I just tried to compile the Debian packages with the currently SVN > version and it failed: > > cc -Iloader/i386/efi -I/home/fz/grub/grub2-1.96+20080804/loader/i386/efi -I. > -Iinclude -I/home/fz/grub/grub2-1.96+20080804/include -Wa

Re: Current SVN is broken on x86_64

2008-08-03 Thread Pavel Roskin
On Mon, 2008-08-04 at 02:31 +0200, Felix Zielcke wrote: > I just tried to compile the Debian packages with the currently SVN > version and it failed: > > cc -Iloader/i386/efi -I/home/fz/grub/grub2-1.96+20080804/loader/i386/efi -I. > -Iinclude -I/home/fz/grub/grub2-1.96+20080804/include -Wall -W

Current SVN is broken on x86_64

2008-08-03 Thread Felix Zielcke
I just tried to compile the Debian packages with the currently SVN version and it failed: cc -Iloader/i386/efi -I/home/fz/grub/grub2-1.96+20080804/loader/i386/efi -I. -Iinclude -I/home/fz/grub/grub2-1.96+20080804/include -Wall -W -Wall -W -Wshadow -Wpointer-arith -Wmissing-prototypes