Re: [SECURITY PATCH 18/73] fs/ntfs: Implement attribute verification

2025-03-03 Thread Thomas Schmitt via Grub-devel
Hi, i wrote: > > it is quite some hurdle that some of the tests need to be run as > > superuser. Glenn Washburn wrote: > Yes, not ideal. I have spent an embarrassing amount of time developing > scripts that do away with with root requirement, and it works. The way > they are able to run the root

Re: [SECURITY PATCH 18/73] fs/ntfs: Implement attribute verification

2025-03-03 Thread Glenn Washburn
On Sun, 02 Mar 2025 09:41:28 +0100 "Thomas Schmitt" wrote: > Hi, > > Glenn Washburn wrote: > > Seems like running them the tests before > > committing large patch series, like this security update, might be a > > good idea. > > I think that any change of the filesystem code should be tested as

Re: [SECURITY PATCH 18/73] fs/ntfs: Implement attribute verification

2025-03-02 Thread Thomas Schmitt via Grub-devel
Hi, Glenn Washburn wrote: > Seems like running them the tests before > committing large patch series, like this security update, might be a > good idea. I think that any change of the filesystem code should be tested as much as possible. But it is quite some hurdle that some of the tests need to

Re: [SECURITY PATCH 18/73] fs/ntfs: Implement attribute verification

2025-03-02 Thread Thomas Schmitt via Grub-devel
Hi, Glenn Washburn wrote: > Seems like running them the tests before > committing large patch series, like this security update, might be a > good idea. I think that any change of the filesystem code should be tested as much as possible. But it is quite some hurdle that some of the tests need to

Re: [SECURITY PATCH 18/73] fs/ntfs: Implement attribute verification

2025-03-01 Thread Glenn Washburn
On Fri, 28 Feb 2025 14:04:51 +0100 Daniel Kiper via Grub-devel wrote: > Huh! > > B Horn, may I ask you to take a look at this and prepare a fix? > > Andreas, please help with testing the fix. Not that anyone cares, but this regression was caught by the file system tests. It causes grub-fstest

Re: [SECURITY PATCH 18/73] fs/ntfs: Implement attribute verification

2025-02-28 Thread Andreas Klauer
Hello, (I'm not on this list; hope this message finds you well.) it seems that this patch triggers an infinite loop when trying to access ntfs, so any search command that comes across any ntfs partition gets stuck. Basically this while-loop in find_attr() while (at->attr_cur < mft_end && *a

Re: [SECURITY PATCH 18/73] fs/ntfs: Implement attribute verification

2025-02-28 Thread Daniel Kiper via Grub-devel
Huh! B Horn, may I ask you to take a look at this and prepare a fix? Andreas, please help with testing the fix. Daniel On Fri, Feb 28, 2025 at 10:55:46AM +0100, Andreas Klauer wrote: > Hello, > > (I'm not on this list; hope this message finds you well.) > > it seems that this patch triggers an

[SECURITY PATCH 18/73] fs/ntfs: Implement attribute verification

2025-02-18 Thread Daniel Kiper via Grub-devel
From: B Horn It was possible to read OOB when an attribute had a size that exceeded the allocated buffer. This resolves that by making sure all attributes that get read are fully in the allocated space by implementing a function to validate them. Defining the offsets in include/grub/ntfs.h but t