Re: [PATCH v3 02/10] luks2: Improve readability in luks2_get_keyslot.

2020-10-30 Thread Daniel Kiper
On Thu, Oct 29, 2020 at 04:52:55PM -0500, Glenn Washburn wrote: > On Fri, 23 Oct 2020 14:14:52 +0200 > Daniel Kiper wrote: > > On Mon, Oct 19, 2020 at 06:09:50PM -0500, Glenn Washburn wrote: > > > Introduce new variables keyslot_key, digest_key, and segment_key > > > which represent the integer ke

Re: [PATCH v3 02/10] luks2: Improve readability in luks2_get_keyslot.

2020-10-29 Thread Glenn Washburn
On Fri, 23 Oct 2020 14:14:52 +0200 Daniel Kiper wrote: > On Mon, Oct 19, 2020 at 06:09:50PM -0500, Glenn Washburn wrote: > > Introduce new variables keyslot_key, digest_key, and segment_key > > which represent the integer key of the item in the respective > > associative array when looping over t

Re: [PATCH v3 02/10] luks2: Improve readability in luks2_get_keyslot.

2020-10-23 Thread Daniel Kiper
On Mon, Oct 19, 2020 at 06:09:50PM -0500, Glenn Washburn wrote: > Introduce new variables keyslot_key, digest_key, and segment_key which > represent the integer key of the item in the respective associative array > when looping over the array items. This replaces using a generically > named variabl

[PATCH v3 02/10] luks2: Improve readability in luks2_get_keyslot.

2020-10-19 Thread Glenn Washburn
Introduce new variables keyslot_key, digest_key, and segment_key which represent the integer key of the item in the respective associative array when looping over the array items. This replaces using a generically named variable named "idx" used for all three values. The parameter "i" is renamed to