Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

2021-08-27 Thread Thomas Schmitt
Hi, i wrote: > > it might be contraproductive to set LANG=en_US.UTF-8. Glenn Washburn wrote: > My patch only sets LANG if empty, so in this case I don't think its > counterproductive, just not productive. Yes. It cautiously avoids to make the situation any worse. I meant my own announced plan wh

Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

2021-08-27 Thread Glenn Washburn
On Fri, 27 Aug 2021 21:13:17 +0200 "Thomas Schmitt" wrote: > Hi, > > it turns out that it might be contraproductive to set > LANG=en_US.UTF-8. > > If the LANG locale is not listed by > locale -a > then nl_langinfo(3) returns "ANSI_X3.4-1968". > I stumbled over this when testing LANG=de_DE.UTF

Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

2021-08-27 Thread Thomas Schmitt
Hi, it turns out that it might be contraproductive to set LANG=en_US.UTF-8. If the LANG locale is not listed by locale -a then nl_langinfo(3) returns "ANSI_X3.4-1968". I stumbled over this when testing LANG=de_DE.UTF8, which despite of my location is not an available locale on my machine. So i

Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

2021-08-26 Thread Glenn Washburn
On Thu, 26 Aug 2021 23:28:04 +0200 "Thomas Schmitt" wrote: > > If yes, then I should probably remove this patch altogether and put > > this code elsewhere. > > I think it can be justified to hardcode UTF-8 in grub-fs-tester > regardless whether higher levels of the test empire or the user have >

Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

2021-08-26 Thread Thomas Schmitt
Hi, i wrote: > > xorriso ... -as mkisofs -input-charset UTF-8 -output-charset UTF-8 Glenn Washburn wrote: > Do there need to be any UTF-8 locales installed (or any locales for > that matter) for this to work? My guess is no. I expect the same. It's not easy to test, though. In theory it is es

Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

2021-08-26 Thread Glenn Washburn
On Thu, 26 Aug 2021 19:49:37 +0200 "Thomas Schmitt" wrote: > Hi, > > now i know that i should have asked for the test-suite.log file. > > The problem turned out to be in Joliet, not in ISO 9660. > Because Joliet gets its file names and other texts encoded as UCS-2 > 16-bit characters it is inde

Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

2021-08-26 Thread Thomas Schmitt
Hi, now i know that i should have asked for the test-suite.log file. The problem turned out to be in Joliet, not in ISO 9660. Because Joliet gets its file names and other texts encoded as UCS-2 16-bit characters it is indeed inavoidable to define the meaning of the bytes in a Unix file name. The

Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

2021-08-26 Thread Glenn Washburn
On Thu, 26 Aug 2021 08:53:31 +0200 "Thomas Schmitt" wrote: > Hi, > > Glenn Washburn wrote: > > Despite having an alternative approach, do you have concerns or > > objections to my patch? > > Not specifically. I initially only wanted to mention that there is > a xorriso alternative to setting L

Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

2021-08-25 Thread Thomas Schmitt
Hi, Glenn Washburn wrote: > Despite having an alternative approach, do you have concerns or > objections to my patch? Not specifically. I initially only wanted to mention that there is a xorriso alternative to setting LANG. Both ways have different implications in detail. (LANG is global to the

Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

2021-08-25 Thread Glenn Washburn
Hi Thomas, On Wed, 25 Aug 2021 11:34:47 +0200 "Thomas Schmitt" wrote: > Hi, > > Glenn Washburn wrote: > > LANG must be set to something that supports international > > characters, otherwise xorriso will refuse to include the file with > > name having international characters, causing the test t

Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

2021-08-25 Thread Thomas Schmitt
Hi, Glenn Washburn wrote: > LANG must be set to something that supports international characters, > otherwise xorriso will refuse to include the file with name having > international characters, causing the test to fail. Can you tell me the exact error message from xorriso ? I have some difficult

[PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

2021-08-25 Thread Glenn Washburn
LANG must be set to something that supports international characters, otherwise xorriso will refuse to include the file with name having international characters, causing the test to fail. So if LANG is not set, set it to en_US.UTF-8, a very common UTF-8 locale. And if it is set, but does not look