Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

[Glenn Washburn]

On Thu, 26 Aug 2021 08:53:31 +0200
"Thomas Schmitt" <scdbac...@gmx.net> wrote:

> Hi,
> 
> Glenn Washburn wrote:
> >  Despite having an alternative approach, do you have concerns or
> > objections to my patch?
> 
> Not specifically. I initially only wanted to mention that there is
> a xorriso alternative to setting LANG. Both ways have different
> implications in detail. (LANG is global to the test code. The
> xorriso charset commands would affect only the xorriso run.)
> 
> But my attempt to reproduce the problem failed and i do not yet know
> why exactly your xorriso run had conversion problems although no
> explicit character set conversion was demanded. So i hoped for an
> enlightening error message.

Nope, no error message, I believe xorriso is working as intended.

Did you verify that running the test with LANG=, as I suggested in my
prior email, did indeed fail? I have attached an output log of the
iso9660_test failure. You can see that the file
"éàèüöäëñкирилица䏌䐓䏕Ελληνικά䏌䐓䏕" was converted to
"__________________________________________________________________".


Here is the argv array according to strace:
["xorriso", "--rockridge", "off", "-compliance", "rec_mtime", "-as",
"mkisofs", "-iso-level", "3", "-graft-points", "-J", "-joliet-long",
"-V",
"g;/_\303\251\344\217\214\344\220\223\344\217\225\344\216\233\344\216\276\344\217\264\320\272\320\270\321\202
u", "--modification-date=2021082616575500", "-o",
"/media/tmpfs/bootloader/testtmp/tmp.gZvxe3D0aH/joliet_512_512_1_0.img",
"/=/media/tmpfs/bootloader/testtmp/tmp.gZvxe3D0aH/master"]

> > So unless I'm
> > mistaken, you are confirming the issue this patch resolves.
> 
> It happens only if i tell xorriso explicitely that it shall convert to
> UTF-8. In the next step it vanishes when i also tell xorriso to also
> convert from UTF-8.

I missed that in the previous email. The biggest difference I see with
the grub test is that its getting the non-ASCII filename from the file
system and not being passed in as a commandline arg explicitly.

Glenn

Testing joliet filesystem with ./grub-fs-tester
xorriso 1.5.2 : RockRidge filesystem manipulator, libburnia project.

Drive current: -outdev 'stdio:/media/tmpfs/bootloader/testtmp/tmp.XrGFpM2KlN/joliet_512_512_1_0.img'
Media current: stdio file, overwriteable
Media status : is blank
Media summary: 0 sessions, 0 data blocks, 0 data, 4009m free
xorriso : WARNING : -volid text problematic as automatic mount point name
xorriso : WARNING : -volid text is too long for Joliet (32 > 16)
xorriso : WARNING : -volid text does not comply to ISO 9660 / ECMA 119 rules
Added to ISO image: directory '/'='/media/tmpfs/bootloader/testtmp/tmp.XrGFpM2KlN/master'
xorriso : UPDATE :     221 files added in 1 seconds
xorriso : UPDATE :     221 files added in 1 seconds
ISO image produced: 21557 sectors
Written to medium : 21557 sectors at LBA 0
Writing to 'stdio:/media/tmpfs/bootloader/testtmp/tmp.XrGFpM2KlN/joliet_512_512_1_0.img' completed successfully.

Device proc: Filesystem type procfs - Sector size 512B - Total size 0KiB
Device loop0: Filesystem type iso9660 - Label `g;/_____________' - Last modification time 2021-08-26 16:39:55 Thursday, UUID 2021-08-26-16-39-55-00 - Sector size 512B - Total size 43114KiB
Device host: Filesystem type hostfs - Sector size 512B - Total size 0KiB

ILIST FAIL
DIR          20210826163955 ./
DIR          20210826163955 ../
5242879      20210826163955 .!"#%@$%&'()+,-.<=>^{_}[]`|~.
DIR          20210826163955 0/
5242879      20210826163955 1.img
5242879      20210826163955 CaSe
5242879      20210826163955 __________________________________________________________________
972398       20210826163955 american-english
5242879      20210826163955 cAsE
5242879      20210826163955 hard
5242879      20210826163955 qwertzuiopasdfghjklyxcvbnm1234567890qwertzuiopasdfghjklyxcvbnm1234567890oiewqfiewioqoiqoiurqruewqoiuwoi
DIR          20210826163955 sdir/
total 31672
drwxrwxr-x 3 crass crass      60 Aug 26 16:39 0
-rw-rw-r-- 2 crass crass 5242879 Aug 26 16:39 1.img
-rw-rw-r-- 1 crass crass 5242879 Aug 26 16:39 CaSe
-rw-r--r-- 1 crass crass  972398 Aug 26 16:39 american-english
-rw-rw-r-- 1 crass crass 5242879 Aug 26 16:39 cAsE
-rw-rw-r-- 2 crass crass 5242879 Aug 26 16:39 hard
-rw-rw-r-- 1 crass crass 5242879 Aug 26 16:39 qwertzuiopasdfghjklyxcvbnm1234567890qwertzuiopasdfghjklyxcvbnm1234567890oiewqfiewioqoiqoiurqruewqoiuwoi
drwxrwxr-x 2 crass crass      60 Aug 26 16:39 sdir
-rw-rw-r-- 1 crass crass 5242879 Aug 26 16:39 éàèüöäëñкирилица䏌䐓䏕Ελληνικά䏌䐓䏕
FAIL iso9660_test (exit status: 1)

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel